Public: anyone can read this; the crew can change it.
The comment box under an issue or pull is a plain field and button, not a boxed card #10065
mason/forge:mason/10051-the-comment-box-under-an-issue-or-pull-i → main 2 commits fork
3 files
changed +5
−3
docs/design/areas/comments.md +1 −1
| @@ -6,5 +6,5 @@ A comment on an issue or pull, and the form that writes one. Both are a `card()` | ||
| 6 | 6 | - `.comment-head` — the one line of byline, verb and time at the top of a `.comment-row`. |
| 7 | 7 | - `.comment` — an inline review comment as a card: its `.card-head` (byline and time) on the muted ground, the body under it. Written only by `reviewRows()` in `src/web/diff-view.ts`; styled in `src/web/style/components.ts`, and spaced inside a review thread by `.dc-review .comment` in `src/web/style/content.ts`. |
| 8 | 8 | - `.comment-body` — a comment's rendered markdown, always beside `.prose`: padded inside a `.comment` card, unpadded in a `.comment-row` (written by `commentCard()` in `src/web/comments.ts`); `reviewRows()` in `src/web/diff-view.ts` and `reviewEntry()` in `src/web/studio/change.ts`; styled in `src/web/style/components.ts` (tighter in a timeline event's card). |
| 9 | - `.comment-form` — the card that writes a comment: a textarea and its `.form-actions`. Written by `composer()` and `editForm()` in `src/web/pages/thread.ts`, `reviewRows()` in `src/web/diff-view.ts` (a reply in a review thread) and `studioApp()` in `src/web/studio/app.ts` (the "Tell the crew" box); styled in `src/web/style/components.ts`, with its narrow-screen action line and its review-thread margin in `src/web/style/content.ts`. | |
| 9 | - `.comment-form` — the form that writes a comment: a textarea and its `.form-actions`. On a thread (`composer()`) it is plain lines under the timeline, no `card`, spaced like the home composer; a review reply and the studio box add `card`, and the floating `.tell-here` box gets its card look from its own rule. Written by `composer()` and `editForm()` in `src/web/pages/thread.ts`, `reviewRows()` in `src/web/diff-view.ts` (a reply in a review thread) and `studioApp()` in `src/web/studio/app.ts` (the "Tell the crew" box); styled in `src/web/style/components.ts`, with its narrow-screen action line and its review-thread margin in `src/web/style/content.ts`. | |
| 10 | 10 | - `.tl-earlier` — the line above a long thread's newest items, `Show N earlier items`, a plain link to `?all=1`. Written by `conversation()` in `src/web/pages/thread.ts`; styled in `src/web/style/components.ts` beside `.tl-item`, indented to the timeline's item column. |
src/web/pages/thread.ts +1 −1
| @@ -593,7 +593,7 @@ export function composer(ctx: Ctx, o: ComposerOptions): Html { | ||
| 593 | 593 | const tell = o.tell; |
| 594 | 594 | return html`${stateForm} |
| 595 | 595 | <form |
| 596 | class="card comment-form" | |
| 596 | class="comment-form" | |
| 597 | 597 | method="post" |
| 598 | 598 | action="${o.action}" |
| 599 | 599 | data-box="${tell ? "Tell the crew" : "Write a comment"}" |
src/web/style/components.ts +3 −1
| @@ -747,7 +747,7 @@ details[open] > summary.row > .row-lead { transform: rotate(90deg); } | ||
| 747 | 747 | /* ---- tell the crew, in place: fixed, so nothing shifts ---- */ |
| 748 | 748 | .tell-here { position: fixed; left: 0; right: 0; bottom: 0; z-index: 50; width: min(620px, 100%); margin: 0 auto; padding: 8px; } |
| 749 | 749 | .tell-picture { max-width: 100%; height: auto; } |
| 750 | .tell-here .comment-form { margin: 0; box-shadow: var(--shadow-2); } | |
| 750 | .tell-here .comment-form { margin: 0; padding: 12px; background: var(--card); border: 1px solid var(--border); border-radius: var(--radius); box-shadow: var(--shadow-2); } | |
| 751 | 751 | |
| 752 | 752 | /* ---- command palette ---- */ |
| 753 | 753 | /* A dialog centres itself with its own auto margins, which the reset zeroes |
| @@ -906,6 +906,8 @@ details[open] > summary.row > .row-lead { transform: rotate(90deg); } | ||
| 906 | 906 | .comment-row .comment-body { padding: 4px 0 0; } |
| 907 | 907 | .comment-form { margin-top: 16px; padding: 12px; overflow: visible; } |
| 908 | 908 | .comment-form textarea { margin-bottom: 10px; } |
| 909 | /* The thread's composer is plain lines under the timeline, like the home one. */ | |
| 910 | .comment-form:not(.card) { padding: 0; margin-top: 16px; } | |
| 909 | 911 | |
| 910 | 912 | /* ---- empty state ---- */ |
| 911 | 913 | .empty { |
new above
offline