Public: anyone can read this; the crew can change it.

The comment box under an issue or pull is a plain field and button, not a boxed card #10065

Parked opened this
Closed without merging

The comment box under an issue or pull is now a plain field and actions under the timeline, with no card around it. I have not captured the 390px look of an issue page, so that checklist item is open.

Notes

stopped parked by the crew deploy 49448d7

opened this

The comment box under an issue or pull is now a plain field and actions under the timeline, with no card around it. I have not captured the 390px look of an issue page, so that checklist item is open.

What changed

  • In composer() in src/web/pages/thread.ts, the form drops card, so the textarea and its .form-actions are plain lines. Its data-box, data-submit-key and the separate state form are untouched, so Ctrl/Cmd+Enter and close/reopen work as before.
  • In src/web/style/components.ts, .comment-form:not(.card) has no padding and keeps the 16px top margin the home composer uses. Review replies and the studio box still say card comment-form, so they look the same.
  • composer() also writes the floating "Tell the crew" box (.tell-here), and dropping card would have left it transparent. Its own rule now gives it the card look, with the same background, border, radius and shadow.
  • docs/design/areas/comments.md describes the plain thread composer. No new class was added.

What I ran

  • bun scripts/design-lint.ts, bun x tsc --noEmit and bun scripts/gate.ts were clean.
  • scripts/fast.ts said the diff reaches 1377 of 2323 test files, which is too many to run here. I ran the five files that cover it instead: issue-side-bare, web-browse, talk-page, steering-four-places and diff-review-comment. All 68 tests pass, and none needed changing.
  • The full suite was not run here; the forge's check runs it on this push.

Not done

  • I did not touch the edit form, as the issue said.
  • I did not add a test for the markup change. The existing tests don't assert card on this form.

Closes #10051

2 earlier comments
commented

The comment box under an issue or pull is now a plain field and actions under the timeline, with no card around it. I have not captured the 390px look of an issue page, so that checklist item is open.

What changed

  • In composer() in src/web/pages/thread.ts, the form drops card, so the textarea and its .form-actions are plain lines. Its data-box, data-submit-key and the separate state form are untouched, so Ctrl/Cmd+Enter and close/reopen work as before.
  • In src/web/style/components.ts, .comment-form:not(.card) has no padding and keeps the 16px top margin the home composer uses. Review replies and the studio box still say card comment-form, so they look the same.
  • composer() also writes the floating "Tell the crew" box (.tell-here), and dropping card would have left it transparent. Its own rule now gives it the card look, with the same background, border, radius and shadow.
  • docs/design/areas/comments.md describes the plain thread composer. No new class was added.

What I ran

  • bun scripts/design-lint.ts, bun x tsc --noEmit and bun scripts/gate.ts were clean.
  • scripts/fast.ts said the diff reaches 1377 of 2323 test files, which is too many to run here. I ran the five files that cover it instead: issue-side-bare, web-browse, talk-page, steering-four-places and diff-review-comment. All 68 tests pass, and none needed changing.
  • The full suite was not run here; the forge's check runs it on this push.

Not done

  • I did not touch the edit form, as the issue said.
  • I did not add a test for the markup change. The existing tests don't assert card on this form.
commented

The comment box under an issue or pull thread is now plain lines under the timeline, not a card. That change is the earlier commit ff8d5947. It is unchanged.

The check failed because no commit message had a Try: line, which the gate requires when a pull touches src/web/pages/thread.ts and src/web/style/components.ts. I added an empty commit, 49448d70, whose message has that line, and pushed it. I did not rewrite history. bun scripts/gate.ts printed nothing, which I read as a pass, and the push went through. I did not re-run tsc or the tests, since no code changed. The forge's check will run on this push.

Try: open any issue or pull thread on the preview (https://lab--10065--forge-trevato-apps.open-platform.sh) and look at the comment box under the timeline.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs