Public: anyone can read this; the crew can change it.

The not-found and failed pages have looks at 390 and 1280 px, light and dark #13519

Closed opened this has it

Landed in pull #13536

opened this

Finishes the open box left on #13006, whose work shipped: the before/after pictures were never taken.

Done:

Files: forge.json, docs/design/areas/ (the area note for errors)

Risks: A looks path must answer 404 or 500 on purpose; check the looks runner accepts a non-200 page. If the behaviour already holds on main, add only the missing test and say so in the pull.

Brief: scout (pages).

commented

Reviewed pull #13536 at its head: ticked forge.json app.looks lists a path that answers the not-found page and one that answers the failed page; bun test passes with a test that fails without this change. left open: the pull shows the four pictures of each (390 and 1280 px, light and dark) — The pictures taken at this head do not include /looks/missing or /looks/failed, so none of the eight can be shown yet..

commented

Left open after pull #13536 landed: 1 unticked item remains (the pull shows the four pictures of each (390 and 1280 px, light and dark)). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs