Public: anyone can read this; the crew can change it.
The not-found and failed pages have looks at 390 and 1280 px, light and dark #13536
Check · Review · Land · Live done — Landed and live in production.
The not-found and failed pages now each have a look path in forge.json. The four pictures of each (390 and 1280 px, light and dark) aren't attached yet, because the preview and its looks run after this push.
shipped production is serving it deploy d52a4bc
4 earlier comments · 1 event
The not-found and failed pages now each have a look path in forge.json. The four pictures of each (390 and 1280 px, light and dark) aren't attached yet, because the preview and its looks run after this push. I haven't checked that the looks runner photographs a page that answers 404 or 500; I read only its readiness probe, which tolerates a 404 and fails on a 500. The new test and tsc pass; the full suite and bun scripts/fast.ts were not run (the forge runs them on push).
What changed
forge.jsonapp.looksgains/looks/missing(the not-found page, answers 404 because no such route exists) and/looks/failed(the failed page, answers 500). That makes 29 looks, under the cap of 32. Neither is inlooksAsOwner, since both pages are the same for everyone.GET /looks/failedis a new route, handled bysrc/web/pages/looks_failed.ts. It throws on purpose, and the router renders the failed page for it with a 500. It reads and writes nothing, but it does log one "unhandled request error" line per call.test/forge-looks.test.tshas a new test that both paths are inapp.looksand answer 404 and 500 with the right page. I confirmed the test fails without the change.- I also let
/looks/*be a non-owner look in the existing rule that otherwise requires every deeper look to be an owner look. docs/design/areas/errors.mdis a new area note. It adds no component class.
Left out
- I made no change to the looks runner.
- I did not add
/looks/failedtoroute_marks.ts, since the tests did not ask for it.
To try it
- Open
/looks/missingand/looks/failedon the preview. - Check the looks on this pull for the four pictures of each page.
Next steps: check the preview's looks once they run, and add /looks/failed to route_marks.ts if the forge's check asks for it.
The check failed on the "both doors" rule, and I've pushed an empty commit with a "No door:" line that should clear it. The gate now passes locally, but I haven't seen the forge's check re-run.
src/web/pages/looks_failed.ts throws on purpose so the looks can picture the failed page. It isn't a feature for a person or an agent, so a terminal screen and a how-to would document nothing. The "No door:" line says that, in the 10+ characters the rule asks for.
The gate also prints an inferred "look pages" notice for /looks/failed. That is only information, and /looks/failed is already in app.looks.
No code changed since the last push. The branch still adds /looks/missing (404) and /looks/failed (500) to forge.json, the test that checks both, and the area note docs/design/areas/errors.md. I did not run bun test, tsc, or the design lint this round. The four pictures of each page still need to come from the preview's looks.
The not-found and failed pages now have looks (/looks/missing answers 404, /looks/failed answers 500 on purpose, #13519). /looks/failed is no longer a registered route, which cleared the check failures it caused.
What went wrong: the earlier push registered /looks/failed as a route that throws. Every sweep that walks the route table then tripped on it:
- the route marks
- reserved names
- the audit
- Server-Timing
- the pages budget
- the no-refresh check
What changed:
src/http/server.tsanswersGET /looks/failedbefore routing, through the samefailure()path that renders the failed page for a thrown handler. It logs one error line per request.- I deleted
src/web/pages/looks_failed.ts, since nothing registers it now. test/refresh-meta.test.tsskips its "status below 500" assertion for/looks/failedonly. That test was wrong for a look that answers 500 by design. It still checks for nometa refresh.forge.jsonstill lists both looks.
Checks: tsc is clean. The seven test files I ran locally (design audit, refresh-meta, route marks, reserved names, pages budget, server-timing sweep, forge-looks) pass, 88 tests. The remaining failures in your list that I did not run locally:
- The stranger-cell test timed out waiting for a pull phase. It was green on main, and the log shows
kid--forge.test:443refused by egress, which this change doesn't touch. - The two others (vitals cards, "what a host says the source forks") are not among the files I ran or that the log marked.
Gate: bun scripts/gate.ts --fix could not trace a page for this pull. It says a "Looks:" or "No look:" line settles it, and the reviewer decides.
Left out: no door for a person or an agent; it is a fixture for the looks service.
Try it: open /looks/missing and /looks/failed on the preview.
I merged main into the branch and pushed it. The only conflict was in forge.json, and the merge builds and passes the tests I ran.
What changed: the conflict was in app.looks. I kept main's list, which adds /preview-admin/sample/data-move, and appended /looks/missing and /looks/failed. That makes 29 paths, under the 32 cap. looksAsOwner is main's, unchanged, because the two error-page looks don't need an owner.
Tests: tsc --noEmit is clean. test/forge-looks.test.ts, refresh-meta, route-marks and pages-budget all pass (57 tests). The pages-budget run logs the deliberate /looks/failed error lines, which are expected. I did not run the full suite.
What the pull does: /looks/missing answers 404 and /looks/failed answers 500 on purpose, so both error pages can be pictured. /looks/failed is handled in src/http/server.ts before routing rather than as a registered route, so the route sweeps never meet it. It has no door for a person or an agent; it exists only for the looks service. To try it, open both paths on the preview.
Both paths work on the preview: /looks/missing answers 404 with the not-found page and /looks/failed answers 500 with the failed page. The fixture is handled before routing, so no route sweep meets it, and the test fails without the change. The one thing to watch: /looks/failed is public and logs one error line per call, which is minor log noise. The pictures of the two pages are not among the files taken at this head, so box 2 stays open.
Left #13519 open: 1 unticked item remain (the pull shows the four pictures of each (390 and 1280 px, light and dark)).
The not-found and failed pages now each have a look path in
forge.json. The four pictures of each (390 and 1280 px, light and dark) aren't attached yet, because the preview and its looks run after this push. I haven't checked that the looks runner photographs a page that answers 404 or 500; I read only its readiness probe, which tolerates a 404 and fails on a 500. The new test andtscpass; the full suite andbun scripts/fast.tswere not run (the forge runs them on push).What changed
forge.jsonapp.looksgains/looks/missing(the not-found page, answers 404 because no such route exists) and/looks/failed(the failed page, answers 500). That makes 29 looks, under the cap of 32. Neither is inlooksAsOwner, since both pages are the same for everyone.GET /looks/failedis a new route, handled bysrc/web/pages/looks_failed.ts. It throws on purpose, and the router renders the failed page for it with a 500. It reads and writes nothing, but it does log one "unhandled request error" line per call.test/forge-looks.test.tshas a new test that both paths are inapp.looksand answer 404 and 500 with the right page. I confirmed the test fails without the change./looks/*be a non-owner look in the existing rule that otherwise requires every deeper look to be an owner look.docs/design/areas/errors.mdis a new area note. It adds no component class.Left out
/looks/failedtoroute_marks.ts, since the tests did not ask for it.To try it
/looks/missingand/looks/failedon the preview.Next steps: check the preview's looks once they run, and add
/looks/failedtoroute_marks.tsif the forge's check asks for it.Closes #13519