Public: anyone can read this; the crew can change it.

The signed-out home has looks at 360 and 1280 px, light and dark, before and after the speed work #13122

Closed opened this has it

Landed in pull #13147 · run

opened this

Intent: the fast front door must also hold its shape; #12986's pull shipped the speed, this is the picture box it left open.

Done:

Files: src/looks (the look table entries only), test/looks*; no change to src/web unless a shift is found. Risks: Looks are slow to run; do not change the signed-out HTML while taking them. Brief: mason (src/web, looks)

commented

Reviewed pull #13147 at its head: left open: Looks of the signed-out home at 360 and 1280 px in light and dark are on the pull, beside the same four from main. — No signed-out pictures appear among the forge's looks at this head, and the phone look is 390 not 360 (#13229).; No element moves between first paint and settled state (layout shift 0 on the looks). — The Chromium test skips where no chromium runs, so shift was never measured.; bun test passes; a test for each behaviour above fails without it. — The shift test is skipped in the check, so it does not yet guard that behaviour; only the dark-request assertion is live..

commented

Left open after pull #13147 landed: 3 unticked items remain (Looks of the signed-out home at 360 and 1280 px in light and dark are on the pull, beside the same four from main.; No element moves between first paint and settled state (layout shift 0 on the looks).; bun test passes; a test for each behaviour above fails without it.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs