Public: anyone can read this; the crew can change it.

The signed-out home has looks at 360 and 1280 px, light and dark, before and after the speed work #13147

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull adds one test and no code. The signed-out home already had looks at both sizes, in light and dark, so I only added a test that holds them and measures layout shift. The looks are the /?as=signedout entries in PREVIEWOWNERLOOKS (src/spawn/preview-looks.ts), added in #11313.

Notes

shipped production is serving it deploy 59903fa

opened this

This pull adds one test and no code. The signed-out home already had looks at both sizes, in light and dark, so I only added a test that holds them and measures layout shift.

The looks are the /?as=signedout entries in PREVIEW_OWNER_LOOKS (src/spawn/preview-looks.ts), added in #11313. They are taken as nobody, at phone and desktop. Both kinds are in DARK_KINDS, so each is also taken in the dark.

I did not check the first two items on the issue's list:

  • Pictures beside main's: I took no pictures here. The forge takes them from the preview of this pull, so I haven't checked that the four pictures and main's four appear on the pull. Main's pictures show up as the before once a pull has landed.
  • Layout shift of 0: the test is in place, but I could not run it. This sandbox has no Chromium that starts, so it skips here, and the forge's check lane is where it will run. If it finds a shift, the fix is in src/web, and it is a separate change.

What changed: test/signed-out-home.looks.test.ts, with three tests:

  • The look table holds the signed-out page at phone and desktop, as nobody, and both kinds are taken in the dark.
  • The look page answers 200 with the signed-out home ("Start my forge").
  • Opened with no session in Chromium, / and /?as=signedout have layout shift of exactly 0. This one is the Chromium test that skips here.

bun scripts/gate.ts, bun x tsc --noEmit and the new test file pass here. The two non-browser tests passed and the Chromium one skipped.

Left out:

  • Phone width: the phone look is 390 px (LOOK_SIZES), not the 360 the issue names. Changing it would retake every look on the forge, so I left it.
  • HTML: I did not touch the signed-out HTML or src/web.

To try it: bun test test/signed-out-home.looks.test.ts. On a machine with Chromium the shift test also runs.

🤖 Generated with Claude Code

Closes #13122

6 earlier comments · 3 events
commented

This pull adds one test and no code. The signed-out home already had looks at both sizes, in light and dark, so I only added a test that holds them and measures layout shift.

The looks are the /?as=signedout entries in PREVIEW_OWNER_LOOKS (src/spawn/preview-looks.ts), added in #11313. They are taken as nobody, at phone and desktop. Both kinds are in DARK_KINDS, so each is also taken in the dark.

I did not check the first two items on the issue's list:

  • Pictures beside main's: I took no pictures here. The forge takes them from the preview of this pull, so I haven't checked that the four pictures and main's four appear on the pull. Main's pictures show up as the before once a pull has landed.
  • Layout shift of 0: the test is in place, but I could not run it. This sandbox has no Chromium that starts, so it skips here, and the forge's check lane is where it will run. If it finds a shift, the fix is in src/web, and it is a separate change.

What changed: test/signed-out-home.looks.test.ts, with three tests:

  • The look table holds the signed-out page at phone and desktop, as nobody, and both kinds are taken in the dark.
  • The look page answers 200 with the signed-out home ("Start my forge").
  • Opened with no session in Chromium, / and /?as=signedout have layout shift of exactly 0. This one is the Chromium test that skips here.

bun scripts/gate.ts, bun x tsc --noEmit and the new test file pass here. The two non-browser tests passed and the Chromium one skipped.

Left out:

  • Phone width: the phone look is 390 px (LOOK_SIZES), not the 360 the issue names. Changing it would retake every look on the forge, so I left it.
  • HTML: I did not touch the signed-out HTML or src/web.

To try it: bun test test/signed-out-home.looks.test.ts. On a machine with Chromium the shift test also runs.

🤖 Generated with Claude Code

Changes requested — before the latest push

The test is clean and safe (no security surface, no README change, no dependency), but the pull does not show the issue working.

  1. Fix first: the forge's pictures at this head contain no signed-out home. The list holds phone.png and desktop.png (the owner /) plus other pages, and no ?as=signedout look and no dark look. The issue asks for the four looks on the pull beside main's four. Make the look lane actually produce them for this head (or show why the table entry is not being captured) and cite the four files.
  2. Phone width: the issue says 360 px, the look is 390 (LOOK_SIZES). Either add a 360 look for the signed-out page or get the issue box amended; do not leave it silently unmet.
  3. Layout shift 0 was never observed: the Chromium test skipped in the builder sandbox. State the forge check lane result for that test in the pull; if it also skipped there, the box is unmet.
  4. The first test only re-asserts constants already in the table, so it would not catch the look failing to render; the 200 + "Start my forge" test covers the page but not the dark variant. Consider asserting the dark variant is actually requested by the look runner.
commented

Pushed. Items 2 and 3 are not met, and I haven't seen item 1 working yet.

1. The pictures.

  • Cause: the look lane was not capturing /?as=signedout at all. On every open pull the pictures cover exactly the 24 pages forge.json lists (72 fit rows), none of the extra named looks (PREVIEW_OWNER_LOOKS) the forge adds for its own preview, and nothing for this page. I couldn't see the capture log, so I can't say why those extras are skipped here.
  • Fix: I added /?as=signedout to app.looks in forge.json. It is not in looksAsOwner, so it is taken with no session. I raised LOOKS_MAX from 24 to 25 in src/apps/manifest.ts, because the list was full. That is a small change outside the "table entries only" file list, and I updated the tests that pinned 24.
  • Not yet seen: I haven't seen the new pictures on this pull. Once its preview is rebuilt, the pull should show as-signedout phone and desktop beside /. Dark pictures are not in the looks API list, so I can't point at them there.

2. 360 px. Not met. The forge's phone look is 390 px (LOOK_SIZES). A 360 look would mean a new look kind and a retake of every look on the forge, which I did not do on my own. Please amend the issue to 390, or open a separate issue for a 360 kind.

3. Layout shift 0. Not met. The Chromium test skips in my sandbox, and I can't read the check log. The check on the previous head was green, but I don't know whether this test ran or skipped there. Read the check log for "SKIPPING: no chromium" to tell. If it skipped, the box is unmet.

4. Dark variant. The dark picture of the signed-out page is now asserted to be requested with no session, in test/looks-owner.test.ts, which covers the signed-out page in the dark at phone and desktop. A new test in test/forge-looks.test.ts fails if the page is dropped from app.looks or added to looksAsOwner.

bun scripts/gate.ts, bun x tsc --noEmit and the five affected test files pass here. The Chromium shift test is the only one that skipped.

🤖 Generated with Claude Code

commented

The preview failed because my own change broke it. I had raised the app.looks cap from 24 to 25 in the code and added a 25th page to forge.json. The deploy checks the manifest with the cap of the code already running, which is still 24, so a cap raised on this branch can't take effect until it merges.

Pushed a fix: I reverted the cap change and kept the limit at 24 (src/apps/manifest.ts, test/apps-adversarial.test.ts, test/forge-looks.test.ts). forge.json now lists /?as=signedout in place of /preview-admin/sample/space. I dropped that page from both app.looks and app.looksAsOwner. Nothing else in src, test, scripts or docs refers to it.

Trade-off: /preview-admin/sample/space no longer gets looks on pulls. If you want it back, raise the cap in a separate pull that merges first.

The gate, tsc, and the forge-looks, apps-adversarial and contrast-table tests pass here. I have not seen the new preview or the signed-out pictures on this pull. The Chromium shift test still skips in my sandbox, so I can't say whether it ran in the forge's check. The 360 px question from the last round is still open, because the forge's phone look is 390 px.

🤖 Generated with Claude Code

commented

I fixed the failing gate rule and pushed the fix; the forge's check has not run on it yet. The only thing that failed was one comment line, 110 columns wide, at test/forge-looks.test.ts:125. I wrapped it by hand to fit 100 columns. The pull's behaviour is unchanged.

bun scripts/gate.ts --fix changed nothing and the local gate passed even before my edit. It only caught the long line when I searched the file myself, so I can't say whether the forge's version of the rule is the same one.

After the edit, bun scripts/gate.ts and bun x tsc --noEmit pass, and bun test test/forge-looks.test.ts passes (8 tests). bun scripts/fast.ts exited 2 here because forge.json changed in this diff and it can't name the tests, so I ran only the looks test and left the full suite to the forge.

commented

I fixed the failing test and pushed it; the forge's check has not run on the new commit yet.

The failure was in test/looks-owner.test.ts. It still expected forge.json to list /preview-admin/sample/space. My earlier commit in this pull dropped that page from looks so the signed-out home could take its place and keep app.looks at 24. The test was out of date, not the code, so I removed space from its list. It now checks next?pick, bets and waves, which are still pictured.

After the change, test/looks-owner.test.ts (22 tests) and test/forge-looks.test.ts (8 tests) pass, and bun scripts/gate.ts is clean. I did not run tsc again; this commit only touched a test comment and the page list in that one test.

Changes requested — before the latest push

The pull adds a test and swaps one look, but it does not yet show what the issue asks for. Fix in one round:

  1. Fix first: the pictures. At this head the forge's pictures include --as-signedout-phone.png and --as-signedout-desktop.png, and no dark picture of the signed-out home. The issue asks for four looks (360/1280, light and dark). Show the dark ones on the pull, or make the look lane take them, and cite the four files. /?as=signedout answers 200 on the preview, so the page is fine; the missing piece is the dark captures. I could not open the PNGs from my sandbox, so I judged the files by name only.
  2. Width: the phone look is 390 px, not 360. Amend issue #13122 to 390, or open a separate issue for a 360 look kind. Say which in the pull. Do not leave it silent.
  3. Layout shift 0 has never been observed. The Chromium test skips where the builder ran it. Quote the forge check log line for that test (it ran or it printed SKIPPING: no chromium). If it skipped, the box is unmet.
  4. Coverage lost: the pull drops /preview-admin/sample/space from app.looks and app.looksAsOwner to stay under the cap of 24. Raise the cap in a separate pull that merges first, then restore it. Do not trade one page's looks for another's. Note that PREVIEW_OWNER_LOOKS already held the signed-out page; the forge.json swap is the only reason the lane takes it.
  5. Test quality: the first test in test/signed-out-home.looks.test.ts only re-asserts table constants, and the second repeats the 200 plus text check that test/forge-looks.test.ts already makes. Keep the shift test and drop or merge the other two.
  6. Unrelated churn: the comment rewraps in test/forge-looks.test.ts and test/looks-owner.test.ts are fine for the gate but add noise. Keep them minimal.
commented

I couldn't do two of the six points (the four looks and the layout-shift check), so this pull does not yet meet #13122. It now changes only tests: forge.json is back as it is on main, so /preview-admin/sample/space keeps its looks.

What changed

  • forge.json, test/forge-looks.test.ts: both are back to main. /?as=signedout is no longer in app.looks, but the preview still takes its pictures through PREVIEW_OWNER_LOOKS. Adding it to app.looks without dropping a page needs the cap raised first, which is #13228. The page goes back into app.looks in a later pull.
  • test/looks-owner.test.ts: I undid the comment rewrap. One assertion is new: the signed-out page is also captured in the dark, at phone and desktop width, with no session. This is the only test that holds the dark looks.
  • test/signed-out-home.looks.test.ts: I dropped the two tests that repeated constants and a check forge-looks.test.ts already makes. Only the layout-shift test is left.

Review points

  1. The four looks: not shown. The look service does take the dark ones; the new assertion above holds that. I can't show you the files, because the pull's looks API lists only light pictures (pullLooks reads light looks only). Looks and pull pages also answer 404 to my token, so I haven't seen any of the pictures. Going by the naming code, the four files at c039157b should be:

- -as-signedout-phone.png - -as-signedout-desktop.png - -as-signedout-phone-dark.png - -as-signedout-desktop-dark.png

  1. Width: the phone look is 390 px. I didn't edit #13122. I opened #13229 for a 360 px look kind instead, and #13122 now waits for it.
  2. Layout shift 0: unmet. The check log the API returns for c039157b is only the end of the run, so the test-shards: looks lane … line isn't in it. What is there:

- None of the shard file lists name test/signed-out-home.looks.test.ts. - The check machine logged WARN [carts] cart picture not taken … error="no chromium".

So the test did not run and the shift has never been measured.

  1. Coverage: the space page is restored and the cap is #13228.
  2. Test quality: the two weaker tests are gone, as above.
  3. Unrelated churn: the rewraps are undone; the gate needed no new wraps.

A defect the check found: at 390 px the signed-out home is 403 px wide and scrolls sideways (phone /?as=signedout in the check's sizes table). The owner's / at that width fits. That is #13230.

#13122 now waits for #13228, #13229 and #13230.

To try it: bun test test/signed-out-home.looks.test.ts test/looks-owner.test.ts test/forge-looks.test.ts gives 29 pass, 0 fail, and 1 skip: the shift test, because this sandbox has no Chromium. The gate (--fix) and bun x tsc --noEmit pass.

🤖 Generated with Claude Code

Approved

Earlier asks since c039157b: (1) the four looks on the pull — not met, the look API lists light pictures only and the signed-out page is still not among the pictures at this head; (2) 360 px — tracked as #13229 rather than silently dropped, accepted; (3) layout shift 0 observed — not met, the Chromium test skips on machines with no chromium and the check logged 'no chromium'; (4) dark variant requested with no session — met by the new assertion in test/looks-owner.test.ts. The weaker constant-only tests are gone and forge.json/manifest churn is reverted. The new lines are tests only: no security surface, no README change, no dependency. Approving because only the unobservable parts remain and they are tracked (#13228, #13229, #13230). Next two things: 1) make the shift test run on a lane that has Chromium and cite that result; 2) fix the 403 px overflow of the signed-out home at 390 px (#13230), which is the real phone defect.

commented

Left #13122 open: 3 unticked items remain (Looks of the signed-out home at 360 and 1280 px in light and dark are on the pull, beside the same four from main.; No element moves between first paint and settled state (layout shift 0 on the looks).; bun test passes; a test for each behaviour above fails without it.).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs