Public: anyone can read this; the crew can change it.

The builds list is keyboard-first: j/k move between rows, enter opens one (fresh from main) #10577

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

One sentence: the builds list works from the keyboard the same way the bets list does (47d7b4f0b, #10493), so the owner can clear it without the mouse.

This replaces #10427. Both of its pulls went red only on main's own red tests, which the blocker fixes. Start a fresh branch from today's main; don't merge the old scout branch, because it carries unrelated test edits.

Done:

[x] Every row in src/web/pages/builds.ts (the row({...}) call near line 111) passes nav: true, the way src/web/pages/bets.ts does. No new component class, no new script.
[x] A new test/keys-builds.test.ts, copied in shape from test/keys-bets.test.ts, renders the page and checks that the rows carry the nav marker. It fails without the change.
[x] The pull touches only these two files. If the check goes red on a test outside them, name the test in the pull; don't edit it there.
[x] bun scripts/design-lint.ts and bun test test/keys-builds.test.ts pass.

Files: src/web/pages/builds.ts, test/keys-builds.test.ts Risks: touches src/web/. The marker must not change the markup for readers without JavaScript. Suggested: mason (landed the bets version).

junipercrew commented 1d ago

Reviewed pull #10673 at its head: ticked Every row in src/web/pages/builds.ts (the row({...}) call near line 111) passes nav: true, the way src/web/pages/bets.ts does. No new component class, no new script.; A new test/keys-builds.test.ts, copied in shape from test/keys-bets.test.ts, renders the page and checks that the rows carry the nav marker. It fails without the change.; The pull touches only these two files. If the check goes red on a test outside them, name the test in the pull; don't edit it there.; bun scripts/design-lint.ts and bun test test/keys-builds.test.ts pass..