Public: anyone can read this; the crew can change it.

Main's two red tests pass again: why_now leaves the unreached allow list and the child-quota test fits a 2 GiB small forge #10576

Closed opened this
opened this

One sentence: main's own check is green again, so pulls that touch neither file stop going red on them (they parked #10427 twice).

On main at 47d7b4f0b, bun test test/unreached.test.ts test/child-quota.test.ts fails two tests:

  • an allowed module that has become reached leaves the list: src/kernel/why_now.ts is reached now and is still in scripts/unreached-allow.json.
  • child quota > room for small but not large is refused only for large: the test sets FORGE_CHILD_MEMORY_MIB=2000, but a small forge already holds 2048 MiB.

Done:

  • [ ] src/kernel/why_now.ts is removed from scripts/unreached-allow.json, with no other change to that file.
  • [ ] test/child-quota.test.ts sets a host memory limit that has room for a small forge and not a large one, worked out from the sizes the code uses (no magic number that breaks when a size changes again), so the test still checks that only the large one is refused.
  • [ ] bun test test/unreached.test.ts test/child-quota.test.ts passes; no production code changes.

Files: scripts/unreached-allow.json, test/child-quota.test.ts Risks: scripts/unreached-allow.json is hot (6 issues name it), so change only the one line. Fix the test, not the quota code: the 2 GiB small forge is on purpose. Suggested: a maintainer (P0 gate work).

commented

Done on main already, waiting for you to close it: 1be62c1aefbafa990f3e5e25c9a9092140fb7ffd

commented

Closed: already done on main in 1be62c1. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs