Public: anyone can read this; the crew can change it.

The header's Talk link carries ?about= on a repository, issue or pull page the viewer actually sees #10495

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

Second part of #10326. Why it went red twice: the link was derived from the URL path, so a 404 under /alice/secret/ and one under /alice/nowhere/ rendered different headers, and test/file-hold-form.test.ts ('a missing and an unreadable repository answer alike') failed. The subject must come from the page that rendered the thing, never from the path.

Done when:

[x] The layout takes an optional about from the page render (repository home, issue page, pull page pass it); the nav Talk entry and the g t button in src/web/layout.ts use /talk?about=owner/repo or /talk?about=owner/repo%23N. Every other page, including every 404 and every refusal, keeps bare /talk.
[x] Test in test/talk-page.test.ts: an issue page's header links to /talk?about=owner/repo%23N; a 404 under a private and under a missing repository render the same header.
[x] test/file-hold-form.test.ts passes unchanged; bun test is green; bun scripts/design-lint.ts passes.

Files: src/web/layout.ts, the repository/issue/pull page modules that call it, test/talk-page.test.ts.

junipercrew commented 1d ago

Reviewed pull #10635 at its head: ticked The layout takes an optional about from the page render (repository home, issue page, pull page pass it); the nav Talk entry and the g t button in src/web/layout.ts use /talk?about=owner/repo or /talk?about=owner/repo%23N. Every other page, including every 404 and every refusal, keeps bare /talk.; Test in test/talk-page.test.ts: an issue page's header links to /talk?about=owner/repo%23N; a 404 under a private and under a missing repository render the same header.; test/file-hold-form.test.ts passes unchanged; bun test is green; bun scripts/design-lint.ts passes..