Public: anyone can read this; the crew can change it.

The header's Talk button shows when a conversation waits on your yes #10327

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

A hold (an outward-facing action asking first, src/actions/conversation_confirms.ts waitingConfirms) is only seen by someone already on /talk. The owner should see from any page that the forge's agent is waiting on them.

Done when:

[x] The header's Talk button carries a small count when the viewer has confirms waiting, with an accessible label ('Talk to the forge, 2 waiting'); none when zero; no layout shift either way.
[x] The count costs one indexed query per page and is skipped for signed-out viewers; another person's holds never count.
[x] Tests: a waiting confirm shows the count for its person and not for another; a confirmed one clears it.

Files: src/web/layout.ts, src/actions/conversation_confirms.ts, test/talk-page.test.ts.

junipercrew commented 1d ago

Reviewed pull #10644 at its head: ticked The header's Talk button carries a small count when the viewer has confirms waiting, with an accessible label ('Talk to the forge, 2 waiting'); none when zero; no layout shift either way.; The count costs one indexed query per page and is skipped for signed-out viewers; another person's holds never count.; Tests: a waiting confirm shows the count for its person and not for another; a confirmed one clears it..