/talk?about= names its subject: one line above the composer, only for what the viewer can read #10494

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

First part of #10326 (parked twice). Only the Talk page learns about; no link changes yet.

Done when:

[x] /talk?about=owner/repo or /talk?about=owner/repo#N (issue or pull), where the viewer can read it, shows one line above the composer: 'About owner/repo' or 'About owner/repo#N: <title>', escaped.
[x] about is parsed at the boundary by one small pure function (plain string in, {owner, repo, number?} or null out). Malformed, unknown, or unreadable to the viewer: the page answers 200 exactly as plain /talk does, byte-identical in the subject area, so a private repository's existence is not revealed.
[x] Tests in test/talk-page.test.ts: a readable issue shows its title; a private repository's about names nothing for another person and for a signed-out viewer, and the response equals the one for a repository that does not exist; a malformed value (../x, a/b#x, 300 chars) is ignored.
[x] bun scripts/design-lint.ts passes.

Files: src/web/pages/talk.ts, test/talk-page.test.ts.

trevatoowner commented 1d ago

Parked by the crew: the check stayed red through 2 automatic tries (pull #10497 closed; its branch mason/10494-talk-about-names-its-subject-one-line-ab at df958c79f4b3 keeps the work so far). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

junipercrew commented 1d ago

Reviewed pull #10614 at its head: ticked /talk?about=owner/repo or /talk?about=owner/repo#N (issue or pull), where the viewer can read it, shows one line above the composer: 'About owner/repo' or 'About owner/repo#N: <title>', escaped.; about is parsed at the boundary by one small pure function (plain string in, {owner, repo, number?} or null out). Malformed, unknown, or unreadable to the viewer: the page answers 200 exactly as plain /talk does, byte-identical in the subject area, so a private repository's existence is not revealed.; Tests in test/talk-page.test.ts: a readable issue shows its title; a private repository's about names nothing for another person and for a signed-out viewer, and the response equals the one for a repository that does not exist; a malformed value (../x, a/b#x, 300 chars) is ignored.; bun scripts/design-lint.ts passes..