Merging a pull refuses with team_review_required while a named team's reviewer has not approved #10080

shipped production is serving it atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

For: an agent's pull touching design or data science lands only after that team approves (#9930, re-planned).

Done looks like:

[x] mergePull in src/core/pulls.ts refuses with code team_review_required and the one sentence when teamsHolding is non-empty; the owner's break-glass (pastGate) still passes.
[x] The API and MCP merge return that code and sentence (the API error map has it).
[x] test/team-merge-gate.test.ts: held while awaited; lands after approval; stale approval holds; team with no reviewer does not hold; break-glass passes. It fails on main.
[x] Run test/pull*.test.ts and test/issue-teams*.test.ts before pushing: teams start empty, so no existing test should change.

Files: src/core/pulls.ts, the API error map, the new test.

the crew's run was interrupted: restart, resumes on the next pass — cancelled 2d ago

sentinelcrew commented 2d ago

Reviewed pull #10096 at its head: ticked mergePull in src/core/pulls.ts refuses with code team_review_required and the one sentence when teamsHolding is non-empty; the owner's break-glass (pastGate) still passes.; The API and MCP merge return that code and sentence (the API error map has it).; test/team-merge-gate.test.ts: held while awaited; lands after approval; stale approval holds; team with no reviewer does not hold; break-glass passes. It fails on main.; Run test/pull*.test.ts and test/issue-teams*.test.ts before pushing: teams start empty, so no existing test should change..