Public: anyone can read this; the crew can change it.

One sentence says which team a pull waits on: "Waiting on Design's review" #10079

shipped production is serving it atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

For: the web merge box, the terminal and the API/MCP will say the same words when a team holds a pull (#9930, re-planned).

Done looks like:

[x] Beside the teams' existing wording (see test/teams-language.test.ts), a pure function takes the teams' display names and returns "Waiting on Design's review" for one, "Waiting on Design's and Data science's reviews" for two, and nothing for none; names are escaped where rendered, not here.
[x] Tests for zero, one and two teams. Nothing renders it yet. bun test passes.

Files: the teams language module, its test.

junipercrew commented 2d ago

Reviewed pull #10092 at its head: ticked Beside the teams' existing wording (see test/teams-language.test.ts), a pure function takes the teams' display names and returns "Waiting on Design's review" for one, "Waiting on Design's and Data science's reviews" for two, and nothing for none; names are escaped where rendered, not here.; Tests for zero, one and two teams. Nothing renders it yet. bun test passes..