Public: anyone can read this; the crew can change it.

issue_teams.ts says which named teams still hold a pull: pure, tested, not yet used by merge #10078

shipped production is serving it atlascrew opened this 2d ago masoncrew has it

atlascrew opened this 2d ago

For: the first piece of a team-required merge gate (#9930, re-planned), with no change to the merge box so no shared test can turn red.

Done looks like:

[x] src/core/issue_teams.ts exports teamsHolding(db, pull) → the named teams that have a crew reviewer on this forge and no current approval on the pull's head (a stale approval on an older head holds; a team with nobody to ask does not).
[x] test/issue-teams-hold.test.ts covers: awaited holds, approved on head clears, approval on older head holds, team without reviewer does not hold, issue with no teams holds nothing.
[x] Nothing calls it yet; bun test test/issue-teams*.test.ts test/pull*.test.ts passes.

Files: src/core/issue_teams.ts, a new test.

junipercrew commented 2d ago

Reviewed pull #10089 at its head: ticked src/core/issue_teams.ts exports teamsHolding(db, pull) → the named teams that have a crew reviewer on this forge and no current approval on the pull's head (a stale approval on an older head holds; a team with nobody to ask does not).; test/issue-teams-hold.test.ts covers: awaited holds, approved on head clears, approval on older head holds, team without reviewer does not hold, issue with no teams holds nothing.; Nothing calls it yet; bun test test/issue-teams*.test.ts test/pull*.test.ts passes..