Public: anyone can read this; the crew can change it.

Right after approving from the desk, the desk's confirmation offers "Undo send" for the minute it lasts #93

Closed opened this has it

Landed in pull #101 · 2 runs · run

opened this

For: the remaining box of #74. Undo send shipped on the lead's page, the API, the MCP and the terminal; the desk's confirmation after approving still says only that the message went, so an agent who approves from the desk has to open the lead to take it back.

Done looks like:

Files likely: src/routes.ts (the desk notice after approving), src/pages/desk.ts, src/undo.test.ts. Risk: the notice travels by cookie/redirect today as plain text — carry the lead id, not HTML, and escape on render. Suggested builder: mason.

4 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: the premise doesn't match the code, so there is no desk confirmation to extend.

commented

Note from Mason: the desk (/) has no approve control, and the lead page already shows Undo send after approving (including the next-lead flow). The only confirmation without Undo was /due ("Send the ticked ones"), so pull #101 puts the button there. Boxes 1 and 3 are met for /due, not for the desk as written; a person may want to reshape them.

commented

Reviewed pull #101 at its head: ticked The button is shown only while undoable says the minute lasts and only to who permit lets update the lead; after the minute, or for a held text that already went, the confirmation reads as today with no button.; Pressing it lands back on the desk with the message a draft again and a notice saying so; the lead reads as it did before the send (a first reply undone leaves the lead new with its clock running).; No new route and no contract change; the confirmation stays server-rendered, no layout shift.; Tests: the desk confirmation contains Undo send within the minute and not after it, and not for a user who may not update; bun scripts/design-lint.ts is clean.. left open: After approving from the desk (including the "next lead" flow), the desk's confirmation names the lead and carries an "Undo send" button that posts to the existing /leads/:id/undo (same-origin checked, as today), with the same "For a minute after sending." hint as the lead page. — The desk has no approve control; the button is on the Due follow-ups confirmation instead, and the lead page already offers it..

commented

Left open after pull #101 landed: 1 unticked item remains (After approving from the desk (including the "next lead" flow), the desk's confirmation names the lead and carries an "Undo send" button that posts to the existing /leads/:id/undo (same-origin checked, as today), with the same "For a minute after sending." hint as the lead page.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The open box is no longer wanted: the desk has no Approve button of its own. Approving happens on a lead's page, which already offers "Undo send" (src/pages/lead.ts:58) beside the next-lead link (src/routes.ts:738-740), and on the due-today batch page, where #101 (32f9d3f) added "Undo send" with the same hint (src/pages/due.ts:31). Every place a message is approved can take it back for the minute. Closing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs