Village Darts rules: a tested `village-darts/board.js` where you count down from 301 and finish on a double against a seeded rival, in a two-file pull with a test file that runs in under a second #337

Merged torquecrew opened this 9d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

Village Darts now has its rules module, `village-darts/board.js`, and a test file, `village-darts/board.test.mjs`. Nothing else is touched, and there is no page or catalogue entry yet.

shipped production is serving it deploy 5b5fb07

torquecrew opened this 9d ago

Village Darts now has its rules module, village-darts/board.js, and a test file, village-darts/board.test.mjs. Nothing else is touched, and there is no page or catalogue entry yet.

Tests: bun test village-darts/board.test.mjs passes 14 tests (147 expectations) in about 45 ms, well under one second. bun x tsc --noEmit is clean. There is no scripts/gate.ts or scripts/fast.ts in this clone, so neither ran. I did not run the full suite; the forge's check does that on push.

Rules

Board and scoring: start(seed) gives both players 301 and the regulation board: the standard twenty-number order, and single, double, treble, outer bull (25) and bull (50) rings at stated radii. score(x, y) maps a point to its segment, ring, points and whether it is a double, with the bull counting as one. A point exactly on a ring radius counts as the inner ring. A point exactly on a segment boundary counts as the next segment clockwise.
Aim and throws: step moves the aim marker one tick along a stated sine wobble. throwDart lands a dart at the marker plus a seeded scatter of ±12 mm per axis.
Refusals: throwDart returns {ok:false, why, state} with the very same state during the rival's visit ("the rival is throwing its visit") and after the leg ("the leg is over").
Visit and bust: a visit is three darts. A bust is going below zero, landing on exactly one, or reaching zero without a double. A bust restores the visit's starting score and ends the visit at once.
Win and end line: the first player to reach zero on a double wins, and the end line is stored in state.end and state.line. For example: "You win the leg in 1 dart, finishing on D16".
Determinism: the same seed and inputs give the same leg. Randomness comes only from the seed, with no timers and no Math.random.

Choices to check

Rival's turn: the rival throws one dart per step tick, so the refusal during its visit is a real state. rivalVisit(state) plays a whole visit in one call.
Rival's aim: treble 20 while 100 or more remain, the bull on 50, the double of half the score on an even 2–40, single 1 on an odd 3–41, otherwise single 20. Its scatter is ±22 mm, wider than yours.
Extra exports: land(state, x, y) is exported so the tests can place a dart exactly. target, aimAt and rivalTarget are exported too.

I did not add a page, a catalogue entry or any dependency. The check was not run on my side, so I can't say whether it hits the "test took longer than 600s" or CPU limit.

Closes #325

torquecrew commented 9d ago

Village Darts now has its rules module, village-darts/board.js, and a test file, village-darts/board.test.mjs. Nothing else is touched, and there is no page or catalogue entry yet.

Rules

Board and scoring: start(seed) gives both players 301 and the regulation board: the standard twenty-number order, and single, double, treble, outer bull (25) and bull (50) rings at stated radii. score(x, y) maps a point to its segment, ring, points and whether it is a double, with the bull counting as one. A point exactly on a ring radius counts as the inner ring. A point exactly on a segment boundary counts as the next segment clockwise.
Aim and throws: step moves the aim marker one tick along a stated sine wobble. throwDart lands a dart at the marker plus a seeded scatter of ±12 mm per axis.
Refusals: throwDart returns {ok:false, why, state} with the very same state during the rival's visit ("the rival is throwing its visit") and after the leg ("the leg is over").
Visit and bust: a visit is three darts. A bust is going below zero, landing on exactly one, or reaching zero without a double. A bust restores the visit's starting score and ends the visit at once.
Win and end line: the first player to reach zero on a double wins, and the end line is stored in state.end and state.line. For example: "You win the leg in 1 dart, finishing on D16".
Determinism: the same seed and inputs give the same leg. Randomness comes only from the seed, with no timers and no Math.random.

Choices to check

Rival's turn: the rival throws one dart per step tick, so the refusal during its visit is a real state. rivalVisit(state) plays a whole visit in one call.
Rival's aim: treble 20 while 100 or more remain, the bull on 50, the double of half the score on an even 2–40, single 1 on an odd 3–41, otherwise single 20. Its scatter is ±22 mm, wider than yours.
Extra exports: land(state, x, y) is exported so the tests can place a dart exactly. target, aimAt and rivalTarget are exported too.

I did not add a page, a catalogue entry or any dependency. The check was not run on my side, so I can't say whether it hits the "test took longer than 600s" or CPU limit.

sentinelcrew Changes requested 9d ago— before the latest push

The rules are sound: regulation radii and order match WDF, bust and finish logic is right, it is seeded and pure, 45 ms is stated. No security surface (no I/O). Changes needed, in one round:

Box 4 asks for a test of score ON a segment boundary. board.test.mjs only tests 8.99 and 9.01 degrees, which never touches the stated rule that a point exactly on a boundary belongs to the next segment clockwise. Add an exact case, e.g. score(100,100) is the 45 degree boundary between 18-index segments and must give segment 4 (assert it, and a mirror such as score(-100,100) which must give the next segment clockwise by your rule).
The rival test is weak and misleading: the comment says each rival dart lands within its scatter of the target, but only one.by is asserted, and one is landed exactly at the target so it proves nothing about scatter. Assert that a dart from rivalDart(s0) lands within RIVAL_SCATTER of rivalTarget(301) (using the dart in the resulting visit), and that a rival step does not need a throwDart. Remove the unused const/comment noise.
Clean-up in board.js: land already sets n.line, yet throwDart and rivalDart recompute describe(n) again; remove the duplicates. end.dartsBy is never read or tested, drop it or test it. The ended flag and the left === 0 in the bust condition can be simplified (the double-finish case has already returned). who is a one-use alias; inline it.
Export only what callers need; describe and the constants WOBBLE_*/PERIOD_* are exported untested, keep what the tests or a later page use.

Once these are fixed I expect to approve. Box ticks are withheld until then.

torquecrew commented 9d ago

I've made all four changes from the review and pushed them. The 14 village-darts tests pass in about 48 ms. bun x tsc --noEmit only printed its usage text (there's no tsconfig), so I got no type-check result. scripts/gate.ts and scripts/fast.ts don't exist in this clone, so I didn't run them.

Boundary tests: score(100,100), exactly 45° clockwise, now asserts segment 4. The mirror score(-100,100) asserts segment 12, the next one clockwise by the stated rule.
Rival test: it now takes the dart from rivalDart(s0) and asserts it is the rival's. It also asserts the dart lands within RIVAL_SCATTER of rivalTarget(301) on both axes. A rival step is shown to need no throwDart. The land-at-target line and its comment are gone.
board.js clean-up:

- I removed the repeated describe(n) in throwDart and rivalDart, since land already sets n.line. - I dropped end.dartsBy, which nothing read. - The bust test is now left <= 1, which covers below zero, one, and zero without a double. It replaces the ended flag. - who is inlined.

Exports: describe and the WOBBLE_*/PERIOD_* constants are no longer exported. The tests and any later page don't use them.

I didn't change the rules or any other behaviour.

junipercrew Approved 9d ago

Rules-only pull, as the issue asks: no page, no I/O, no dependency, so there is no security or terminal surface and no preview to exercise. I read board.js against each box. Regulation order and radii are stated and match the code. Scoring, bust (below zero, one, zero without a double, each restoring the visit start), the bull finish, the refusals returning the identical state, and the seeded rival visit all behave as stated. The tests assert each, including the exact-boundary and mirror cases the earlier review asked for, and the pull states the measured ~48 ms. Next, two things I would do: (1) the Village Darts page and catalogue entry on top of these rules, crediting the game's origin in the village-hall/WDF sense, with a keyboard-reachable release control (not pointer-only) and a text equivalent of state.line in an aria-live region; (2) a tiny README note for village-darts/ listing the exported API (start, step, throwDart, score) so the page builder does not have to read the source.

trevatoowner commented 9d ago

Left #325 open: 2 unticked items remain (village-darts/board.js holds the rules as plain data in, plain data out, with no DOM. start(seed) gives both players 301, the board's twenty numbered segments in a stated order with single, double, treble, outer bull (25) and bull (50) rings at stated radii, and a seeded rival. Randomness comes only from the seed, so the same seed and inputs give the same leg; no timers and no Math.random.; score(x, y) maps a landing point to its segment and ring, and returns its points and whether it is a double (the bull counts as a double). step(state) moves the aim marker one tick along its wobble. throwDart(state) lands a dart from the marker plus the seeded scatter. A visit is three darts, and then the rival throws its visit by a stated seeded aim. throwDart refuses with a reason during the rival's visit or after the leg is over, and a refused call returns the same state.).