Public: anyone can read this; the crew can change it.

Migrated from github.com/amirmushichge/pixel-plays

Add Conkers: the playable page and its place in the catalogue, on the rules in `conkers/match.js` #283

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Conkers is now a playable page, built on conkers/match.js and listed in the catalogue. The new page tests, the playtests for conkers, and the serve, shell, town and plaza tests pass. I did not run a bare bun test.

Notes

shipped production is serving it deploy ab54f53

opened this

Conkers is now a playable page, built on conkers/match.js and listed in the catalogue. The new page tests, the playtests for conkers, and the serve, shell, town and plaza tests pass. I did not run a bare bun test. bun x tsc --noEmit only prints its help here because the repo has no tsconfig, and there is no scripts/gate.ts to run. I also haven't opened the page in a browser, only the generated social card, which shows the scene correctly.

The page

  • conkers/index.html draws a playground under a horse-chestnut tree, with your conker and the rival's hanging side by side on their strings.
  • Yours has a double knot and a chalk cross, and the rival's has a single knot and no mark, so they differ by more than colour. Cracks accumulate on each conker as hit points drop.
  • The power meter sweeps up and down. A notch (ticks plus a pointer) marks the sweet spot and a hatched red end marks the tangle zone.
  • Tap the canvas, or press Space or Enter, to swing. Every swing and the rival's reply go through M.swing and M.opponentTurn; the page adds no rule of its own.
  • It plays a short swing animation, shows the rival's reading as a red pointer, and takes taps only when no swing is playing.
  • The HUD shows bout, rival name, both hit points and score, and the status line is P.line.
  • The Visual rules are followed: 360×280 canvas, hard shadows screen-right, and the conkers' sway and the tree's leaf sway stop under reduced motion.
  • The meter and swings keep moving under reduced motion, because they are play, not ambient.
  • The aria-label says how to play and the rules popup is four lines. There is a #mute button and no .mp3.

The catalogue

  • GAMES in shell.js has the entry exactly as specified, and the root index.html has the matching <li>.
  • Buildings in the town come from GAMES, so nothing was needed in town.js.
  • The README has a Games table row, and Conkers is added to the no-music list and the ambient-motion note.
  • bun scripts/og.mjs was run, giving og/conkers.png and a refreshed og/home.png.

Tests

  • rounds.mjs has a scripted round that swings when the meter is in the sweet spot and reaches "All 3 rivals cracked, you win" in about 10 seconds at seed 1.
  • serve.test.mjs asserts /conkers/ and /conkers/match.js answer 200.
  • conkers/page.test.mjs adds 10 tests, covering a sweet-spot swing and HUD, tangle, input lock, Space, meter range, the notch, the knot and chalk differences, a full win and restart, mute, and the page source.

Not done

  • The HUD hit points update the moment a swing is accepted, a fraction of a second before the animation lands.
  • There is no keyboard restart other than Space or Enter after the match ends.

The branch was already level with main, so no rebase was needed. Pushed with a plain git push.

Closes #258

commented

Conkers is now a playable page, built on conkers/match.js and listed in the catalogue. The new page tests, the playtests for conkers, and the serve, shell, town and plaza tests pass. I did not run a bare bun test. bun x tsc --noEmit only prints its help here because the repo has no tsconfig, and there is no scripts/gate.ts to run. I also haven't opened the page in a browser, only the generated social card, which shows the scene correctly.

The page

  • conkers/index.html draws a playground under a horse-chestnut tree, with your conker and the rival's hanging side by side on their strings.
  • Yours has a double knot and a chalk cross, and the rival's has a single knot and no mark, so they differ by more than colour. Cracks accumulate on each conker as hit points drop.
  • The power meter sweeps up and down. A notch (ticks plus a pointer) marks the sweet spot and a hatched red end marks the tangle zone.
  • Tap the canvas, or press Space or Enter, to swing. Every swing and the rival's reply go through M.swing and M.opponentTurn; the page adds no rule of its own.
  • It plays a short swing animation, shows the rival's reading as a red pointer, and takes taps only when no swing is playing.
  • The HUD shows bout, rival name, both hit points and score, and the status line is P.line.
  • The Visual rules are followed: 360×280 canvas, hard shadows screen-right, and the conkers' sway and the tree's leaf sway stop under reduced motion.
  • The meter and swings keep moving under reduced motion, because they are play, not ambient.
  • The aria-label says how to play and the rules popup is four lines. There is a #mute button and no .mp3.

The catalogue

  • GAMES in shell.js has the entry exactly as specified, and the root index.html has the matching <li>.
  • Buildings in the town come from GAMES, so nothing was needed in town.js.
  • The README has a Games table row, and Conkers is added to the no-music list and the ambient-motion note.
  • bun scripts/og.mjs was run, giving og/conkers.png and a refreshed og/home.png.

Tests

  • rounds.mjs has a scripted round that swings when the meter is in the sweet spot and reaches "All 3 rivals cracked, you win" in about 10 seconds at seed 1.
  • serve.test.mjs asserts /conkers/ and /conkers/match.js answer 200.
  • conkers/page.test.mjs adds 10 tests, covering a sweet-spot swing and HUD, tangle, input lock, Space, meter range, the notch, the knot and chalk differences, a full win and restart, mute, and the page source.

Not done

  • The HUD hit points update the moment a swing is accepted, a fraction of a second before the animation lands.
  • There is no keyboard restart other than Space or Enter after the match ends.

The branch was already level with main, so no rebase was needed. Pushed with a plain git push.

Approved

Conkers works in the preview: /conkers/ and /conkers/match.js answer 200. The page drives the game only through M.swing and M.opponentTurn, has the notched sweet spot and hatched tangle end, a Space/Enter/tap door, a 44px mute button, and the catalogue, README, og cards and rounds entry are all there. Two things I would do next: (1) hold the HUD hit points and score until the swing animation lands, so the numbers do not run ahead of the crack; (2) replace the source-string assertions in page.test.mjs (e.g. drawConker.toString() containing 'mine ? .3 : .17', 'if (!STILL) theta') with a pixel or state check, since they pass on renamed-but-broken code and break on harmless refactors.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs