Public: anyone can read this; the crew can change it.

Migrated from github.com/amirmushichge/pixel-plays

Add Carousel: the playable page and its place in the catalogue, on the rules in `carousel/ride.js` #231

Parked opened this
Closed without merging

I merged main into the Carousel branch and pushed it. The branch should now merge cleanly. serve.test.mjs passes (74 tests, 0 failures).

Notes

stopped parked by the crew deploy b0a05ca

opened this

I merged main into the Carousel branch and pushed it. The branch should now merge cleanly. serve.test.mjs passes (74 tests, 0 failures). I did not run the rest of the suite; the forge runs the full check on the push.

  • README.md: I took main's text and added Carousel back in both places. It is in the list of games that play on their own sound effects, now "Bird Watch, Bunting and Carousel". The ambient-motion line keeps Bird Watch's oak leaves and Carousel's canopy lights.
  • og/home.png: I took main's version and regenerated all the cards with bun scripts/og.mjs. The home card now includes both Bird Watch and Carousel.
  • Second merge: the forge had already pushed its own "Merge main into the Carousel branch" to the branch, so my first push was rejected. I merged that commit in without conflicts, and the regenerated cards matched what was committed, so nothing else changed.
  • Not run: this clone has no scripts/gate.ts or scripts/fast.ts, so I ran neither. bun x tsc --noEmit printed only its usage text, with no type errors reported.

Continues #231

3 earlier comments · 1 event
commented

Carousel now has its playable page at carousel/index.html and its place in the catalogue, on the rules in carousel/ride.js. The branch is merged with current main, which has moved on with Bird Watch.

The pull was parked because the check stayed red twice. I didn't find a fault in the Carousel code. I think the checks failed on the suite's runtime: playtest.test.mjs boots every game, and that alone exceeded the deploy's 600s limit. The branch already carries two earlier commits that address this. They shard the suite and run two shards at a time, under the forge's 2-core cap. I haven't seen the forge's log for those runs, so I can't confirm that was the cause.

  • Conflicts: README.md conflicted with Bird Watch's entries, so the music-less and ambient-motion lists now name both games. I regenerated og/home.png with bun scripts/og.mjs so the home card shows both.
  • Merge, not rebase: a rebase needs a force-push, which the forge refuses.
  • Tests: the serve and shell suites pass, as do the Carousel and Bird Watch playtests (95 and 10 tests). I did not run the full sharded suite here; the forge runs it on this push.
  • tsc: bun x tsc --noEmit prints only its usage text, because the repo has no tsconfig, so there was no real type check. There is no scripts/gate.ts in this repo.

I chose not to touch the test sharding any further. If the check is still red, the log will show whether a shard is still too slow or something else is failing.

To try it, open /carousel/ from the home grid. The card is the "Carousel" entry, and its share card is og/carousel.png.

🤖 Generated with Claude Code

commented

I merged main into the Carousel branch and pushed it. The branch should now merge cleanly. serve.test.mjs passes (74 tests, 0 failures). I did not run the rest of the suite; the forge runs the full check on the push.

  • README.md: I took main's text and added Carousel back in both places. It is in the list of games that play on their own sound effects, now "Bird Watch, Bunting and Carousel". The ambient-motion line keeps Bird Watch's oak leaves and Carousel's canopy lights.
  • og/home.png: I took main's version and regenerated all the cards with bun scripts/og.mjs. The home card now includes both Bird Watch and Carousel.
  • Second merge: the forge had already pushed its own "Merge main into the Carousel branch" to the branch, so my first push was rejected. I merged that commit in without conflicts, and the regenerated cards matched what was committed, so nothing else changed.
  • Not run: this clone has no scripts/gate.ts or scripts/fast.ts, so I ran neither. bun x tsc --noEmit printed only its usage text, with no type errors reported.
the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

This pull adds Carousel, its playable page and its place in the catalogue. This push also changes how the test runner uses cores.

The deploy failure: the log didn't show an error. The app booted and answered at /. I took the likely cause to be the test run overrunning the forge's 2-core cap, because one bun process alone uses about 1.6 cores and two ran side by side. I haven't confirmed that against the forge.

The change: scripts/test.mjs now pins each of its two workers to its own core with taskset. If taskset is missing or fewer than two cores are visible, it runs unpinned as before.

Checks:

  • Tests: bun scripts/test.mjs passes locally with 0 failures in every shard, in about 4 minutes.
  • Preview: the preview answers 200 at / and at /carousel/.
  • Not run: I didn't run bun x tsc --noEmit this turn, and the repo has no scripts/gate.ts.

I chose not to change the test count or split the shards further. The forge's check on this push will show whether the failure is gone.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs