Public: anyone can read this; the crew can change it.

Migrated from github.com/amirmushichge/pixel-plays

Add Mill Race: the playable page and its place in the catalogue, on the rules in `mill-race/race.js` #213

Parked opened this
Closed without merging

I merged main into the Mill Race branch and pushed it (a9797a9..79a44de). The merge was straightforward because the text conflicts had already resolved cleanly. README.md and rounds.mjs: both sides are kept.

Notes

stopped parked by the crew deploy 6edbeb1

opened this

I merged main into the Mill Race branch and pushed it (a9797a9..79a44de). The merge was straightforward because the text conflicts had already resolved cleanly.

  • README.md and rounds.mjs: both sides are kept. The Mill Race entries stay, and the Curling Rink row, its place in the "music: false" list, its ambient-motion note and its rounds.mjs entry now sit beside them.
  • og/home.png: this binary conflicted, so I regenerated it with bun scripts/og.mjs. It now has a card for every game, curling included.
  • Tests: serve.test.mjs, shell.test.mjs and the curling and mill-race tests pass (112 tests, 0 failures). I did not run the full suite; the forge's check does that on this push.
  • Type check: bun x tsc --noEmit printed only its help text (no tsconfig in the repo), so I could not check types here.

Continues #213

Show 3 earlier items

7 earlier comments
commented

This pull adds Mill Race, the playable page at mill-race/index.html, and puts it in the catalogue (index.html, shell.js, README.md). It also adds mill-race/race.test.mjs, og/mill-race.png, a scripted round for it in rounds.mjs, and a case in serve.test.mjs. The rules were already on main in mill-race/race.js.

The failed preview deploy showed no failing test. Its log ended in the middle of the bell-tower playtests, with every test before that line passing. I think the run was cut off or timed out, because the playtest suite now boots about 70 games, but I couldn't confirm that from the log.

  • Mill Race playtests: all five pass here. They cover booting, idling, pointer play, keyboard play and a scripted round.
  • Other suites: I ran serve, shell, plaza, town, ramp and the mill-race tests, 113 passing and none failing. I did not run the full playtest suite, since the forge does that on push.
  • Not run: the clone has no scripts/gate.ts or scripts/fast.ts, so I ran neither. I also didn't run the type check or design lint.
  • Code changes: none. The branch already contained current main, so the only new commit is an empty one to start the forge's check and preview deploy again.

To try it, open /mill-race/ on the preview at https://pixel-plays--213--forge-trevato-apps.open-platform.sh, or reach it from the catalogue on /. If the new deploy dies at the same place, the suite is too slow for the deploy timeout. That needs a person to fix, not a change to this pull.

commented

I merged main into the Mill Race branch, resolved the four conflicts so both Mill Race and Bunting stay, and pushed it.

  • index.html and shell.js: both the Mill Race and Bunting entries are in.
  • README.md: I started from main's wording and added Mill Race back to the list of games that use their own sound effects. I also added its ambient-motion clause: water shimmer, and the wheel turning once the stream reaches it.
  • og/home.png: I regenerated it with bun scripts/og.mjs, so it shows both games' cards. No other share cards changed.

The serve and shell tests and the Mill Race tests pass, 92 in all. The playtests for mill-race and bunting also pass. I did not run the rest of the playtest suite, since the forge runs it on push. bun x tsc --noEmit only printed the compiler's help text, because the repository has no tsconfig, so there was no type check to run.

commented

Mill Race is already on the pull branch; this run only re-checked it and merged the branch up to the current remote head (6edbeb1), which already contained the latest main. Nothing new was pushed, so no new commit triggers a fresh forge check.

  • Page: mill-race/index.html draws the channel tiles, the water in the cells flow reports, and the wheel. It runs only through mill-race/race.js. Tap a tile to turn it, or use the arrow keys and Space.
  • Catalogue: the entry is in GAMES in shell.js as specified, with its <li> in the root index.html, its README Games row and its place in the no-music list. bun scripts/og.mjs produced og/mill-race.png; re-running it after this merge left no diff.
  • Tests:

- rounds.mjs has a scripted round for mill-race that reaches the end line. - serve.test.mjs asserts /mill-race/ and /mill-race/race.js answer 200.

  • Test runs: mill-race, playtest.test.mjs, serve.test.mjs and shell.test.mjs passed together (378 tests) before the merge. serve.test.mjs and shell.test.mjs passed again after it (85 tests); I did not re-run the playtest after it.
  • Not run: scripts/gate.ts and scripts/design-lint.ts don't exist in this clone. bun x tsc --noEmit printed only its help text, so I can't call it passing. The forge's check will run the whole suite.
  • Try it: bun test mill-race, or open /mill-race/ on the preview.
commented

Branch is up to date with main and in sync with the remote; nothing new to push.

Issue #175 (Mill Race) is complete on quill/175-add-mill-race-the-playable-page-and-its at 6edbeb1. main hasn't moved since that merge (still 95e8cf7, the Bunting commit). The issue's only comment is the earlier "parked" note about pull #207, which isn't new. I made no changes this run and ran no tests.

  • Page and rules: mill-race/index.html runs only through mill-race/race.js.
  • Catalogue: the entry is in GAMES in shell.js, with its <li> in the root index.html, its README rows and the no-music list. og/mill-race.png is in the branch.
  • Tests: rounds.mjs has a scripted round that reaches the end line. serve.test.mjs asserts /mill-race/ and /mill-race/race.js answer 200.
  • Last local runs: the mill-race, playtest, serve and shell tests passed (378 tests) before the final merge. After it, serve.test.mjs and shell.test.mjs passed (85 tests) and bun scripts/og.mjs left nothing to commit.
  • Not run: scripts/gate.ts and scripts/design-lint.ts don't exist in this clone. bun x tsc --noEmit printed only its help text, so I can't call it passing.
  • Try it: bun test mill-race, or open /mill-race/ on the preview.
commented

Nothing has moved since my last run. I made no changes and ran no tests, so I pushed nothing.

quill/175-add-mill-race-the-playable-page-and-its (6edbeb1) already contains the current main (95e8cf7) and matches the remote. The issue's only comment is still the earlier "parked" note about pull #207.

The page, catalogue entries, scripted round, serve assertions and share card are all on the branch. The last local test runs (before and after the final merge with main) were green. scripts/gate.ts and scripts/design-lint.ts don't exist in this clone, and bun x tsc --noEmit printed only its help text, so I can't call the type check passing.

commented

Nothing has changed since my last run, so I changed nothing, ran no tests and pushed nothing.

quill/175-add-mill-race-the-playable-page-and-its is at 6edbeb1, level with the remote and already containing the current main (95e8cf7). The issue still has only the earlier "parked" comment about pull #207.

The Mill Race work is all on the branch: the playable page, the catalogue entries, the scripted round, the serve assertions and the share card. Its last local test runs were green. scripts/gate.ts and scripts/design-lint.ts don't exist in this clone, and bun x tsc --noEmit printed only its help text, so I can't call the type check passing.

commented

Nothing has changed since my last run, so I changed nothing, ran no tests and pushed nothing.

quill/175-add-mill-race-the-playable-page-and-its is level with its remote at 6edbeb1. It already contains the current main (95e8cf7, the Bunting merge). The issue still has only the earlier "parked" comment about pull #207.

The Mill Race work is all on the branch: the playable page, the catalogue entries, the scripted round, the serve assertions and the share card. The last local test runs were green. scripts/gate.ts and scripts/design-lint.ts don't exist in this clone, and bun x tsc --noEmit printed only its help text, so I can't call the type check passing.

The branch has been waiting on the forge's check and a person's decision since the earlier red runs. If the check goes red again, its log is what I need to work from.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs