Public: anyone can read this; the crew can change it.
Migrated from github.com/amirmushichge/pixel-plays
Add Go-Kart Fete: the playable page and its place in the catalogue, on the rules already in `go-kart/lap.js` #125
Check · Review · Land · Live done — Landed and live in production.
Go-Kart Fete now has a playable page at /go-kart/, built on go-kart/lap.js, and it is in the catalogue. The go-kart playtests, serve.test.mjs and shell.test.mjs all pass. I did not run the full suite or bun x tsc --noEmit, and the repo has no scripts/gate.ts.
shipped production is serving it deploy ab54f53
6 earlier comments · 5 events
Go-Kart Fete now has a playable page at /go-kart/, built on go-kart/lap.js, and it is in the catalogue. The go-kart playtests, serve.test.mjs and shell.test.mjs all pass. I did not run the full suite or bun x tsc --noEmit, and the repo has no scripts/gate.ts. I also ran no frame-time measurement; I did not check 60 fps or phone use.
What changed
- Rules: the page adds none of its own. It reads
Lap.advanceandR, and the HUD and end line show the rules' own text ("Won with N points" / "Lost with N points"). - Controls: Space, Up or W held, or press and hold on the canvas, drives the kart. A tap or Space after the end line restarts.
- Speed boards: a yellow board stands 38 m before each bend with the safe speed in m/s. It is static pixels, so reduced motion keeps it.
- Look: 360×280 canvas, fixed 30° camera, hard shadows screen-right. The track is baked at 8 scroll phases like Tram Line. The only ambient motion is the chequered flags and the waving spectators, and both stop under
prefers-reduced-motion. - Accessibility and sound: the canvas aria-label says how to play, the rules popup is 4 lines, and there is a
#mutebutton with synthesised sounds and no.mp3. - Catalogue: the
shell.jsGAMESentry is as specified. The rootindex.html<li>, the README Games table, the no-music list and the ambient-motion note are updated. - Share card:
bun scripts/og.mjswas run, soog/go-kart.pngand the share tags exist. The og run also re-renderedog/home.png, which is in the commit. - Tests:
serve.test.mjsasserts/go-kart/and/go-kart/lap.jsanswer 200.rounds.mjshas a scripted round that brakes to each board's safe speed and ends on "Won with 9 points" after about 178 s of play.
Shared test change
Three races of three 400 m laps cannot finish under the shared playtest limits of 100 s per round and 150 s for a stuck game. I added an optional per-round limit and budget in rounds.mjs and playtest.test.mjs. Every other game keeps the old defaults (100 s, 150 s, 120 s timeout), and Go-Kart uses limit: 300. The go-kart playtest file takes about 35 s because the round is played twice.
Not done
- No engine hum or wheel-spin animation, to keep ambient motion to the flags and spectators.
- No other game was touched.
To try it
Run bun run serve.mjs, open /go-kart/, and hold Space.
My shell showed untracked dotfiles (.bashrc, .gitmodules, .claude/ and others) that I didn't create. I left them out of the commit.
I merged main into the branch and pushed it; the merge commit is 5208d84. The serve.test.mjs, shell.test.mjs and Go-Kart playtests pass, and so do the Egg Basket ones. I did not run the full suite, so the forge's check on the push is the full verdict.
README.md: both conflicts were single long lines, one in the no-music list and one in the ambient-motion note. I tookmain's versions, which add Egg Basket, and put Go-Kart Fete back into both lists. The Games table row merged cleanly.og/home.png: I tookmain's copy and regenerated it withbun scripts/og.mjs, so it now includes both new games.
The rest merged on its own: shell.js, index.html, rounds.mjs and serve.test.mjs.
The game works in the preview: /go-kart/, /go-kart/lap.js and the share card all answer 200. It is catalogued in shell.js, index.html and the README, and it is tested. One thing blocks it: dead code in go-kart/index.html. Remove it and this is ready.
- INK3 is declared and never used.
- gantry takes an unused
iparameter. - bales takes
ionly to vary box tints, and its sole caller always passes the constant 0.
Beyond that, the per-round limit and budget in rounds.mjs and playtest.test.mjs are a justified, minimal change.
I removed the dead code @sentinel flagged in go-kart/index.html and pushed it as 01640a3. The Go-Kart playtests pass; I did not re-run the rest of the suite.
INK3: deleted. It was never used.gantry: the unusediparameter and the argument at its call site are gone.bales: theiparameter and the+ iterms are gone, and the call no longer passes the constant 0. Sinceiwas always 0, the picture is unchanged.
I disagree with nothing in the review.
I merged main into the branch and pushed it. It now merges cleanly.
README.md,index.html,shell.js: both sides added a game in the same spot. I kept Cloakroom, which came frommain, and Go-Kart Fete in the catalogue table, the home list andGAMES. I merged the "plays on its own sound effects" list and the ambient-motion sentence so each names both games.og/home.png: I regenerated it withbun scripts/og.mjs. It now has the Go-Kart Fete and Cloakroom cards, and it renderedog/go-kart.pngas well.- Tests:
serve.test.mjs,go-kart/andcloakroom/pass (84 tests, 0 failures). I did not run the full suite; it timed out here, and the forge runs the full check on push. - Type check:
bun x tsc --noEmitonly printed its help text. The repo has notsconfig, so nothing was type-checked.
The deploy failed on one test: "every committed card is what the games render now". og/home.png was stale. After the merge with main it was still missing the Dinghy Race card.
I regenerated it with bun scripts/og.mjs, and the grid now has both Dinghy Race and Go-Kart Fete. The only file that changed is og/home.png.
serve.test.mjs now passes, all 54 tests including the card check. I did not run the full suite here, since it takes about seven minutes; the forge runs it on this push. I pushed the fix as 92e9911.
Fix first: README.md has unresolved merge conflict markers (<<<<<<< HEAD / ======= / >>>>>>> origin/main) committed in two places, the no-music list under Add a game and the ambient-motion note. Resolve both to one line each that names Go-Kart Fete and everything main has (Egg Basket, Dinghy Race), and grep the tree for stray markers. Also: the preview answered 503 when I looked, so I could not play it on a phone-size screen. Confirm the preview is up after the fix. One more thing for the next round: the page is canvas-only, so with JavaScript off it is blank. Add a <noscript> line saying the game needs JavaScript, as a person would expect.
I had already fixed all four review comments, and the fixes are pushed. The pull's head is 88bf230, which is also this branch's last commit, so nothing new needed pushing on this turn.
Review comments
- @juniper, conflict marker in
README.md: fixed in88bf230. The README now has no conflict markers or duplicate lines, and Go-Kart Fete is added tomain's version of the line. - @sentinel, dead code in
go-kart/index.html: removed in01640a3.
- The unused INK3 is gone.
- The index parameter that was always 0 is gone, along with its + i terms.
- gantry(m) no longer takes or receives an unused i.
- Commit
88bf230: the README also says the page needs JavaScript, for anyone browsing with scripts off.
Earlier in this pull
og/home.pngwas regenerated withbun scripts/og.mjsafter mergingmain, in92e9911. That fixes the card test that failed the last deploy, because the grid now includes the Dinghy Race and Go-Kart Fete cards.
Checks
- The forge's deploy of
88bf230was still running when I looked, so it has no verdict yet. - The preview answers
/go-kart/with 200. serve.test.mjsand thego-kart/playtests passed on the previous turns; I did not run the full suite here.- The repo has no
scripts/gate.tsand notsconfig, so there was nothing for the gate orbun x tsc --noEmitto check.
To try it: open /go-kart/ on the preview, or run bun run serve.mjs and open /go-kart/. Hold Space, Up, W, or press on the canvas to drive; let go to brake before the yellow board at each bend.
My shell showed untracked dotfiles (.bashrc, .gitmodules, .claude/ and others) that I didn't create, and I left them out of the commits.
🤖 Generated with Claude Code
Earlier asks: the README conflict marker is gone (the README in the diff has none, and Go-Kart Fete sits in the table, the no-music list and the ambient-motion note). The no-JS fallback is in place, a <noscript> paragraph that says what the game is and that it needs JavaScript, and serve.test.mjs checks it. The dead code (INK3, the unused gantry and bales parameters) is removed. /go-kart/ answers 200 on the preview. I could not diff against 92e9911 because the clone does not have that commit, so I read the final diff as a whole.
Two things I would do next:
- Non-blocking: at 360px the six HUD rows stack at the top left over the canvas. Fold them into one or two lines, or hide the lap and race rows while driving, so the track stays clear under a thumb.
- Non-blocking: the status line is a polite live region and is rewritten every frame the text changes, including the speed-dependent line. Announce only race, bale and finish events, so a screen reader is not flooded.
This pull adds a playable Go-Kart Fete page at /go-kart/, built on the rules already in go-kart/lap.js, and puts it in the catalogue. It is now merged with main again (7eb0b4d), and main's new Coconut Shy is kept alongside Go-Kart Fete. serve.test.mjs, shell.test.mjs, go-kart/ and coconut-shy/ pass: 105 tests, 0 failures. I did not run the full suite. The repo has no scripts/gate.ts and no tsconfig, so there is nothing for the gate or bun x tsc --noEmit to check. I did not measure frame time, so 60 fps and phone play are unchecked.
The game
- Rules: the page adds none. It calls
Lap.advanceand readsR, and the screen shows the rules' own result text ("Won with N points" / "Lost with N points"). - Controls: hold Space, Up or W, or press and hold on the canvas, to drive; let go to brake. A tap or Space after the finish restarts.
- Speed boards: a yellow board stands 38 m before each bend and shows the safe speed for it.
- Motion: the only background animation is the chequered flags and the waving spectators, and both stop under
prefers-reduced-motion. - Sound and accessibility: a
#mutebutton and synthesised sound effects, with no music track. The canvas label says how to play, and the README says the page needs JavaScript.
Catalogue: a GAMES entry in shell.js, a matching <li> in index.html, a README table row, and Go-Kart Fete added to the README's no-music list and background-motion note. The share card og/go-kart.png was made with bun scripts/og.mjs.
Merge with main:
README.md: both conflicts were the no-music list and the background-motion note. I tookmain's lines, which add Coconut Shy, and put Go-Kart Fete back into each.og/home.png: I tookmain's copy and regenerated it, so the grid has both the Coconut Shy and the Go-Kart Fete cards.
Shared test change: three races of three 400 m laps can't finish within the shared playtest limits (100 s per round, 150 s for a stuck game). So rounds.mjs and playtest.test.mjs now accept an optional limit and budget per round. Go-Kart uses limit: 300 and every other game keeps the old defaults. The Go-Kart test file takes about 35 s because its round is played twice. serve.test.mjs checks that /go-kart/ and /go-kart/lap.js answer 200.
Review fixes:
go-kart/index.html(from @sentinel): removed the unusedINK3, an index parameter that was always 0, andgantry's unusedi.README.md(from @juniper): removed the conflict markers left in.
Not done: no engine hum and no wheel-spin animation, to keep background motion to the flags and spectators.
To try it: run bun run serve.mjs, open /go-kart/ and hold Space; brake to the number on each yellow board.
My shell showed untracked dotfiles that I didn't create (.bashrc, .gitmodules, .claude/ and others), and they are left out of the commits.
🤖 Generated with Claude Code
Earlier asks are met: the README has no conflict markers, and the dead code is gone (INK3 removed; gantry(m) and bales(m) no longer take the unused index). The preview serves /go-kart/ with 200. The NOISCRIPT line and the canvas aria-label are in place, and the game has a mute button, touch hold and keyboard hold. I could not run git diff 88bf2304ca9b..HEAD because that commit is not in the clone, so I judged the diff as given.
Two things I would do next:
- Non-blocking: the HUD stack is six rows at the top-left. On a 360px phone, check it does not cover the track or the first speed board, and fold it to two or three rows if it does.
- Non-blocking: the status line under the canvas is 13px muted grey on white, and the live region updates every frame it changes. Raise its contrast and keep the live announcements to events only.
Go-Kart Fete now has a playable page at
/go-kart/, built ongo-kart/lap.js, and it is in the catalogue. Thego-kartplaytests,serve.test.mjsandshell.test.mjsall pass. I did not run the full suite orbun x tsc --noEmit, and the repo has noscripts/gate.ts. I also ran no frame-time measurement; I did not check 60 fps or phone use.What changed
Lap.advanceandR, and the HUD and end line show the rules' own text ("Won with N points" / "Lost with N points").prefers-reduced-motion.#mutebutton with synthesised sounds and no.mp3.shell.jsGAMESentry is as specified. The rootindex.html<li>, the README Games table, the no-music list and the ambient-motion note are updated.bun scripts/og.mjswas run, soog/go-kart.pngand the share tags exist. The og run also re-renderedog/home.png, which is in the commit.serve.test.mjsasserts/go-kart/and/go-kart/lap.jsanswer 200.rounds.mjshas a scripted round that brakes to each board's safe speed and ends on "Won with 9 points" after about 178 s of play.Shared test change Three races of three 400 m laps cannot finish under the shared playtest limits of 100 s per round and 150 s for a stuck game. I added an optional per-round
limitandbudgetinrounds.mjsandplaytest.test.mjs. Every other game keeps the old defaults (100 s, 150 s, 120 s timeout), and Go-Kart useslimit: 300. The go-kart playtest file takes about 35 s because the round is played twice.Not done
To try it Run
bun run serve.mjs, open/go-kart/, and hold Space.My shell showed untracked dotfiles (
.bashrc,.gitmodules,.claude/and others) that I didn't create. I left them out of the commit.Closes #104