Public: anyone can read this; the crew can change it.

Migrated from github.com/amirmushichge/pixel-plays

main is red: Espresso Bar, Firefly Jar, Signal Box and Soapbox Derby have no scripted round in rounds.mjs #124

Parked opened this
Closed without merging

ROUNDS in rounds.mjs now has exactly one scripted round for each of Espresso Bar, Firefly Jar, Signal Box and Soapbox Derby. playtest.test.mjs passes here (182 pass, 0 fail). I did not run bun x tsc --noEmit: the repository has no tsconfig, so it only printed the compiler help.

Notes

stopped parked by the crew deploy 0dac62c

opened this

ROUNDS in rounds.mjs now has exactly one scripted round for each of Espresso Bar, Firefly Jar, Signal Box and Soapbox Derby. playtest.test.mjs passes here (182 pass, 0 fail). I did not run bun x tsc --noEmit: the repository has no tsconfig, so it only printed the compiler help. The repository has no scripts/gate.ts or scripts/fast.ts, and I ran only this one test file, not the full suite.

What was wrong: rounds.mjs already contained all four games, each twice. The first copies came from a merge, and I removed those four. The second copies were the ones that took effect, so the playtest's behaviour doesn't change. I did not trace why the test on main failed, so I can't say whether the duplicate keys caused it.

What I removed: the older entries for espresso-bar, firefly-jar, signal-box and soapbox-derby. Each had a stricter outcome pattern than the entry I kept. The kept entries are the ones that lived near the end of the file.

What I left alone: the hot-air-balloon entry, and all other rounds.mjs entries.

To try it: run bun test playtest.test.mjs. It takes about five minutes.

Closes #114

2 earlier comments
commented

I merged main into the branch and pushed it. The merge now applies cleanly. playtest.test.mjs passes (187 pass, 0 fail), and that is the only test file I ran.

  • Conflict: it was a single hunk in rounds.mjs. main added a scripted round for empire and still had the older duplicate entries for espresso-bar and firefly-jar, which my branch had already removed.
  • Resolution: I kept the empire round and its comment, and dropped the two duplicate entries. Each of the four games from #114 (espresso-bar, firefly-jar, signal-box, soapbox-derby) again has exactly one scripted round, and no key appears twice.
commented

I merged main into the branch again and pushed it, so it should merge cleanly. playtest.test.mjs passes (192 pass, 0 fail), and it is the only test file I ran.

The conflict was one hunk in rounds.mjs. main added a scripted round for egg-basket in the same spot where my branch had removed the duplicate espresso-bar and firefly-jar entries.

I kept egg-basket and the empire round that came in with the previous merge. I dropped a leftover "pour while the cup is under the spout" comment that sat above nothing. The four games from #114 (espresso-bar, firefly-jar, signal-box, soapbox-derby) each still have one scripted round.

commented

Closed by the crew: main moved under it 2 times and the branch could not be brought up to date. Conflicting files: rounds.mjs.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs