Public: anyone can read this; the crew can change it.
Migrated from github.com/amirmushichge/pixel-plays
main is red: Espresso Bar, Firefly Jar, Signal Box and Soapbox Derby have no scripted round in rounds.mjs #124
ROUNDS in rounds.mjs now has exactly one scripted round for each of Espresso Bar, Firefly Jar, Signal Box and Soapbox Derby. playtest.test.mjs passes here (182 pass, 0 fail). I did not run bun x tsc --noEmit: the repository has no tsconfig, so it only printed the compiler help.
stopped parked by the crew deploy 0dac62c
2 earlier comments
I merged main into the branch and pushed it. The merge now applies cleanly. playtest.test.mjs passes (187 pass, 0 fail), and that is the only test file I ran.
- Conflict: it was a single hunk in
rounds.mjs.mainadded a scripted round forempireand still had the older duplicate entries forespresso-barandfirefly-jar, which my branch had already removed. - Resolution: I kept the
empireround and its comment, and dropped the two duplicate entries. Each of the four games from #114 (espresso-bar,firefly-jar,signal-box,soapbox-derby) again has exactly one scripted round, and no key appears twice.
I merged main into the branch again and pushed it, so it should merge cleanly. playtest.test.mjs passes (192 pass, 0 fail), and it is the only test file I ran.
The conflict was one hunk in rounds.mjs. main added a scripted round for egg-basket in the same spot where my branch had removed the duplicate espresso-bar and firefly-jar entries.
I kept egg-basket and the empire round that came in with the previous merge. I dropped a leftover "pour while the cup is under the spout" comment that sat above nothing. The four games from #114 (espresso-bar, firefly-jar, signal-box, soapbox-derby) each still have one scripted round.
Closed by the crew: main moved under it 2 times and the branch could not be brought up to date. Conflicting files: rounds.mjs.
ROUNDSinrounds.mjsnow has exactly one scripted round for each of Espresso Bar, Firefly Jar, Signal Box and Soapbox Derby.playtest.test.mjspasses here (182 pass, 0 fail). I did not runbun x tsc --noEmit: the repository has no tsconfig, so it only printed the compiler help. The repository has noscripts/gate.tsorscripts/fast.ts, and I ran only this one test file, not the full suite.What was wrong:
rounds.mjsalready contained all four games, each twice. The first copies came from a merge, and I removed those four. The second copies were the ones that took effect, so the playtest's behaviour doesn't change. I did not trace why the test on main failed, so I can't say whether the duplicate keys caused it.What I removed: the older entries for
espresso-bar,firefly-jar,signal-boxandsoapbox-derby. Each had a stricteroutcomepattern than the entry I kept. The kept entries are the ones that lived near the end of the file.What I left alone: the
hot-air-balloonentry, and all otherrounds.mjsentries.To try it: run
bun test playtest.test.mjs. It takes about five minutes.Closes #114