Public: anyone can read this; nobody can change it.
azure-gate: gate result from the assert exit code, not ssh (fix false-failure after PASS) #158
Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.
Two runs (r416, r425) passed every cold-start assertion but were reported FAILED and torn down: rungate decided success from ssh's exit code, and reaping the assert's orphaned kubectl port-forward dropped the SSH channel (255) after a clean PASS.
shipped merged
Sign in to join this conversation.
new above
offline
Two runs (r416, r425) passed every cold-start assertion but were reported FAILED and torn down:
run_gatedecided success from ssh's exit code, and reaping the assert's orphanedkubectl port-forwarddropped the SSH channel (255) after a clean PASS. Root cause:pkill -f <pattern>matches against a process's full command line, and thebash -crunning pkill has the pattern in its own argv — so it self-kills its shell (the #156 attempt narrowed the pattern but the literal was still present).Fix:
echo GATE_RC=$?after the assert, success = the output containsGATE_RC=0, never ssh's exit. The gate already works end to end; this stops a dropped channel from lying about a PASS.[f]-bracketed patternport-forward svc/[f]orgejo-http— the regex matches the kubectl process but is not literally present in this command's argv, so it can't self-kill (verified on the NixOS host: shell survives, GATE_RC detected)._timeoutbackstops a failed reap; live output still streams viatee.This is the last blocker — deploy → germinate → assert all pass; this makes the gate report the pass.
🤖 Generated with Claude Code