Public: anyone can read this; the crew can change it.

The README meeting walkthrough covers the week view, showings, the seller update and link previews, and its test walks them #99

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The README walkthrough now has four more steps (16–19). `src/walkthrough.test.ts` walks each one against a booted app, and it passes. I did not run the full suite. This repo has no `scripts/gate.ts` and no `tsconfig.json`, so neither `gate.ts` nor `tsc --noEmit` could run.

shipped production is serving it deploy 957b843

opened this

The README walkthrough now has four more steps (16–19). src/walkthrough.test.ts walks each one against a booted app, and it passes. I did not run the full suite. This repo has no scripts/gate.ts and no tsconfig.json, so neither gate.ts nor tsc --noEmit could run.

New steps in "Try it in five minutes"

  • 16. See the coming week. The This week link on the first screen leads to /week, with Still needs approval and Add to calendar. Step 16 names 412 Alder Lane as the sample that shows an open house.
  • 17. Write down a showing. On your own listing: Showings, the four interest levels, Log showing, Remove, and the "1 showing" pill on the home list.
  • 18. Approve the seller update. The Seller update tab shows "Draft — not approved" until Approve is pressed.
  • 19. Paste the property page link. The Copy button gives the link, and the step says what a phone preview shows. 412 Alder Lane is approved, so its link works for anyone.

New test: it fails if a named label, page or element is missing. The checks:

  • /week lists 412 Alder Lane and a draft row.
  • Logging a showing adds its feedback to the listing page and the pill to the home list.
  • The showing does not appear on the public property page.
  • The seller update goes from draft to approved with a Withdraw button.
  • The sample's /homes/:id page carries the og:title, og:image and twitter:card tags.

Decisions:

  • Showings on your own listing. The sample listings belong to the sample agent, and only a listing's author or an admin can see its showings. So a signed-in realtor sees none on the samples, and step 17 uses their own listing. The step says so, and the test asserts the sample shows no Showings section.
  • No change to src/sample.ts. None of the four steps needed new sample data.
  • No contract cell changed.
  • README numbering left alone. It already has two step 14s; I appended 16–19 after 15 and did not renumber.
  • No jargon or developer commands in the new steps. I mention /week once, as step 16 does for the page.

Closes #97

commented

The README walkthrough now has four more steps (16–19). src/walkthrough.test.ts walks each one against a booted app, and it passes. I did not run the full suite. This repo has no scripts/gate.ts and no tsconfig.json, so neither gate.ts nor tsc --noEmit could run.

New steps in "Try it in five minutes"

  • 16. See the coming week. The This week link on the first screen leads to /week, with Still needs approval and Add to calendar. Step 16 names 412 Alder Lane as the sample that shows an open house.
  • 17. Write down a showing. On your own listing: Showings, the four interest levels, Log showing, Remove, and the "1 showing" pill on the home list.
  • 18. Approve the seller update. The Seller update tab shows "Draft — not approved" until Approve is pressed.
  • 19. Paste the property page link. The Copy button gives the link, and the step says what a phone preview shows. 412 Alder Lane is approved, so its link works for anyone.

New test: it fails if a named label, page or element is missing. The checks:

  • /week lists 412 Alder Lane and a draft row.
  • Logging a showing adds its feedback to the listing page and the pill to the home list.
  • The showing does not appear on the public property page.
  • The seller update goes from draft to approved with a Withdraw button.
  • The sample's /homes/:id page carries the og:title, og:image and twitter:card tags.

Decisions:

  • Showings on your own listing. The sample listings belong to the sample agent, and only a listing's author or an admin can see its showings. So a signed-in realtor sees none on the samples, and step 17 uses their own listing. The step says so, and the test asserts the sample shows no Showings section.
  • No change to src/sample.ts. None of the four steps needed new sample data.
  • No contract cell changed.
  • README numbering left alone. It already has two step 14s; I appended 16–19 after 15 and did not renumber.
  • No jargon or developer commands in the new steps. I mention /week once, as step 16 does for the page.
Approved

README only plus one test; no code, no contract cell, no dependency. Steps 16-19 are in plain words with no developer commands, and the test walks each against a booted app (week page, showing logged and kept off the public page, seller update draft to approved, og/twitter tags on the sample page). Nits, not blocking: the step 18 line is not wrapped like the rest. Showings are author-only, so step 17 cannot use a sample, and it says so.

commented

Left #97 open: 1 unticked item remain (Each step names a sample listing that already shows it (add sample data in src/sample.ts only if a step has nothing to show).).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs