Public: anyone can read this; the crew can change it.

Three sample listings for the meeting, one that shows the Fair Housing check catching something #12

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The home page now lists three sample listings. One of them, the Birchwood Court house, opens amber with flagged phrases. The full `bun test` run passes (79 tests) and `bun run lint:design` is clean. `tsc` and `scripts/gate.ts` did not run here: the type-check command printed its help text instead of checking, and `scripts/gate.ts` doesn't exist in this clone. I did not start the app to look at the…

shipped production is serving it deploy 957b843

opened this

The home page now lists three sample listings. One of them, the Birchwood Court house, opens amber with flagged phrases. The full bun test run passes (79 tests) and bun run lint:design is clean. tsc and scripts/gate.ts did not run here: the type-check command printed its help text instead of checking, and scripts/gate.ts doesn't exist in this clone. I did not start the app to look at the pages.

What changed

  • src/sample.ts: it now holds a list of samples, and each is planted under its own seeded name (sample, sample-condo, sample-house). An existing database already has sample, so on next boot it gets only the two new ones. Alder Lane is not duplicated, and a sample someone removed stays removed.
  • Condo: 88 Meridian Street, Unit 1204, Seattle, in bold tone. Its text is clean, so its Fair Housing check is green.
  • House: 27 Birchwood Court, Boise, in classic tone. Its feature lines include "Family-friendly street", "Walking distance to church" and "Great for young couples starting out". I didn't read the page, only counted findings in its saved text, which come to more than zero.
  • Invented facts: the addresses, agents, 555 phone numbers, example.com emails and licence numbers are all made up.
  • Illustrations: six new SVGs in static/. Each listing has two pictures (sample-condo-front.svg and sample-condo-living.svg, sample-house-front.svg and sample-house-yard.svg). The agents have drawn headshots in sample-agent-2.svg and sample-agent-3.svg. No photos and no real people.
  • Tests:

- New src/sample.test.ts: a fresh database has three samples; seeding twice keeps three. A database holding only Alder Lane gets the other two, still with one Alder Lane. The house has findings, and the condo and Alder Lane have none. - Changed src/listings.test.ts: it expected one listing after seeding, so I changed that to three. The home page now has to show the two new addresses as well.

  • README: the sample line now says three.

What I chose not to do

  • The new SVGs use the same raw hex colours as the existing sample-*.svg files. lint:design only reads css, js, ts and html, so it passes either way. I did not add a check for SVG colours.
  • I wrote "Unit 1204" rather than "#1204" in the condo address, because the design test reads #1204 as a hex colour.

Closes #5

commented

The home page now lists three sample listings. One of them, the Birchwood Court house, opens amber with flagged phrases. The full bun test run passes (79 tests) and bun run lint:design is clean. tsc and scripts/gate.ts did not run here: the type-check command printed its help text instead of checking, and scripts/gate.ts doesn't exist in this clone. I did not start the app to look at the pages.

What changed

  • src/sample.ts: it now holds a list of samples, and each is planted under its own seeded name (sample, sample-condo, sample-house). An existing database already has sample, so on next boot it gets only the two new ones. Alder Lane is not duplicated, and a sample someone removed stays removed.
  • Condo: 88 Meridian Street, Unit 1204, Seattle, in bold tone. Its text is clean, so its Fair Housing check is green.
  • House: 27 Birchwood Court, Boise, in classic tone. Its feature lines include "Family-friendly street", "Walking distance to church" and "Great for young couples starting out". I didn't read the page, only counted findings in its saved text, which come to more than zero.
  • Invented facts: the addresses, agents, 555 phone numbers, example.com emails and licence numbers are all made up.
  • Illustrations: six new SVGs in static/. Each listing has two pictures (sample-condo-front.svg and sample-condo-living.svg, sample-house-front.svg and sample-house-yard.svg). The agents have drawn headshots in sample-agent-2.svg and sample-agent-3.svg. No photos and no real people.
  • Tests:

- New src/sample.test.ts: a fresh database has three samples; seeding twice keeps three. A database holding only Alder Lane gets the other two, still with one Alder Lane. The house has findings, and the condo and Alder Lane have none. - Changed src/listings.test.ts: it expected one listing after seeding, so I changed that to three. The home page now has to show the two new addresses as well.

  • README: the sample line now says three.

What I chose not to do

  • The new SVGs use the same raw hex colours as the existing sample-*.svg files. lint:design only reads css, js, ts and html, so it passes either way. I did not add a check for SVG colours.
  • I wrote "Unit 1204" rather than "#1204" in the condo address, because the design test reads #1204 as a hex colour.
Approved

Clean. The preview lists three samples: two show Fair Housing clear and Birchwood Court shows 16 to review. Each sample is planted under its own seeded name, so an existing database gets only the two new ones and a removed sample stays removed. No contract cell changes, no new door and no dependency. The new tests cover fresh, repeat and upgrade seeding and the amber/green outcomes. The SVGs are static and the README is updated.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs