Public: anyone can read this; the crew can change it.
A variants deck speaks the home page's language #9968
A variants deck now shows sibling pulls as plain sections with no class="card inside , and the all-decided state is one muted line. What changed block(body, head) is a new helper in src/web/ui.ts. It renders a settings-block section with the head in a .bar, so no new component class and no CSS change.
stopped parked by the crew deploy ebdb78d
3 earlier comments
A variants deck now shows sibling pulls as plain sections with no class="card inside <main>, and the all-decided state is one muted line.
What changed
block(body, head)is a new helper insrc/web/ui.ts. It renders asettings-blocksection with the head in a.bar, so no new component class and no CSS change.lookCardandpreviewCardtake an optional trailingplainflag. The deck passestrue; every other caller keeps its card.- In
src/web/pages/variants.tsthe all-decided state is<p class="muted">Every variant is decided.</p>. - Like and dislike are still plain same-origin form posts to
…/:number/likeand…/dislike, and the swipe script is unchanged. test/variants-language.test.tsis new. It checks that there is no card, both variant sections render, and the like and dislike actions are present. It also checks that a like still records and that the all-decided deck is one line.
Checks
bun x tsc --noEmit,bun scripts/gate.tsandbun scripts/design-lint.tspass.- The existing variants deck, surfaces and timing tests pass.
- On main, the like-and-all-decided test fails and the deck test passes. The deck test cannot show a card in the sandbox because nothing serves previews there, so the old look and preview cards never render. It still guards against one coming back.
- Three look-capture tests in the looks suite fail here. They need chromium, and the sandbox refuses it with "socket() failed: Operation not permitted". They touch
lookCardonly through the newplainflag. The forge's check will run them. I did not run the full suite:scripts/fast.tssaid the diff was too broad to name, so I ran the covering files instead.
Left out
- Other pages that use
previewCardandlookCardkeep their boxed cards. - The look and preview headings are still
h2inside each variant section. I did not add a heading-level option.
Try it
Open /:owner/:name/variants/:group on a repo with variant pulls.
🤖 Generated with Claude Code
Merged main into the branch and pushed. The one conflict was in src/web/pages/looks.ts.
What changed
mainhad already turnedlookCardinto a plain section. I tookmain'slooks.tsas it stands and dropped myplainflag from it.previewCardkeeps the optionalplainflag, and the variants deck still passes it. Theblockhelper insrc/web/ui.tsis unchanged.- In
variants.tsthe deck now callslookCardwithout the extra argument.
Checks
bun x tsc --noEmitandbun scripts/gate.tspass.- The variants language, deck and surfaces tests pass: 16 tests, 0 failures.
I did not run the wider suite here. The forge's check will run it on this push.
I made no code change for this failure. I pushed an empty commit to make the forge re-run the check.
The failing test is in test/traffic-truth.test.ts. It covers the admin traffic board and probe, which this pull doesn't touch. Run alone here it passes, four runs out of four. It failed in shard 19 of the forge's full run, so I think it's flaky under load. I haven't confirmed that.
If it fails again on the same test, it needs a look from someone who owns the traffic code.
Parked by the crew: the check stayed red through 2 automatic tries
A variants deck now shows sibling pulls as plain sections with no
class="cardinside<main>, and the all-decided state is one muted line.What changed
block(body, head)is a new helper insrc/web/ui.ts. It renders asettings-blocksection with the head in a.bar, so no new component class and no CSS change.lookCardandpreviewCardtake an optional trailingplainflag. The deck passestrue; every other caller keeps its card.src/web/pages/variants.tsthe all-decided state is<p class="muted">Every variant is decided.</p>.…/:number/likeand…/dislike, and the swipe script is unchanged.test/variants-language.test.tsis new. It checks that there is no card, both variant sections render, and the like and dislike actions are present. It also checks that a like still records and that the all-decided deck is one line.Checks
bun x tsc --noEmit,bun scripts/gate.tsandbun scripts/design-lint.tspass.lookCardonly through the newplainflag. The forge's check will run them. I did not run the full suite:scripts/fast.tssaid the diff was too broad to name, so I ran the covering files instead.Left out
previewCardandlookCardkeep their boxed cards.h2inside each variant section. I did not add a heading-level option.Try it Open
/:owner/:name/variants/:groupon a repo with variant pulls.🤖 Generated with Claude Code
Closes #9958