Public: anyone can read this; the crew can change it.

A variants deck speaks the home page's language #9968

Parked opened this
Closed without merging

A variants deck now shows sibling pulls as plain sections with no class="card inside , and the all-decided state is one muted line. What changed block(body, head) is a new helper in src/web/ui.ts. It renders a settings-block section with the head in a .bar, so no new component class and no CSS change.

Notes

stopped parked by the crew deploy ebdb78d

opened this

A variants deck now shows sibling pulls as plain sections with no class="card inside <main>, and the all-decided state is one muted line.

What changed

  • block(body, head) is a new helper in src/web/ui.ts. It renders a settings-block section with the head in a .bar, so no new component class and no CSS change.
  • lookCard and previewCard take an optional trailing plain flag. The deck passes true; every other caller keeps its card.
  • In src/web/pages/variants.ts the all-decided state is <p class="muted">Every variant is decided.</p>.
  • Like and dislike are still plain same-origin form posts to …/:number/like and …/dislike, and the swipe script is unchanged.
  • test/variants-language.test.ts is new. It checks that there is no card, both variant sections render, and the like and dislike actions are present. It also checks that a like still records and that the all-decided deck is one line.

Checks

  • bun x tsc --noEmit, bun scripts/gate.ts and bun scripts/design-lint.ts pass.
  • The existing variants deck, surfaces and timing tests pass.
  • On main, the like-and-all-decided test fails and the deck test passes. The deck test cannot show a card in the sandbox because nothing serves previews there, so the old look and preview cards never render. It still guards against one coming back.
  • Three look-capture tests in the looks suite fail here. They need chromium, and the sandbox refuses it with "socket() failed: Operation not permitted". They touch lookCard only through the new plain flag. The forge's check will run them. I did not run the full suite: scripts/fast.ts said the diff was too broad to name, so I ran the covering files instead.

Left out

  • Other pages that use previewCard and lookCard keep their boxed cards.
  • The look and preview headings are still h2 inside each variant section. I did not add a heading-level option.

Try it Open /:owner/:name/variants/:group on a repo with variant pulls.

🤖 Generated with Claude Code

Closes #9958

3 earlier comments
commented

A variants deck now shows sibling pulls as plain sections with no class="card inside <main>, and the all-decided state is one muted line.

What changed

  • block(body, head) is a new helper in src/web/ui.ts. It renders a settings-block section with the head in a .bar, so no new component class and no CSS change.
  • lookCard and previewCard take an optional trailing plain flag. The deck passes true; every other caller keeps its card.
  • In src/web/pages/variants.ts the all-decided state is <p class="muted">Every variant is decided.</p>.
  • Like and dislike are still plain same-origin form posts to …/:number/like and …/dislike, and the swipe script is unchanged.
  • test/variants-language.test.ts is new. It checks that there is no card, both variant sections render, and the like and dislike actions are present. It also checks that a like still records and that the all-decided deck is one line.

Checks

  • bun x tsc --noEmit, bun scripts/gate.ts and bun scripts/design-lint.ts pass.
  • The existing variants deck, surfaces and timing tests pass.
  • On main, the like-and-all-decided test fails and the deck test passes. The deck test cannot show a card in the sandbox because nothing serves previews there, so the old look and preview cards never render. It still guards against one coming back.
  • Three look-capture tests in the looks suite fail here. They need chromium, and the sandbox refuses it with "socket() failed: Operation not permitted". They touch lookCard only through the new plain flag. The forge's check will run them. I did not run the full suite: scripts/fast.ts said the diff was too broad to name, so I ran the covering files instead.

Left out

  • Other pages that use previewCard and lookCard keep their boxed cards.
  • The look and preview headings are still h2 inside each variant section. I did not add a heading-level option.

Try it Open /:owner/:name/variants/:group on a repo with variant pulls.

🤖 Generated with Claude Code

commented

Merged main into the branch and pushed. The one conflict was in src/web/pages/looks.ts.

What changed

  • main had already turned lookCard into a plain section. I took main's looks.ts as it stands and dropped my plain flag from it.
  • previewCard keeps the optional plain flag, and the variants deck still passes it. The block helper in src/web/ui.ts is unchanged.
  • In variants.ts the deck now calls lookCard without the extra argument.

Checks

  • bun x tsc --noEmit and bun scripts/gate.ts pass.
  • The variants language, deck and surfaces tests pass: 16 tests, 0 failures.

I did not run the wider suite here. The forge's check will run it on this push.

commented

I made no code change for this failure. I pushed an empty commit to make the forge re-run the check.

The failing test is in test/traffic-truth.test.ts. It covers the admin traffic board and probe, which this pull doesn't touch. Run alone here it passes, four runs out of four. It failed in shard 19 of the forge's full run, so I think it's flaky under load. I haven't confirmed that.

If it fails again on the same test, it needs a look from someone who owns the traffic code.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs