Public: anyone can read this; the crew can change it.

A row is one line: a run's summary never becomes a paragraph on the app page #9946

Parked opened this
Closed without merging

A run's summary now shows as one escaped, CSS-clamped line in every row that displays it, with the whole text in the row's title attribute.

Notes

stopped parked by the crew

opened this

A run's summary now shows as one escaped, CSS-clamped line in every row that displays it, with the whole text in the row's title attribute. This run found nothing left to change: the head on the forge (8b59a538) is already the finished work, and its check is running against current main (e480607d, which only touches src/release/prove.ts). So there was nothing new to push.

What changed

  • src/web/studio/note.ts (new): noteLine() turns newlines and runs of spaces into single spaces. It caps the text at NOTE_MAX (2000 characters) only to keep the page small, escapes it, and puts it in a <span class="row-note"> with the whole text in title. It never renders markdown, so a backtick or asterisk shows as itself.
  • Where it is used: the runs list (lists.ts), the run, issue and pull rows in Now (now.ts), and the runs on a tell's page (tell.ts). In Now, a row titled by the summary gets the flattened text too.
  • .row-note in src/web/style/components.ts: one line, ellipsis, at most min(60ch, calc(100% - 14ch)) wide. That keeps the who before it and the time after it in sight. It is listed in docs/design/areas/runs.md. The full summary is still in the transcript, one click from the row.
  • Test: test/studio.test.ts renders a run whose summary is a 600-character, multi-line report full of markdown. It checks the note is one line, title holds the whole text, the punctuation shows literally, and the time is still there. It fails on the old code.

What I chose not to do

  • Ask cards and the decision ledger: today their "says" lines are sentences built from structured fields like the pull title, counts and the review wait. They no longer show a run's summary, and the cards are meant to be paragraphs, so I left them alone. There is no decision ledger on the studio pages that shows run summaries.
  • #69's class: no shared app-row clamp class exists on main to reuse, so .row-note is the only one.

How to try it On the preview (https://lab--9946--forge-trevato-apps.open-platform.sh), open a repository's Runs tab or the app page's Now. A long agent summary sits on one line ending in an ellipsis, the time stays visible after it, and hovering shows the whole text.

Checks run here: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts all pass. I ran the tests for studio, Now, runs, tell and design: 135 pass, 4 skipped in this sandbox, 0 fail. scripts/fast.ts named 1362 test files, far over its time budget, so I picked those by hand.

🤖 Generated with Claude Code

Closes #73

3 earlier comments · 1 event
commented

A run's summary now shows as one escaped, CSS-clamped line in every row that displays it, with the whole text in the row's title attribute. This run found nothing left to change: the head on the forge (8b59a538) is already the finished work, and its check is running against current main (e480607d, which only touches src/release/prove.ts). So there was nothing new to push.

What changed

  • src/web/studio/note.ts (new): noteLine() turns newlines and runs of spaces into single spaces. It caps the text at NOTE_MAX (2000 characters) only to keep the page small, escapes it, and puts it in a <span class="row-note"> with the whole text in title. It never renders markdown, so a backtick or asterisk shows as itself.
  • Where it is used: the runs list (lists.ts), the run, issue and pull rows in Now (now.ts), and the runs on a tell's page (tell.ts). In Now, a row titled by the summary gets the flattened text too.
  • .row-note in src/web/style/components.ts: one line, ellipsis, at most min(60ch, calc(100% - 14ch)) wide. That keeps the who before it and the time after it in sight. It is listed in docs/design/areas/runs.md. The full summary is still in the transcript, one click from the row.
  • Test: test/studio.test.ts renders a run whose summary is a 600-character, multi-line report full of markdown. It checks the note is one line, title holds the whole text, the punctuation shows literally, and the time is still there. It fails on the old code.

What I chose not to do

  • Ask cards and the decision ledger: today their "says" lines are sentences built from structured fields like the pull title, counts and the review wait. They no longer show a run's summary, and the cards are meant to be paragraphs, so I left them alone. There is no decision ledger on the studio pages that shows run summaries.
  • #69's class: no shared app-row clamp class exists on main to reuse, so .row-note is the only one.

How to try it On the preview (https://lab--9946--forge-trevato-apps.open-platform.sh), open a repository's Runs tab or the app page's Now. A long agent summary sits on one line ending in an ellipsis, the time stays visible after it, and hovering shows the whole text.

Checks run here: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts all pass. I ran the tests for studio, Now, runs, tell and design: 135 pass, 4 skipped in this sandbox, 0 fail. scripts/fast.ts named 1362 test files, far over its time budget, so I picked those by hand.

🤖 Generated with Claude Code

commented

A run's summary now shows as one escaped line, clamped by CSS, with the whole text in the row's title attribute. The who before it and the time after it stay in view.

The red check is not fixed. It failed on one test in test/flow-keeper.test.ts: "the cause and last act show on the boards panel and the MCP flow report, not on home (#8015)". It has failed three times on this branch (this pull and the earlier #9924), always in shard 20 of the fast tier, and has not failed in other pulls' checks. I could not find a cause, and I did not change that test. This push only merges five new commits from origin/main, which changes how the check splits files into shards. If shard 20 goes red again, a person should look at the test.

The log the forge keeps is cut off before shard 20's output, so I never saw which assertion failed. What I ruled out:

  • The test passes alone, beside test/studio.test.ts, in an approximate copy of shard 20, after all 89 flow- and boards- files, and as 12 copies run at once. Locally / and /boards both return 200 and the keeper line is there.
  • /boards and the keeper never reach the changed code: noteLine is only used by the runs list, Now and a tell's runs.
  • No test file leaves a fetch or clock stub, setSystemTime, or a relevant environment variable behind. The page caches are per database. Bun's fetch handles a server restarted on the same port.

What changed

  • src/web/studio/note.ts (new): noteLine() collapses newlines and runs of spaces, caps the text at NOTE_MAX (2000 characters) to keep the page small, escapes it, and wraps it in <span class="row-note"> with the whole text in title. It never renders markdown, so backticks, asterisks and links show as typed.
  • Where it is used: the runs list (lists.ts), the run, issue and pull rows in Now (now.ts), and a tell's runs (tell.ts).
  • .row-note in src/web/style/components.ts: one line, ellipsis, narrower than the row's meta. It is documented in docs/design/areas/runs.md.
  • Test: test/studio.test.ts renders a 600-character multi-line summary full of markdown and HTML. It checks for one line, the full text in title, the characters shown literally, the HTML escaped, and the time still after the note. It fails on the code before this change.

Not done

  • Ask cards and the decision ledger: their "says" lines are sentences built from structured fields and no longer show a run's summary. They are meant as paragraphs, so I left them alone.
  • #69's clamp class does not exist on main, so .row-note is the only one.

To try it: on the preview, open a repository's Runs tab or an app page's Now. A long agent summary sits on one line ending in "…", the time stays visible, and hovering shows the full text.

Checks run here: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts pass. After the merge I ran 8 test files (studio, flow-keeper, Now, studio runs, tell words, combined check): 111 tests, 0 fail, 4 skipped in this sandbox. The merge commit uses git's default message and has no co-author line.

🤖 Generated with Claude Code

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

A run's summary in the studio is now one line: it is cut off with an ellipsis where it overflows, escaped, and the full text is in its title. This applies everywhere the studio lists runs: the now view, the lists and the tell page. A long or multi-line summary can no longer stretch a row, so every row in a list is the same height.

  • What changed: src/web/studio/note.ts builds the one-line note. now.ts, lists.ts and tell.ts use it, and the new class is styled in src/web/style/components.ts. The component is documented in docs/design/areas/runs.md.
  • Tests: new tests in test/studio.test.ts check that a multi-line, markup-laden summary renders as one escaped line, and that the title holds the whole text.
  • Not done: I didn't add a way to expand the note in place. The full text is in the title, and the run's own page still shows the whole summary.
  • The last check's failure: one test failed on shard 20, "fleet operations > over HTTP: a dry run by default, a read token cannot apply, and a receipt is its actor's". The log has no assertion output for it, and the run reported low free disk. That test hasn't changed since Oct 17 and doesn't use the studio code this pull changes. Locally it passes alone, by name, and with eight copies run at once. I pushed an empty commit to re-run the check and left the test as it is. If it fails again, the next log should show which assertion broke.
  • Before pushing: bun scripts/gate.ts and bun x tsc --noEmit passed, as did bun test test/studio.test.ts test/fleet-ops.test.ts (33 pass, 0 fail).

To try it on the preview (https://lab--9946--forge-trevato-apps.open-platform.sh), open the studio and look at the run list. A run whose summary is long or spans several lines shows one cut-off line, and hovering over it shows the whole summary.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs