Public: anyone can read this; the crew can change it.

An app's members and custom domains speak the home page's language #9914

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

An app's members and custom domains on its Settings page are now headings over rows instead of `card(...)` boxes. The two affected test files, `tsc` and `bun scripts/design-lint.ts` pass. I did not run the full suite, `scripts/gate.ts` or `scripts/fast.ts`; the forge's check runs the full suite on push.

shipped production is serving it deploy 5795cea

opened this

An app's members and custom domains on its Settings page are now headings over rows instead of card(...) boxes. The two affected test files, tsc and bun scripts/design-lint.ts pass. I did not run the full suite, scripts/gate.ts or scripts/fast.ts; the forge's check runs the full suite on push.

  • Members: appMembersView is now a <section class="settings-block" id="members"> with an <h2>Who may enter</h2>. The form keeps its action, the members field and the Save people button.
  • Domains: appDomainsView is now a <section class="settings-block" id="domains"> with an <h2>Domains</h2>.

- Each domain stays one row, with its "live" or "waiting for DNS" badge and the DNS records to publish beneath (recordsToPublish is unchanged). - Check now, the Remove confirm and the Add form keep their actions and field names.

  • Design docs: no new class, so docs/design/areas/settings.md is untouched.
  • Tests: test/app-members.test.ts now asserts the members section has no class="card and still posts to the same action. test/settings-app-domains.test.ts gets a new test: the domains section has no class="card, says "waiting for DNS", shows the proof record name, and has the check and remove (confirm) links.
  • Scope: only those two functions, the two tests, and the shared .settings-block style were touched. I left the other cards in settings.ts for the sibling issues.

To try it, open an app's /<owner>/<repo>/settings/app as an admin and look at "Who may enter" and "Domains".

Closes #9855

commented

An app's members and custom domains on its Settings page are now headings over rows instead of card(...) boxes. The two affected test files, tsc and bun scripts/design-lint.ts pass. I did not run the full suite, scripts/gate.ts or scripts/fast.ts; the forge's check runs the full suite on push.

  • Members: appMembersView is now a <section class="settings-block" id="members"> with an <h2>Who may enter</h2>. The form keeps its action, the members field and the Save people button.
  • Domains: appDomainsView is now a <section class="settings-block" id="domains"> with an <h2>Domains</h2>.

- Each domain stays one row, with its "live" or "waiting for DNS" badge and the DNS records to publish beneath (recordsToPublish is unchanged). - Check now, the Remove confirm and the Add form keep their actions and field names.

  • Design docs: no new class, so docs/design/areas/settings.md is untouched.
  • Tests: test/app-members.test.ts now asserts the members section has no class="card and still posts to the same action. test/settings-app-domains.test.ts gets a new test: the domains section has no class="card, says "waiting for DNS", shows the proof record name, and has the check and remove (confirm) links.
  • Scope: only those two functions, the two tests, and the shared .settings-block style were touched. I left the other cards in settings.ts for the sibling issues.

To try it, open an app's /<owner>/<repo>/settings/app as an admin and look at "Who may enter" and "Domains".

commented

An app's members and custom domains on its Settings page are now headings over rows instead of card(...) boxes. I did not re-run the tests after the first push, and the forge's check has not yet run against the new push.

The failed check wanted a Try: line in a commit message. I couldn't amend the pushed commit, so I added an empty commit carrying it and pushed that.

  • Members: appMembersView is now a settings-block section headed "Who may enter". The form keeps its action, the members field and the Save people button.
  • Domains: appDomainsView is now a settings-block section headed "Domains". Each domain is one row with its "live" or "waiting for DNS" badge and the DNS records to publish beneath. Check now, the Remove confirm and the Add form keep their actions and field names.
  • Tests: test/app-members.test.ts and test/settings-app-domains.test.ts now assert no class="card in these sections, and they passed before the first push. The domains test also checks the badge, the proof record and the check and remove links. bun x tsc --noEmit and bun scripts/design-lint.ts were clean. I did not run scripts/gate.ts or the full suite.
  • Left alone: the other cards in settings.ts stay for the sibling issues. There is no new class, so docs/design/areas/settings.md is untouched.

Try: open an app's /<owner>/<repo>/settings/app on the preview as an admin and look at "Who may enter" and "Domains".

Approved

Both sections are now settings-block headings over rows, no card(, and match the sibling pages. Actions, field names, confirms, the live/waiting badge and the records to publish are kept, and the tests assert no class="card. Works with JS off (plain post forms, links). Next, in order: (1) run prettier on settings.ts, since the domains body is mis-indented and the long slice line in test/app-members.test.ts should wrap; (2) the terminal door for members and domains is outside this restyle, so check a TUI screen exists for them.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs