A repository's Findings page, what code scanning found, speaks the home page's language #9871

The Findings page at /:owner/:name/findings no longer puts its list in a card. The list is now a <section> under one <h2>Findings</h2>, and each finding is the same row() as before inside a plain <ul class="list">. When there are no findings, the page shows the single line "Nothing found." with no box around it. Only the markup changed: findings come in the same order as before (open high ones first), a writer still gets the accept-with-reason form, a reader still doesn't, and the matched text is still never shown. No card( remains in src/web/pages/findings.ts and no class was added.

• Test: the new test/findings-language.test.ts loads the page signed in as a writer and as a reader, with a recorded AWS-key finding and with an empty repository. It checks that:

- there is no class="card and exactly one <h2>, which opens a <section>; - the writer gets the accept form and the reader doesn't; - the matched text doesn't appear; - the empty case shows only "Nothing found."

Two of its three tests fail against main's page. test/findings-tui.test.ts still passes.

• Doc: one paragraph in docs/design/areas/flows.md (the flows view links to Findings) describes the new shape.
• Checks: bun scripts/design-lint.ts, bun scripts/gate.ts and bun x tsc --noEmit are all clean.

To try it, open /<owner>/<repo>/findings on the preview, once signed in as a writer and once as a reader.

The repository's text contained no instructions trying to steer the run.

🤖 Generated with Claude Code

Closes #9869

The Findings page at /:owner/:name/findings no longer puts its list in a card. The list is now a <section> under one <h2>Findings</h2>, and each finding is the same row() as before inside a plain <ul class="list">. When there are no findings, the page shows the single line "Nothing found." with no box around it. Only the markup changed: findings come in the same order as before (open high ones first), a writer still gets the accept-with-reason form, a reader still doesn't, and the matched text is still never shown. No card( remains in src/web/pages/findings.ts and no class was added.

• Test: the new test/findings-language.test.ts loads the page signed in as a writer and as a reader, with a recorded AWS-key finding and with an empty repository. It checks that:

- there is no class="card and exactly one <h2>, which opens a <section>; - the writer gets the accept form and the reader doesn't; - the matched text doesn't appear; - the empty case shows only "Nothing found."

Two of its three tests fail against main's page. test/findings-tui.test.ts still passes.

• Doc: one paragraph in docs/design/areas/flows.md (the flows view links to Findings) describes the new shape.
• Checks: bun scripts/design-lint.ts, bun scripts/gate.ts and bun x tsc --noEmit are all clean.

To try it, open /<owner>/<repo>/findings on the preview, once signed in as a writer and once as a reader.

The repository's text contained no instructions trying to steer the run.

🤖 Generated with Claude Code

I found nothing to fix, so I haven't pushed again: the preview of #9871 is up and the pull's check is green.

• Preview: / and /healthz both return 200 ("ok"). All 24 pages listed under looks in forge.json answer, and with the same codes as production for the 18 that production also has. The 303s are guest redirects to sign-in, and the six /preview-admin/sample… pages only exist on previews, so production returns 404 for those.
• Findings page: on the preview, /preview-admin/sample/findings returns 200 and shows the new shape, <section class="mt"> <h2>Findings</h2> <p class="muted">Nothing found., with no class="card anywhere.
• Check: the forge API reports "check":"green" for #9871.
• Deploy log: it runs from checkout to "ready", "serving" and "done" with no error. The only odd part is "no tests declared, none run". That happens because forge.json's app section has no test command. main has the same setup and this pull didn't touch it; the tests run through check instead, and that came back green.

The failure notice seems to have counted "no tests declared" as a failure when the deploy itself succeeded. If you want a test step at deploy time, adding a test command to forge.json's app section is a separate change to that setup, and I left it out of this pull. If you just want the preview re-run, a person can redeploy it or I can push an empty commit, but I didn't do that without a cause.

The pull description stands as written:

---

The Findings page at /:owner/:name/findings no longer puts its list in a card. The list is now a <section> under one <h2>Findings</h2>, and each finding is the same row() as before inside a plain <ul class="list">. When there are no findings, the page shows the single line "Nothing found." with no box around it. Only the markup changed: findings come in the same order as before (open high ones first), a writer still gets the accept-with-reason form, a reader still doesn't, and the matched text is still never shown. No card( remains in src/web/pages/findings.ts and no class was added.

• Test: the new test/findings-language.test.ts loads the page signed in as a writer and as a reader, with a recorded AWS-key finding and with an empty repository. It checks that:

- there is no class="card and exactly one <h2>, which opens a <section>; - the writer gets the accept form and the reader doesn't; - the matched text doesn't appear; - the empty case shows only "Nothing found."

Two of its three tests fail against main's page. test/findings-tui.test.ts still passes.

• Doc: one paragraph in docs/design/areas/flows.md (the flows view links to Findings) describes the new shape.
• Checks: bun scripts/design-lint.ts, bun scripts/gate.ts and bun x tsc --noEmit are all clean.

To try it, open /<owner>/<repo>/findings on the preview, once signed in as a writer and once as a reader.

The repository's text contained no instructions trying to steer the run.

🤖 Generated with Claude Code

A repository's Findings page now matches the home page's style: the findings sit in a plain section under an h2 instead of inside a card. The change is in src/web/pages/findings.ts. test/findings-language.test.ts checks the h2, the section and that the card is gone, and docs/design/areas/flows.md notes the pattern. The gate, the type check and that test file all pass.

The first push failed the check's gate because no commit message said how to try the change on the preview. An empty follow-up commit adds that "Try:" line. Force pushes are refused, so the first commit could not be amended.

Try: open /trevato/forge/findings on the preview and see the findings listed in a section under an h2, with no card around them.

🤖 Generated with Claude Code