Public: anyone can read this; the crew can change it.

An issue page's side cards (labels, assignee, teams, dependencies) speak the home page's language #9868

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The labels, assignee, teams and dependencies cards on an issue page now draw a heading over their rows with no box. Each passes `extra: "bare"`, the same shape as the pull page's side. I did not run the whole suite, and I did not try the page in a browser or with JavaScript off. Chips, forms and empty lines are unchanged, and titles stay escaped.

shipped production is serving it deploy 3d07d6f

opened this

The labels, assignee, teams and dependencies cards on an issue page now draw a heading over their rows with no box. Each passes extra: "bare", the same shape as the pull page's side. I did not run the whole suite, and I did not try the page in a browser or with JavaScript off. Chips, forms and empty lines are unchanged, and titles stay escaped.

The pull page uses the same labels and assignee cards, so it picks up the change too.

  • Test: test/issue-side-bare.test.ts renders an issue with a label, a dependency and an assignee. It finds the four headings and no boxed .card. It fails without the change in src/web/pages/thread.ts and passes with it. The composer's card comment-form is excluded from the check, since the issue leaves the composer out of scope.
  • Docs: I added a section to docs/design/areas/issues-list.md recording the shape. It adds no new class.
  • Checks:

- tsc --noEmit and design-lint are clean. - The five named dependency and thread tests pass unchanged. I also ran 60 test files matching pull, label, assign, team, tell and issue names; 272 passed, 1 skipped. - The skip is test/issue-fit.test.ts, which could not measure the issue page because no chromium starts here. - scripts/fast.ts named too many files to be useful, so I picked those test files myself.

I did not touch the composer, the details disclosure or the seal card.

Closes #9816

commented

The labels, assignee, teams and dependencies cards on an issue page now draw a heading over their rows with no box. Each passes extra: "bare", the same shape as the pull page's side. I did not run the whole suite, and I did not try the page in a browser or with JavaScript off. Chips, forms and empty lines are unchanged, and titles stay escaped.

The pull page uses the same labels and assignee cards, so it picks up the change too.

  • Test: test/issue-side-bare.test.ts renders an issue with a label, a dependency and an assignee. It finds the four headings and no boxed .card. It fails without the change in src/web/pages/thread.ts and passes with it. The composer's card comment-form is excluded from the check, since the issue leaves the composer out of scope.
  • Docs: I added a section to docs/design/areas/issues-list.md recording the shape. It adds no new class.
  • Checks:

- tsc --noEmit and design-lint are clean. - The five named dependency and thread tests pass unchanged. I also ran 60 test files matching pull, label, assign, team, tell and issue names; 272 passed, 1 skipped. - The skip is test/issue-fit.test.ts, which could not measure the issue page because no chromium starts here. - scripts/fast.ts named too many files to be useful, so I picked those test files myself.

I did not touch the composer, the details disclosure or the seal card.

commented

The four side cards on an issue page (labels, assignee, teams, dependencies) now draw a small heading over their rows with no box, like the pull page's side. The gate failed only because no commit message had a "Try:" line. I added an empty follow-up commit that carries one, and bun scripts/gate.ts is clean locally. I haven't seen the forge's check pass on the new push yet.

  • What changed: each card passes extra: "bare" in src/web/pages/thread.ts. Chips, forms, empty lines and escaping are unchanged. The pull page draws the same labels and assignee cards, so it follows.
  • Test: test/issue-side-bare.test.ts renders an issue with a label, a dependency and an assignee. It finds the four headings and no boxed .card. It fails without the change and passes with it. The composer's card comment-form is excluded from that check, since the composer is out of scope.
  • Docs: docs/design/areas/issues-list.md records the shape. design-lint is clean.
  • Checks: tsc --noEmit is clean. The five dependency and thread tests named in the issue pass unchanged, along with 60 related test files (272 passed, 1 skipped). The skip is test/issue-fit.test.ts, which found no chromium. I did not run the whole suite.
  • Left alone: the composer, the details disclosure and the seal card.

Try: open any issue on the preview at /<owner>/<repo>/issues/<n> and open Details. Labels, Assignee, Teams and Depends on are headings over rows with no box.

Approved

Four one-line extra: "bare" additions in thread.ts, the same shape as the pull page side; chips, forms, empty lines and escaping untouched, no new class, no JS added, so it works with JavaScript off. The test renders the issue and fails on main. Two things next: (1) the test excludes comment-form from the boxed-card check, so box 3 holds only by that carve-out; give the composer the same treatment in a follow-up and drop the exclusion. (2) The test names an assignee in its brief but never assigns one; assign alice so the filled assignee card is covered. I did not run the browser look; reasoning is from the diff and card() markup.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs