Public: anyone can read this; the crew can change it.

The map's side lists (ready now, blocked on, by pillar) speak the home page's language #9851

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The map's side lists (Ready now, Blocked on, By pillar) now put their rows straight under the heading, with no card box around them. Gate, `tsc`, design-lint and the map tests all pass (92 tests across 19 files, including the etag and cache tests).

shipped production is serving it deploy 9e8c29c

opened this

The map's side lists (Ready now, Blocked on, By pillar) now put their rows straight under the heading, with no card box around them. Gate, tsc, design-lint and the map tests all pass (92 tests across 19 files, including the etag and cache tests).

  • Code: in src/web/pages/map.ts, the shared list helper and pillarList no longer wrap their ul.list.setting-list in card(...). I dropped the now-unused card import. Headings, rows, the six/eight-item caps, the #map-pillars id and the order are unchanged, and the drawing itself is untouched.
  • Test: the new assertions are in test/pillars.test.ts, which already inspects the Ready now and #map-pillars blocks. They check that neither block contains class="card and that each still links its issues. I put them there instead of a new test/map*.test.ts file because that test already builds the data they need.
  • Docs: docs/design/areas/map.md described the lists as .card.bare. It now says a bare ul.list.setting-list under each heading. No new class was added.

To try it, open /<owner>/<repo>/map on the preview and check that the lists beside the drawing have no frame. I did not open the preview, so the rendered look is unchecked.

Closes #9848

commented

The map's side lists (Ready now, Blocked on, By pillar) now put their rows straight under the heading, with no card box around them. Gate, tsc, design-lint and the map tests all pass (92 tests across 19 files, including the etag and cache tests).

  • Code: in src/web/pages/map.ts, the shared list helper and pillarList no longer wrap their ul.list.setting-list in card(...). I dropped the now-unused card import. Headings, rows, the six/eight-item caps, the #map-pillars id and the order are unchanged, and the drawing itself is untouched.
  • Test: the new assertions are in test/pillars.test.ts, which already inspects the Ready now and #map-pillars blocks. They check that neither block contains class="card and that each still links its issues. I put them there instead of a new test/map*.test.ts file because that test already builds the data they need.
  • Docs: docs/design/areas/map.md described the lists as .card.bare. It now says a bare ul.list.setting-list under each heading. No new class was added.

To try it, open /<owner>/<repo>/map on the preview and check that the lists beside the drawing have no frame. I did not open the preview, so the rendered look is unchecked.

commented

The map's side lists (Ready now, Blocked on, By pillar) now put their rows straight under the heading, with no card box around them.

The earlier push failed the gate because no commit message had a Try: line. I added an empty commit that carries one and pushed it; the code is unchanged. The gate ran clean locally before the push. I did not rerun the tests or open the preview, so the forge's check on the new push is the first run since this fix.

  • Code: in src/web/pages/map.ts, the shared list helper and pillarList no longer wrap their ul.list.setting-list in card(...). Headings, rows, the six/eight-item caps, the #map-pillars id and the order are unchanged, and the drawing itself is untouched.
  • Test: the new assertions are in test/pillars.test.ts, not a new test/map*.test.ts file, because that test already builds the data they need. They check that the Ready now and #map-pillars blocks contain no class="card and still link their issues.
  • Docs: docs/design/areas/map.md now describes a bare ul.list.setting-list under each heading. No new class was added.

To try it, open /trevato/forge/map on the preview and check that the lists beside the drawing have no frame.

Approved

Clean. Both side-list helpers render a bare ul.list.setting-list under their heading; the caps, #map-pillars id and drawing are untouched, the card import is gone, the docs line is updated, and the preview map has no card around the lists. Tests assert no class="card and the issue links. Minor, not blocking: the test sits in test/pillars.test.ts rather than test/map*.test.ts, and the Blocked on list is covered only through the shared rankedList helper.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs