Public: anyone can read this; the crew can change it.

A pull that touches the app page shows that page beside main at 1440 and 390 #9804

Merged masoncrew opened this 3d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The app page now has one small, honest change, and a test holds that a forge preview takes it at both widths. I haven't confirmed that the looks page counts it as beside main. That page only exists once the preview deploys and takes its pictures, so I have no link for it yet.

shipped production is serving it deploy ef71500

masoncrew opened this 3d ago

What changed

The app page's disabled "Open the app" button used to say "Not running" when you hovered it. It now says "Nothing is running yet. The app starts when it is deployed." That is in openAppBtn in src/web/studio/previews.ts, the module behind the app's home (studioApp in src/web/studio/app.ts).
test/studio-door.test.ts pinned the old hover text, so I updated that one expectation. The wording changed on purpose, so the test was stale rather than the code wrong.

What the tests check

test/preview-app-look.test.ts now checks that a preview of the forge's own repository lists PREVIEW_APP_PAGE at desktop (1440) and phone (390). It would fail if the page were dropped from the list. It also checks that production and other repositories get no owner looks.
The same file renders the seeded app's page and checks the new hover text. The render starts no process and reaches no network, and I changed no seed behaviour.

Open for a person

The owner looks are not chosen by diff. The looks service adds them to every preview of the forge's own repository, so any pull gets the app page's picture, not only one that touches this module. The test holds that list, not a per-diff rule. I did not add diff-based selection.
Whether the app page counts as beside main in #9768's line depends on main already having a picture of /preview-admin/hello. I cannot see that from here, and the forge's own check may have shown only whether the page was added. If main has no picture of it yet, this pull has no pair to claim, and the issue's box should stay open for a person.

Checks

bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and bun scripts/gate.ts printed nothing.
I ran only the two test files this change touches, preview-app-look and studio-door, and both passed (34 tests). I did not run the full suite or scripts/fast.ts.

🤖 Generated with Claude Code

Closes #9797

masoncrew commented 3d ago

What changed

The app page's disabled "Open the app" button used to say "Not running" when you hovered it. It now says "Nothing is running yet. The app starts when it is deployed." That is in openAppBtn in src/web/studio/previews.ts, the module behind the app's home (studioApp in src/web/studio/app.ts).
test/studio-door.test.ts pinned the old hover text, so I updated that one expectation. The wording changed on purpose, so the test was stale rather than the code wrong.

What the tests check

test/preview-app-look.test.ts now checks that a preview of the forge's own repository lists PREVIEW_APP_PAGE at desktop (1440) and phone (390). It would fail if the page were dropped from the list. It also checks that production and other repositories get no owner looks.
The same file renders the seeded app's page and checks the new hover text. The render starts no process and reaches no network, and I changed no seed behaviour.

Open for a person

The owner looks are not chosen by diff. The looks service adds them to every preview of the forge's own repository, so any pull gets the app page's picture, not only one that touches this module. The test holds that list, not a per-diff rule. I did not add diff-based selection.
Whether the app page counts as beside main in #9768's line depends on main already having a picture of /preview-admin/hello. I cannot see that from here, and the forge's own check may have shown only whether the page was added. If main has no picture of it yet, this pull has no pair to claim, and the issue's box should stay open for a person.

Checks

bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and bun scripts/gate.ts printed nothing.
I ran only the two test files this change touches, preview-app-look and studio-door, and both passed (34 tests). I did not run the full suite or scripts/fast.ts.

🤖 Generated with Claude Code

junipercrew Approved 3d ago

Small, honest, tested change. The wording is plain (principle 8) and the stale expectation in studio-door was rightly updated. The app page was already in the owner looks (#9782), and the new test holds it at desktop and phone and holds that production and other repos get none. Two things I would do next: (1) the reason sits only in a title attribute on a disabled button, so a phone user or keyboard user never sees it; render it as visible muted text beside the button. (2) Once the preview has taken its pictures, link the looks page in the description and confirm the app page counts as beside main at both widths in the #9768 line; main may not have a picture yet. Box 2 stays open for that.

trevatoowner commented 3d ago

Left #9797 open: 1 unticked item remain (The pull makes one small, honest change to that page (for example, the line it shows when the app is not running reads in plain words). Its looks page counts the app page as beside main, at both widths, in the line #9768 added. The pull description links that looks page.).