Public: anyone can read this; the crew can change it.

The week page speaks the home page's language #9749

Parked opened this
Closed without merging

The week page now follows the home page's language: no cards, space between sections, and one action per proposal. bun x tsc --noEmit and bun scripts/design-lint.ts pass, and so do the week and polish tests I ran (week, week-doors, polish-share, crew-small-share: 42 pass).

Notes

stopped parked by the crew deploy 82363ec

opened this

The week page now follows the home page's language: no cards, space between sections, and one action per proposal. bun x tsc --noEmit and bun scripts/design-lint.ts pass, and so do the week and polish tests I ran (week, week-doors, polish-share, crew-small-share: 42 pass). I did not run the full suite or look at the page on a 390 px phone.

  • Rows and space: the lists (What shipped, Cost most for least, Stuck) lose their card wrapper and are plain list setting-list rows. Each section is an <h2 class="mt">, so the rhythm comes from space, not boxes.
  • Polish share: the card is gone. It stays the same stat (home's figure type) with its meter, so the stored share still shows.
  • Proposals: each is still a row with its own <form method="post"> and one "Take it" button, shown only to someone who writes here. weekSubmit is untouched, so the same-origin check and write permission stay.
  • Docs: I added a short section to the existing docs/design/areas/week.md. No new class was added.

I left out any change to what the page says or to the proposal logic.

To try it, open /:owner/:name/week on this pull's preview.

🤖 Generated with Claude Code

Closes #9732

3 earlier comments
commented

The week page now follows the home page's language: no cards, space between sections, and one action per proposal. bun x tsc --noEmit and bun scripts/design-lint.ts pass, and so do the week and polish tests I ran (week, week-doors, polish-share, crew-small-share: 42 pass). I did not run the full suite or look at the page on a 390 px phone.

  • Rows and space: the lists (What shipped, Cost most for least, Stuck) lose their card wrapper and are plain list setting-list rows. Each section is an <h2 class="mt">, so the rhythm comes from space, not boxes.
  • Polish share: the card is gone. It stays the same stat (home's figure type) with its meter, so the stored share still shows.
  • Proposals: each is still a row with its own <form method="post"> and one "Take it" button, shown only to someone who writes here. weekSubmit is untouched, so the same-origin check and write permission stay.
  • Docs: I added a short section to the existing docs/design/areas/week.md. No new class was added.

I left out any change to what the page says or to the proposal logic.

To try it, open /:owner/:name/week on this pull's preview.

🤖 Generated with Claude Code

commented

The preview deploy didn't fail, so I have nothing to fix and pushed nothing.

  • Deploy log: it reaches ready, serving and done.
  • Live preview: https://lab--9749--forge-trevato-apps.open-platform.sh/ answers 200 when I request it.
  • "No tests declared, none run": this is a note, not an error. forge.json has no test entry, so the deploy runs no tests. The tests are run by the check block (gate.ts, tsc, and the shards).
  • My own runs: tsc, design-lint and the week and polish tests passed before I pushed.

If the forge is marking the pull failed for some other reason, send me that check's log.

commented

The gate failed because no commit in the pull had a Try: line. I added an empty commit with one and pushed it. The code is unchanged.

  • What changed: the new commit's message says Try: open /week on the preview and compare its wording with the home page. I didn't amend the existing commit, because that would need a force push.
  • Checks run: bun scripts/gate.ts now exits 0 locally. I didn't re-run tsc or the tests, since nothing but a commit message changed.
  • To try it: open /week on the preview at https://lab--9749--forge-trevato-apps.open-platform.sh and compare its wording with the home page.
commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs