Public: anyone can read this; the crew can change it.

The commits list and a commit's page speak the home page's language #9748

Parked opened this
Closed without merging

The commits list and a commit's page no longer sit in cards. The commits tests (14), tsc --noEmit and bun scripts/design-lint.ts pass. I did not run the warm-list timing check on its own, but test/commits-timing.test.ts is one of the 14 passing tests.

Notes

stopped parked by the crew deploy 23cc6c0

opened this

The commits list and a commit's page no longer sit in cards. The commits tests (14), tsc --noEmit and bun scripts/design-lint.ts pass. I did not run the warm-list timing check on its own, but test/commits-timing.test.ts is one of the 14 passing tests. I did not call keep_plan or look at either page in a browser.

What changed (src/web/pages/commits.ts)

  • List: it is now a bare <ul class="list setting-list"> of rows instead of a card around a list. Every row is the same shape: avatar, the message as the row's one link to the commit, the author and time in muted text, and the short sha.
  • Checks: a commit with a check still shows its green or red badge beside it, linking to that run. Commits with no check show no badge, as before.
  • Commit page: the header card is gone. The subject is a heading, then the check sentence, the body, and a muted line with author, time, sha, merge badge and "Browse files". The diff below it is untouched and still scrolls inside its own .diff-body.
  • Escaping: messages, authors and bodies still go through the html helpers and messageText, so they are escaped as before.
  • Docs: the note in docs/design/areas/diff.md now says these pages draw no card. No new class was added.

Behaviour change: a row with no check used to be one whole-row link; it is now a div with the message as the link, so only the message is clickable. That follows the issue's "the message is the one link", but it is a smaller click target.

What I chose not to do: I left the history bar, the pager and the live-browse (other forge) pages as they were. They share the same renderers, so they get the new look as well.

To try it: open /<owner>/<repo>/commits, then click any commit. Run bun test test/commits*.test.ts.

Closes #9742

3 earlier comments
commented

The commits list and a commit's page no longer sit in cards. The commits tests (14), tsc --noEmit and bun scripts/design-lint.ts pass. I did not run the warm-list timing check on its own, but test/commits-timing.test.ts is one of the 14 passing tests. I did not call keep_plan or look at either page in a browser.

What changed (src/web/pages/commits.ts)

  • List: it is now a bare <ul class="list setting-list"> of rows instead of a card around a list. Every row is the same shape: avatar, the message as the row's one link to the commit, the author and time in muted text, and the short sha.
  • Checks: a commit with a check still shows its green or red badge beside it, linking to that run. Commits with no check show no badge, as before.
  • Commit page: the header card is gone. The subject is a heading, then the check sentence, the body, and a muted line with author, time, sha, merge badge and "Browse files". The diff below it is untouched and still scrolls inside its own .diff-body.
  • Escaping: messages, authors and bodies still go through the html helpers and messageText, so they are escaped as before.
  • Docs: the note in docs/design/areas/diff.md now says these pages draw no card. No new class was added.

Behaviour change: a row with no check used to be one whole-row link; it is now a div with the message as the link, so only the message is clickable. That follows the issue's "the message is the one link", but it is a smaller click target.

What I chose not to do: I left the history bar, the pager and the live-browse (other forge) pages as they were. They share the same renderers, so they get the new look as well.

To try it: open /<owner>/<repo>/commits, then click any commit. Run bun test test/commits*.test.ts.

commented

The preview didn't fail on anything in this change, so I pushed nothing new. The deploy log you sent ends with done, the app started, and ready was answered at https://lab--9748--forge-trevato-apps.open-platform.sh.

"No tests declared, none run" is a note about the deploy step, not an error. forge.json has no test command for deploys, and the tests run in the check section instead. I did not change forge.json or add a test command.

Before the first push I ran bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/commits*.test.ts, and all three passed. I did not run bun scripts/gate.ts or the full suite, so I can't say whether the forge's check is green. If that check failed, send me its log and I'll fix what it names.

commented

The commits list and a commit's page now render as rows, a heading and a muted line, with no cards. That change was already on the branch in src/web/pages/commits.ts; I haven't touched it in this round.

The failed check was only the gate rule asking for a "Try:" line in a commit message. I added an empty commit with that line and pushed. bun scripts/gate.ts now exits 0 locally. I didn't re-run tsc or the tests, since no code changed.

Try: open /commits and a commit's page on the preview at https://lab--9748--forge-trevato-apps.open-platform.sh. You should see plain rows, a heading and a muted line, with no cards.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs