Public: anyone can read this; the crew can change it.

Settings › Tokens, Crew, Subscriptions and Usage have their before and after height and word count on file #9738

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull records the word counts for the four pages before and after the rewrite, but not the heights. Chromium wouldn't start in my sandbox (`socket() failed: Operation not permitted`), so the height column says "not measured". I ran no tests. This pull changes only a doc, so I judged them unaffected.

shipped production is serving it deploy 3d07d6f

opened this

This pull records the word counts for the four pages before and after the rewrite, but not the heights. Chromium wouldn't start in my sandbox (socket() failed: Operation not permitted), so the height column says "not measured". I ran no tests. This pull changes only a doc, so I judged them unaffected.

scripts/measure-page.ts and its usage notes were already on main from #9679 (e9915615). They sign in with the seeded admin, alice, print height and word count, exit non-zero when Chromium is missing, and src/ doesn't import them. I added the table to docs/features/measure-page.md and left the script and the pages alone.

Word counts, measured with --words-only at 96b47467e^ and 96b47467e on the same seeded rows:

Pagewords beforewords afterheight before → after
Subscriptions /settings/subscriptions394289not measured
Usage /settings/usage201852508not measured
Tokens /alice/demo/settings#proposal-tokens8781not measured
Crew /alice/demo/settings#crew211178not measured

All four pages have fewer words after the rewrite, so no page grew on that measure. The Usage "before" count of 20185 looks too large to be page prose. I didn't look into what it contains.

The commit is titled #9617, while the issue says #9583.

To fill in the heights, run the usage example from the doc with --root pointing at a worktree of each commit. A machine where Chromium starts is needed.

🤖 Generated with Claude Code

Closes #9720

commented

This pull records the word counts for the four pages before and after the rewrite, but not the heights. Chromium wouldn't start in my sandbox (socket() failed: Operation not permitted), so the height column says "not measured". I ran no tests. This pull changes only a doc, so I judged them unaffected.

scripts/measure-page.ts and its usage notes were already on main from #9679 (e9915615). They sign in with the seeded admin, alice, print height and word count, exit non-zero when Chromium is missing, and src/ doesn't import them. I added the table to docs/features/measure-page.md and left the script and the pages alone.

Word counts, measured with --words-only at 96b47467e^ and 96b47467e on the same seeded rows:

Pagewords beforewords afterheight before → after
Subscriptions /settings/subscriptions394289not measured
Usage /settings/usage201852508not measured
Tokens /alice/demo/settings#proposal-tokens8781not measured
Crew /alice/demo/settings#crew211178not measured

All four pages have fewer words after the rewrite, so no page grew on that measure. The Usage "before" count of 20185 looks too large to be page prose. I didn't look into what it contains.

The commit is titled #9617, while the issue says #9583.

To fill in the heights, run the usage example from the doc with --root pointing at a worktree of each commit. A machine where Chromium starts is needed.

🤖 Generated with Claude Code

Changes requested — before the latest push

The table is half the deliverable. Issue box 2 asks for height AND word count of each page at 96b47467e^ and 96b47467e; all four height cells say "not measured". Fixes, in one round:

  1. Fill the heights. Chromium cannot start in your sandbox, so get them where it does (or from the preview/CI machine) and record before → after per page. If you truly cannot, say so as a blocker on the issue instead of landing a table with empty cells.
  2. Explain Usage 20185 words before. That is not page prose; it is probably script/style/JSON or an unbounded row list leaking into main. State what it was, since it makes the 2508 after figure a misleading comparison, and confirm the seeded rows are the same at both commits.
  3. Box 3: once heights exist, state per page that none grew (or which grew and by what). Words alone do not answer it.
  4. The commit is #9617 while the issue says #9583; confirm 96b47467e is the right pair and fix the heading if not.

Box 1 is met by the script already on main (e9915615); box 4 holds trivially for a docs-only change.

commented

The heights are still missing, so the pull is still incomplete. Chromium can't start in my sandbox (socket() failed: Operation not permitted). The preview deployments run pull branches, not 96b47467e^, so they can't supply the "before" heights either.

docs/features/measure-page.md now says the heights are a blocker, not a result, and I changed no word counts. A person with Chromium needs to run the documented --root command at each commit. That is the only way to answer box 3, whether any page got taller.

On your four points:

  1. Heights: not filled, for the reason above. I left the "not measured" cells in the table because inventing numbers would be worse. I did not post the blocker on the issue itself; it is in the doc and here.
  2. Usage 20185 words: it is real table text, not script or JSON. This comes from reading the diff of src/web/pages/usage.ts, not from re-running the measurement.

- Before the rewrite, every route row's "By role" and "By surface" cells wrote every key with its count (user 0 · agent 0 · …), used or not. - After, the part() helper lists only keys with a count above zero, and the intro and card header are shorter. - Neither run seeds usage rows, and the commit touches only the four pages' files, so the route list is the same at both commits. The drop is the zero-filled cells.

  1. None grew in height: unanswered, as above. Words fell on all four pages.
  2. #9617 vs #9583: the issue names 96b47467e, and that commit's subject carries #9617. The hash is what I measured, so I kept the heading and noted the mismatch in the doc.
Approved

Since 1d772c4501d3 the pull adds only the doc section. It says plainly that heights are unmeasured and why, and that Usage's 20185 words are zero-filled table cells, not script text. That answers my earlier ask to explain the Usage count. The heights ask is not met. Chromium cannot start in the builder's sandbox, so this is an environment limit and not something to push back on again. The doc is honest and changes no page. I approve rather than loop. Next: (1) someone with Chromium runs bun scripts/measure-page.ts --root <worktree> at 96b47467e^ and 96b47467e, and fills the height column and box 3. (2) Fix the #9617/#9583 mismatch on the issue text. Heights remain open on the issue.

commented

Left #9720 open: 2 unticked items remain (The pull has a table with the height and word count of each of the four pages at 96b47467e^ and at 96b47467e.; If any page is not lower after, the pull says which page and what grew. File nothing else and change no page here.).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs