Public: anyone can read this; the crew can change it.

Absorb: how it fits packs, flows/radar and forge-to-forge #9699

Parked opened this
Closed without merging

This pull covers the three checklist items from #9545, with one gap: I did not open issues on the map for the "Not done yet" items. tsc, scripts/gate.ts and scripts/design-lint.ts pass. 54 tests pass across packs, packs-up, packs-hands and features.

Notes

stopped parked by the crew deploy 23c22e9

opened this

This pull covers the three checklist items from #9545, with one gap: I did not open issues on the map for the "Not done yet" items. tsc, scripts/gate.ts and scripts/design-lint.ts pass. 54 tests pass across packs, packs-up, packs-hands and features. I did not run the full suite; the forge's check does that on push.

What changed

  • Pack absorb.
    • PackApp.absorb?: boolean is parsed in src/packs/pack.ts, and a non-boolean value is refused. The key is not caught by the forbidden-key list.
    • deployPack in src/packs/deploy.ts adds an absorb <name> step after an app is made and its history carried. It runs for kept apps too, and only for apps with absorb: true.
    • The new Hands.absorb calls PUT /api/v1/features/:slug with the deploy token, so it is the deploying admin's act and records the usual app.absorbed event.
    • A refusal shows as a failed absorb step and the rest of the pack goes on.
    • The pack parser still refuses env, key and data.
  • Provenance. FeatureView gains forkOf and following. The Features row shows "Fork of owner/name" or "Not a fork", the upstream it follows, and "settings do not travel with a fork" when either applies. The page also now says an absorbed app is a menu link and typed settings for now, with no health or feed items yet.
  • Doc. docs/features/absorb.md has new "In a pack" and "On a fork" sections. "Not done yet" is now a list: schedule, feed items, MCP tools in /mcp, secret settings and health on /system.
  • Tests. There are three new tests in test/packs.test.ts and one in test/features.test.ts. The existing deploy test's Hands fake gained the new absorb method.

What I left out

  • "Who last changed the declaration": the forge stores no such data, so I did not add it to the row.
  • Issues on the map: the doc lists the not-done items, but I did not open issues or link them.
  • Absorb slug: Hands.absorb uses the pack app's name as the app slug, which matches the default slug for pack-style names.

To try it Add "absorb": true to an app in a pack.json whose repository declares a feature, then deploy with an admin-scope token. /settings/features shows the new provenance line.

🤖 Generated with Claude Code

Closes #9545

3 earlier comments
commented

This pull covers the three checklist items from #9545, with one gap: I did not open issues on the map for the "Not done yet" items. tsc, scripts/gate.ts and scripts/design-lint.ts pass. 54 tests pass across packs, packs-up, packs-hands and features. I did not run the full suite; the forge's check does that on push.

What changed

  • Pack absorb.
    • PackApp.absorb?: boolean is parsed in src/packs/pack.ts, and a non-boolean value is refused. The key is not caught by the forbidden-key list.
    • deployPack in src/packs/deploy.ts adds an absorb <name> step after an app is made and its history carried. It runs for kept apps too, and only for apps with absorb: true.
    • The new Hands.absorb calls PUT /api/v1/features/:slug with the deploy token, so it is the deploying admin's act and records the usual app.absorbed event.
    • A refusal shows as a failed absorb step and the rest of the pack goes on.
    • The pack parser still refuses env, key and data.
  • Provenance. FeatureView gains forkOf and following. The Features row shows "Fork of owner/name" or "Not a fork", the upstream it follows, and "settings do not travel with a fork" when either applies. The page also now says an absorbed app is a menu link and typed settings for now, with no health or feed items yet.
  • Doc. docs/features/absorb.md has new "In a pack" and "On a fork" sections. "Not done yet" is now a list: schedule, feed items, MCP tools in /mcp, secret settings and health on /system.
  • Tests. There are three new tests in test/packs.test.ts and one in test/features.test.ts. The existing deploy test's Hands fake gained the new absorb method.

What I left out

  • "Who last changed the declaration": the forge stores no such data, so I did not add it to the row.
  • Issues on the map: the doc lists the not-done items, but I did not open issues or link them.
  • Absorb slug: Hands.absorb uses the pack app's name as the app slug, which matches the default slug for pack-style names.

To try it Add "absorb": true to an app in a pack.json whose repository declares a feature, then deploy with an admin-scope token. /settings/features shows the new provenance line.

🤖 Generated with Claude Code

commented

The check failed because no commit message had a "Try:" line. I added an empty commit with one and pushed it. Locally bun scripts/gate.ts printed nothing after the commit, and I did not re-run the other checks because the new commit changes no files.

To try the work on the preview, open /settings/features as a site admin. Under each app you'll see "Fork of owner/name" or "Not a fork". If the app follows an upstream, its address and branch follow. When the app is a fork or follows one, the line also says settings do not travel with a fork.

The rest of the pull is unchanged:

  • Packs: a pack app may carry "absorb": true, and deploying the pack absorbs it as the deploying admin, with the usual app.absorbed event.
  • Features page: it now says an absorbed app is a menu link and typed settings for now.
  • Doc: docs/features/absorb.md has new "In a pack" and "On a fork" sections.
  • Left out: the doc lists the "Not done yet" items, but I did not open issues on the map for them. The forge stores no record of who last changed a declaration, so the row does not show that.

🤖 Generated with Claude Code

commented

The preview deploy failed because main had moved and the branch conflicted with it in src/actions/features.ts, src/web/pages/features.ts and test/features.test.ts. I never saw the deploy log, so that is an inference from the pull's mergeable: false and its conflict list, not a confirmed cause.

I merged main into the branch and resolved the three conflicts, keeping both sides:

  • src/actions/features.ts: main's new declaresFeature plus my forkOf and following helpers.
  • src/web/pages/features.ts: my note under the Features list that an absorbed app is a menu link and typed settings for now. It still links to the docs.
  • test/features.test.ts: both imports (declaresFeature and listFeatures).

After the merge, tsc and scripts/gate.ts pass. test/features.test.ts and test/packs.test.ts pass with 36 tests and 0 failures. I pushed the merge commit, which carries a Try: line.

To try it, open /settings/features as a site admin on the preview. Each app row names its fork parent and the upstream it follows.

If the deploy still fails, I'll need its log.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs