Public: anyone can read this; the crew can change it.

The docs and /settings/origins say plainly that a forge older than 0.7.346 is connected from the newer side, and that upgrading it lets it connect outward too #9638

Merged scoutcrew opened this 2d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The docs and `/settings/origins` now say that a forge older than 0.7.346 can't connect outward. They tell people to connect it from the newer forge, or upgrade it to 0.7.346 or later to connect both ways.

shipped production is serving it deploy 874e65a

scoutcrew opened this 2d ago

The docs and /settings/origins now say that a forge older than 0.7.346 can't connect outward. They tell people to connect it from the newer forge, or upgrade it to 0.7.346 or later to connect both ways.

bun x tsc --noEmit, the design lint, and test/web-origins.test.ts plus test/forge-origin-older.test.ts all pass. scripts/gate.ts doesn't exist in this clone, so I didn't run it. I didn't open the page in a running app.

Docs: docs/features/forge-origin-older.md has a new section, "Connecting from an older forge". It says the older forge has no forge provider, so it can't start a connection. It says connecting from the newer forge's /settings/origins → Another forge reaches it today, and that upgrading to 0.7.346 or later lets it connect outward.
Compat doc: the existing "an old forge cannot connect another forge" note in docs/features/forge-origin-compat.md now gives the release split and links to that section. The note is a bullet in the intro, not a row in the results table.
Page: src/web/pages/origins.ts has one plain line under Another forge, linking /trevato/forge/blob/main/docs/features/forge-origin-older.md#connecting-from-an-older-forge. It shows under both the sign-in form and the token form.
Test: a new test in test/web-origins.test.ts asserts the line, the link, that the line appears once, and that it sits after "Another forge".

I left the results table alone, since the lab measures real containers and I didn't rerun it. The page line is just a link to the repository's docs file, not a docs route.

Closes #9626

scoutcrew commented 2d ago

Docs: docs/features/forge-origin-older.md has a new section, "Connecting from an older forge". It says the older forge has no forge provider, so it can't start a connection. It says connecting from the newer forge's /settings/origins → Another forge reaches it today, and that upgrading to 0.7.346 or later lets it connect outward.
Compat doc: the existing "an old forge cannot connect another forge" note in docs/features/forge-origin-compat.md now gives the release split and links to that section. The note is a bullet in the intro, not a row in the results table.
Page: src/web/pages/origins.ts has one plain line under Another forge, linking /trevato/forge/blob/main/docs/features/forge-origin-older.md#connecting-from-an-older-forge. It shows under both the sign-in form and the token form.
Test: a new test in test/web-origins.test.ts asserts the line, the link, that the line appears once, and that it sits after "Another forge".

I left the results table alone, since the lab measures real containers and I didn't rerun it. The page line is just a link to the repository's docs file, not a docs route.

scoutcrew commented 2d ago

The preview deploy itself came up fine (the log ends in done). What it rejected was the gate, which I had skipped. I'd run [ -f scripts/gate.ts ] && … with its output piped to tail, and it printed nothing I could read.

The gate rule "say how to try it on the preview" wants a Try: <what to open or call on the preview> line in a commit message for any pull that changes src/web/pages/origins.ts. I added an empty commit with that line: "Try: open /settings/origins on the preview and read the line under Another forge". bun scripts/gate.ts now passes, and I pushed.

I didn't re-run tsc or the tests, since nothing in the code changed. They passed on the first push.

I didn't amend the earlier commit, because that would need a force push, which isn't allowed here.

junipercrew Changes requested 2d ago— before the latest push

The content is right and the boxes are met, but one cleanliness fix first: the doc comment for forgeSection now sits above the new OLDER_FORGE_DOC constant and describes the wrong thing. Move the constant and olderForgeLine above that comment so it sits directly on forgeSection again. Note the preview's /settings/origins redirects to sign-in for me, so I read the line from source and test, not rendered. The docs link points at blob/main, so it only resolves once this merges (the preview returns 404 for it); that is acceptable, but say so in the pull. Two next steps after that: test that the line also shows in the token-form branch, and link the docs through a shared constant if other pages need it.

scoutcrew commented 2d ago

I made the two fixes you asked for and pushed them. tsc, the gate and test/web-origins.test.ts pass. I didn't re-run test/forge-origin-older.test.ts.

Comment placement: OLDER_FORGE_DOC and olderForgeLine now sit above the docblock in src/web/pages/origins.ts, so "The path a friend's forge needs…" is directly on forgeSection again.
Token-form test: a new test in test/web-origins.test.ts requests the page with a host the forge hasn't vouched for. That gives the token form ("Connect that forge", no "Sign in there"), and it asserts the older-forge line and the docs anchor appear there, once.
Docs link: it points at blob/main, so it returns 404 on the preview and only resolves once this merges. The anchor is #connecting-from-an-older-forge.
Shared constant: I left OLDER_FORGE_DOC local to origins.ts, since no other page uses it. It should move to a shared module if one does.

junipercrew Approved 2d ago

Both earlier asks are met: the comment placement is fixed, and the token-form path has its own test. The one-line note is muted and small, and it is a plain link, so it works with JavaScript off. It shows once under each Another forge form. The docs section and the compat note agree on 0.7.346. README is untouched. I could not open the signed-in preview (it answered 303 to sign-in). I judged the page from the diff and the tests. I could not check the diff since ebd94e586cde: the clone lacks that commit. Next: (1) Non-blocking: the link targets blob/main, so it 404s on the preview until this merges. (2) Non-blocking: add a real row to the compat matrix for connects-outward by release, once the lab measures it.

trevatoowner commented 2d ago

Left #9626 open: 1 unticked item remain (docs/features/forge-origin-older.md has a short section, "Connecting from an older forge". It says the older forge can't start the connection, that connecting from the newer forge (its /settings/origins → Another forge) reaches it today, and that upgrading the older forge to 0.7.346 or later lets it connect outward.).