Public: anyone can read this; the crew can change it.
The signed-in home speaks the public home page's language, with looks before and after #9610
The signed-in home now follows the opening principles in docs/DESIGN.md, but the before/after looks the issue asks for are not on this pull. I have no browser in this sandbox to take screenshots at 1440 and 390, light and dark. The preview for this pull is the place to take them.
stopped parked by the crew deploy 6eac3e7
3 earlier comments
The signed-in home now follows the opening principles in docs/DESIGN.md, but the before/after looks the issue asks for are not on this pull. I have no browser in this sandbox to take screenshots at 1440 and 390, light and dark. The preview for this pull is the place to take them.
What I ran:
- Passing:
design-lint,tsc --noEmit,scripts/gate.ts, and the home tests (home-living,home-feed,studio,home-fit,client-home,first-login,page-text,home-frame). - Not run:
scripts/fast.tssays the change reaches 1441 test files, so I picked the home tests myself.
All the changes are in src/web/studio/living.ts. No section or slot was added or removed, so first paint is still server-rendered, and home-frame (the home's speed and swap-in checks) passes. Only the markup inside each section changed, so any layout shift is unmeasured until the looks are taken.
- Tell box: it keeps one button, Tell. Notes and Talk move to a muted line of links under it (principles 4, 5).
- Your apps: the strip of buttons becomes plain links: your apps, "New app", and "All N" when there are more than 12 (principles 5, 7).
- Being built / Just shipped: these are now a hairline-free
ul.listof rows instead of a boxed card (principles 6, 7).
I added a test in test/home-living.test.ts that fails on the old markup.
I left out the long-form yourApps rail (it isn't on this home path), the ?all=1 lean variant, and the other four pages from #9433. I touched nothing outside the signed-in home.
The deploy didn't fail on anything in my change, so I made no fix and pushed nothing.
The log shows the app starting, answering and serving at the preview URL, and ending with done. The line "no tests declared, none run" only means forge.json has no app.test entry. In this repo the tests belong to the check block, which the forge runs on each push. That block hasn't changed.
Before my push I ran tsc --noEmit, scripts/gate.ts, design-lint and the home tests, and all passed. I haven't seen a verdict from the forge's own check. If it reports a failure, send me its log and I'll fix it.
The gate failed because no commit message in the pull had a Try: line. I pushed an empty commit that adds one. The code is unchanged, so I did not re-run the tests, the type check or the gate here, and I have not seen the forge's check result for the new push.
The line reads: "Try: open the preview home signed in and check the tell box has one button, apps are plain links, and lists are rows".
The pull still changes the signed-in home. The tell box now has a single button, apps show as plain links, and lists that move show as rows.
To try it, sign in on https://lab--9610--forge-trevato-apps.open-platform.sh and open /.
Parked by the crew: the check stayed red through 2 automatic tries
The signed-in home now follows the opening principles in
docs/DESIGN.md, but the before/after looks the issue asks for are not on this pull. I have no browser in this sandbox to take screenshots at 1440 and 390, light and dark. The preview for this pull is the place to take them.What I ran:
design-lint,tsc --noEmit,scripts/gate.ts, and the home tests (home-living,home-feed,studio,home-fit,client-home,first-login,page-text,home-frame).scripts/fast.tssays the change reaches 1441 test files, so I picked the home tests myself.All the changes are in
src/web/studio/living.ts. No section or slot was added or removed, so first paint is still server-rendered, andhome-frame(the home's speed and swap-in checks) passes. Only the markup inside each section changed, so any layout shift is unmeasured until the looks are taken.ul.listof rows instead of a boxed card (principles 6, 7).I added a test in
test/home-living.test.tsthat fails on the old markup.I left out the long-form
yourAppsrail (it isn't on this home path), the?all=1lean variant, and the other four pages from #9433. I touched nothing outside the signed-in home.Closes #9584