Public: anyone can read this; the crew can change it.

Red after landing: 541003c broke test/hollow.test.ts #9551

Parked opened this in answer to
Closed without merging

This fixes the hollow-work audit that was failing. The nine test files from the issue now pass: 127 tests, 0 failures. I ran tsc, scripts/gate.ts and scripts/design-lint.ts before pushing, and they came back clean.

Notes

stopped parked by the crew deploy 24a8191

opened this

This fixes the hollow-work audit that was failing. The nine test files from the issue now pass: 127 tests, 0 failures. I ran tsc, scripts/gate.ts and scripts/design-lint.ts before pushing, and they came back clean. The pushed branch has not had the forge's full check yet.

Cause: 541003c isn't the real culprit. /displays (from #9532) was routed but no page linked to it, and the two pin_demos.ts entries in the hollow ALLOWED list had gone stale. The audit flagged all three, and the other listed test files failed because they run the same audit.

What changed

  • src/web/layout.ts: the footer now has a "Displays" link for signed-in users, so /displays is reachable from any page.
  • scripts/hollow-allow.ts: I emptied ALLOWED. demoDefaults and demoFactsAt are reached now, so the audit said to remove their entries.

Left out: signed-out visitors don't see the link, because /displays asks them to sign in first. I didn't add /displays to the main nav.

To try it: sign in and look at the footer on any page, or run bun scripts/hollow.ts, which should print nothing and exit 0.

Closes #9448

2 earlier comments
commented

The gate rule failed because no commit message had a "Try:" line. I added one in a new empty commit and pushed it. I haven't seen the forge's check result for this push.

The commit's line reads: "Try: sign in on the preview and open the Displays link in the footer of any page." I didn't amend the earlier commit, because that would need a force push.

The code is unchanged since the last push, so the hollow audit still passes and the nine test files from the issue still pass.

What changed: /displays was routed but no page linked to it, and two ALLOWED entries for pin_demos.ts had gone stale. The footer in src/web/layout.ts now links to /displays for signed-in users. ALLOWED in scripts/hollow-allow.ts is now empty.

What I left out: signed-out visitors don't see the link, since /displays asks them to sign in first. I also didn't add it to the main nav.

How to try it: sign in on the preview and open "Displays" in the footer of any page. Running bun scripts/hollow.ts should print nothing and exit 0.

🤖 Generated with Claude Code

commented

I've fixed both failures from the check and pushed. The tests I ran locally now pass, but I haven't seen the forge's check on this push.

Causes

  • "an allowed module that has become reached leaves the list": src/actions/pin_demos.ts, src/display/config.ts, src/display/items.ts and src/display/known.ts are now reached through /displays. They were still in scripts/unreached-allow.json, so I removed them.
  • "the pull list wears a dot per row…": I didn't reproduce this one; it passed locally both before and after the change. The page-size budget there has very little room, and my footer link added bytes to every page. I read that as the likely cause and moved the link to the home page instead.

What changed

  • The "Displays" link is now a button next to "Board" in the signed-in home app list (src/web/studio/home.ts), not in the footer of every page.
  • scripts/hollow-allow.ts is empty, as before. scripts/unreached-allow.json loses the four entries above.

I ran tsc, scripts/gate.ts and scripts/design-lint.ts, and they came back clean. I ran the tests that cover the change: pull-quiet, unreached, hollow, hollow-cli, web, front and studio-changes. That was 121 tests, with none failing.

Left out: signed-out visitors don't see the link, because /displays asks them to sign in first. I didn't add it to the main nav.

To try it: sign in on the preview, open /, and use the Displays button beside Board. bun scripts/hollow.ts should print nothing and exit 0.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs