Public: anyone can read this; the crew can change it.

Full suite red: test/hollow-cli.test.ts #9550

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

mason/forge:mason/9446-full-suite-red-test-hollow-cli-test-ts → main 6 commits fork 2 threads · 2 unresolved

  • Merged. mason/9446-full-suite-red-test-hollow-cli-test-ts was merged into main as b861e93.

Review

Sign in to review this change.
4 files changed +5 −2
src/web/icons.ts +1
@@ -103,6 +103,7 @@ const PATHS = {
103103 ban: `<circle cx="12" cy="12" r="10"/><path d="m4.9 4.9 14.2 14.2"/>`,
104104 circleX: `<circle cx="12" cy="12" r="10"/><path d="m15 9-6 6"/><path d="m9 9 6 6"/>`,
105105 terminal: `<path d="m4 17 6-6-6-6"/><path d="M12 19h8"/>`,
106 monitor: `<rect width="20" height="14" x="2" y="3" rx="2"/><path d="M8 21h8"/><path d="M12 17v4"/>`,
106107 } as const;
107108
108109 export type IconName = keyof typeof PATHS;
src/web/layout.ts +1
@@ -295,6 +295,7 @@ function userMenu(
295295 { label: "Talk", href: "/talk", icon: "comment" },
296296 { label: "Explore", href: "/explore", icon: "search" },
297297 { label: "Packs", href: "/packs", icon: "rocket" },
298 { label: "Displays", href: "/displays", icon: "monitor" },
outdated

Icon map is the same as the Map entry on the next line. Give Displays its own glyph.

298299 { label: "Map", href: "/map", icon: "map" },
299300 ...featureItems(ctx, user),
300301 { separator: true, label: "" },
test/pull-quiet.test.ts +2 −2
@@ -66,8 +66,8 @@ afterAll(async () => {
6666 const get = async (path: string) => (await fetch(`${servers.url}${path}`, { headers: { cookie } })).text();
6767 const bytes = (t: string) => new TextEncoder().encode(t).length;
6868
69 // Measured 30,889 and 24,540 (before: 31,622 on main with #8800, 31,968 before #8773 and 24,738). The margin covers the port digits and times in the page (up to ~160 B seen), so it holds the page from growing, not a tighter squeeze.
70 const BUDGET = { pull: 31_100, list: 24_900 };
69 // Measured 31,084 (pull) and 25,064 (list) with the Displays entry in the account menu and palette. Each budget is that plus ~160 B, the spread the port digits and times in the page showed, so it holds the page from growing and is not a tighter squeeze.
70 const BUDGET = { pull: 31_250, list: 25_230 };
outdated

Budget raised by 300 B for the pull page with no measurement. Measure, then set measured + ~160 B margin; the list budget likewise.

7171
7272 test("the pull page's check is a line with a dot and its word, not a card around a badge", async () => {
7373 const text = await get(`/alice/r/pulls/${number}`);

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs