Public: anyone can read this; the crew can change it.
The held page is one of the looks a check takes, as a visitor and as the owner #9494
The held page, /preview-admin/sample/held, is now one of the looks a check takes, both as a visitor and as the owner. I haven't been able to tell why the earlier check went red. I pushed the branch after merging current main into it.
stopped parked by the crew deploy 4498749
3 earlier comments · 1 event
The held page, /preview-admin/sample/held, is now one of the looks a check takes, both as a visitor and as the owner. I haven't been able to tell why the earlier check went red.
I pushed the branch after merging current main into it. Locally, bun scripts/gate.ts and bun x tsc --noEmit pass. The looks, manifest and design-audit tests pass except four failures that come from this sandbox. Two are chromium looks that can't open its socket here, one is a scaffold typecheck that can't write to the tempdir, and the fourth is the dark-capture look, which I assume is the same chromium limit. The full check will show whether any of the four fails there too.
What changed
forge.json:app.looksandapp.looksAsOwnerboth list/preview-admin/sample/held. That makes 24 visitor looks, which is exactlyLOOKS_MAXinsrc/apps/manifest.ts. I did not raise the cap; a first attempt to raise it to 25 was reverted.- To make room,
/auditgives up its picture. It is now listed intest/forge-looks.test.tsas having no look, with the reason that the cap of 24 is spent. The page is still covered by its own tests. test/preview-looks.test.ts: a new test readsforge.jsonand asserts both lists hold the held page. The existing seeded-held-page test now also asserts the preview seed has at least one held item, so the seed needed no change.
Left out
- I did not raise the 24-look cap.
- I did not touch the seed.
To try it
- Run
bun test test/preview-looks.test.ts test/forge-looks.test.ts. - On the preview, the check now includes the held page in its looks.
I changed no code for this failure. I pushed an empty commit to re-run the check, because I think both failures were flaky tests, not caused by this pull.
tui-crawlers("the screen shows the share…"): it passes when I run it alone here.boot-beside-peer("healthz answers within 1 s…"): this one waits on a 1 s timing window while a peer boots. It failed after 32 s in a shard under heavy parallel load. I did not run it here.- This pull's own tests:
test/preview-looks.test.tsandtest/forge-looks.test.tspass. They cover the one real change, which puts the held page,/preview-admin/sample/held, inforge.json'slooksandlooksAsOwner. To stay within the 24-look limit it also drops/auditfromlooks. - If the re-run fails again: a second failure of the same two tests would mean they are not flaky, and I'd look at them properly.
Not run here: the full suite, scripts/gate.ts and tsc. I did not run them on this push because nothing in the code changed.
This push fixes the boot stall that the failing check, "healthz answers within 1 s … beside a draining forge's batch of 8", exercises. I haven't seen the forge's verdict on this push yet.
- Cause:
serve()rancloseStaleSessions, a write tomachine_sessions, beforewaitForPeer. While an old forge still held the database write lock, that write blocked the new forge's event loop, so/healthzstalled. - Fix:
src/main.tsnow runscloseStaleSessionsafterwaitForPeer, once the old forge has let go of the lock.closeStaleSessionsinsrc/machines/shell.tstakes abootedAtand closes only rows started before it. A session this forge opened while it waited stays open. - Test change:
test/machine-shell.test.tsrelied onserve()closing the stale row. It now callscloseStaleSessionsitself, and the unit test passes a futurebootedAt. - Checks run here:
test/machine-shell.test.tspasses (15 tests),tscis clean, andtest/boot-beside-peer.test.tspassed on four local runs, three of them in parallel. I ran no other suites here. The earlier failure didn't reproduce locally, so I couldn't watch the fix change a failing run. - Gate script: I ran
bun scripts/gate.tsin the same command astscandgrep, and I didn't read its output. Treat it as unconfirmed. - Slip: my first push of the
main.tsfix went out whiletest/machine-shell.test.tswas still red, because a&&chain ignored the failure. The second commit fixed it.
Parked by the crew: the check stayed red through 2 automatic tries
The held page,
/preview-admin/sample/held, is now one of the looks a check takes, both as a visitor and as the owner. I haven't been able to tell why the earlier check went red.I pushed the branch after merging current
maininto it. Locally,bun scripts/gate.tsandbun x tsc --noEmitpass. The looks, manifest and design-audit tests pass except four failures that come from this sandbox. Two are chromium looks that can't open its socket here, one is a scaffold typecheck that can't write to the tempdir, and the fourth is the dark-capture look, which I assume is the same chromium limit. The full check will show whether any of the four fails there too.What changed
forge.json:app.looksandapp.looksAsOwnerboth list/preview-admin/sample/held. That makes 24 visitor looks, which is exactlyLOOKS_MAXinsrc/apps/manifest.ts. I did not raise the cap; a first attempt to raise it to 25 was reverted./auditgives up its picture. It is now listed intest/forge-looks.test.tsas having no look, with the reason that the cap of 24 is spent. The page is still covered by its own tests.test/preview-looks.test.ts: a new test readsforge.jsonand asserts both lists hold the held page. The existing seeded-held-page test now also asserts the preview seed has at least one held item, so the seed needed no change.Left out
To try it
bun test test/preview-looks.test.ts test/forge-looks.test.ts.Closes #9488