Public: anyone can read this; the crew can change it.

The held page is one of the looks a check takes, as a visitor and as the owner #9491

Parked opened this
Closed without merging

/preview-admin/sample/held is now in both app.looks and app.looksAsOwner in forge.json, so a check measures the held phone look as a visitor and as the owner. It adds one path to each list, so the preview check takes a few seconds longer. I did not touch src/spawn/preview-seed.ts.

Notes

stopped parked by the crew

opened this

/preview-admin/sample/held is now in both app.looks and app.looksAsOwner in forge.json, so a check measures the held phone look as a visitor and as the owner. It adds one path to each list, so the preview check takes a few seconds longer.

I did not touch src/spawn/preview-seed.ts. The preview seed already holds 24 issues across 8 themes, so the page has items to render.

I put the new test in test/preview-looks.test.ts, beside the existing held-page tests. It reads forge.json and asserts both lists contain the held page. The existing test in that file already renders the page against the seed and expects a 200. I added an assertion that the page has at least one theme.

That last assertion checks themes, not individual issues, because the review's theme type has no issue list to count. A held page with themes necessarily has held issues, so it covers the same ground.

bun test test/preview-looks.test.ts passes (3 tests), bun x tsc --noEmit is clean, and bun scripts/gate.ts printed nothing. I didn't check its exit code, so I can't confirm it passed.

To try it, open a preview of this pull and look at /preview-admin/sample/held.

Closes #9488

3 earlier comments
commented

/preview-admin/sample/held is now in both app.looks and app.looksAsOwner in forge.json, so a check measures the held phone look as a visitor and as the owner. It adds one path to each list, so the preview check takes a few seconds longer.

I did not touch src/spawn/preview-seed.ts. The preview seed already holds 24 issues across 8 themes, so the page has items to render.

I put the new test in test/preview-looks.test.ts, beside the existing held-page tests. It reads forge.json and asserts both lists contain the held page. The existing test in that file already renders the page against the seed and expects a 200. I added an assertion that the page has at least one theme.

That last assertion checks themes, not individual issues, because the review's theme type has no issue list to count. A held page with themes necessarily has held issues, so it covers the same ground.

bun test test/preview-looks.test.ts passes (3 tests), bun x tsc --noEmit is clean, and bun scripts/gate.ts printed nothing. I didn't check its exit code, so I can't confirm it passed.

To try it, open a preview of this pull and look at /preview-admin/sample/held.

commented

The held page is now one of the looks a check takes, as a visitor and as the owner. I fixed the failed check and pushed again, and I have not seen the forge's verdict on the new push. The check log you sent ended at the check command with no error shown, so I reproduced the failure locally.

  • Looks: forge.json lists /preview-admin/sample/held in both app.looks and app.looksAsOwner.
  • Cause of the failure: that added a 25th path to app.looks, and the manifest allowed at most 24. It made forge.json fail to parse, which broke test/forge-looks.test.ts and test/looks-owner.test.ts.
  • Fix: I raised the cap to 25 in LOOKS_MAX (src/apps/manifest.ts) and updated the limit in docs/APPS.md and in the two tests that pin it (test/apps-adversarial.test.ts, test/forge-looks.test.ts).
  • Trade-off: I raised the cap rather than drop an existing look, because the issue asks for both lists and each look costs a browser start. That makes the preview check a few seconds longer.
  • Tests: test/preview-looks.test.ts asserts that both lists hold the held page. It also renders the page against the preview seed as a 200 with at least one theme. The seed already holds 24 issues in 8 themes, so src/spawn/preview-seed.ts is untouched.

bun x tsc --noEmit is clean and bun scripts/gate.ts exits 0. The looks, owner-looks, preview-looks and adversarial test files pass. I did not run the rest of the fast tier, so I can't rule out that another test reads forge.json and trips on the change.

To try it, open the preview of this pull and look at /preview-admin/sample/held.

commented

The held page is now in both app.looks and app.looksAsOwner, and app.looks stays at 24 paths. To fit it, I dropped /audit from app.looks. I've pushed that, but I haven't seen the forge's verdict on the new push.

The log you sent was cut off before the failing line, so I read the failed deploy on the previous head from the pull's checks API. It said forge.json: app.looks may name at most 24 paths. The forge that deploys a preview parses forge.json with its own running code. That code still caps app.looks at 24, so raising the cap in this pull could never have passed. I reverted that change, along with its test and doc edits.

/audit had to be the one to go because app.looksAsOwner can only name pages that app.looks also names, so I needed a visitor-only page. /audit is a top-level page, so test/forge-looks.test.ts expects every top-level page to be either looked at or listed with a reason in its NOT_A_PAGE table. I added /audit there, with the reason the cap went to /held. /audit is no longer pictured by any check. If you'd rather lose a different look, swap the one entry in app.looks and the matching NOT_A_PAGE line.

The forge.json test and the seeded-held-page test in test/preview-looks.test.ts are unchanged and pass. bun x tsc --noEmit is clean and bun scripts/gate.ts exits 0. test/forge-looks.test.ts, test/looks-owner.test.ts and test/preview-looks.test.ts pass (30 tests). Earlier, test/looks.test.ts had 3 failures in the real-chromium capture tests. This change doesn't touch that code, and I didn't re-run them on a clean main. I did not run the full fast tier, so I can't rule out a failure in a shard I didn't reach.

To try it, open the preview of this pull and look at /preview-admin/sample/held.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs