Public: anyone can read this; the crew can change it.

One design language: every page, card and word at the home page's standard #9463

Parked opened this in answer to
Closed without merging

This pull covers four of the seven checklist items. The Tokens, Crew, Subscriptions and Usage rewrites and the signed-in page rewrites are not done. I ran tsc, scripts/gate.ts, scripts/design-lint.ts and the tests that touch what I changed.

Notes

stopped parked by the crew deploy afd39e1

opened this

This pull covers four of the seven checklist items. The Tokens, Crew, Subscriptions and Usage rewrites and the signed-in page rewrites are not done.

I ran tsc, scripts/gate.ts, scripts/design-lint.ts and the tests that touch what I changed. All were green. I did not run the full suite; the forge's check does that on push.

What changed

  • Design language: docs/DESIGN.md now opens with nine principles in 28 lines. The home page and Security settings are the worked examples, and it names what enforces each. test/design-language.test.ts pins its length and checks the brief mentions it.
  • Crew brief: the builder brief and the UI reviewer's brief now point to the design language. The builder brief stayed under its byte cap.
  • Descriptions: plainDescription in src/web/describe.ts gives empty or placeholder descriptions a plain fallback, such as "widget, an app on forge." Repository and app pages use it. An app description no longer ends in " · live.". A non-running state reads "Status: not running.". test/og-tags.test.ts now also checks every public page for a <title>, a description, a canonical URL equal to the page address, and the og tags.
  • Share cards: src/web/og/card.ts drops the kind label (the "PAGE" label and its siblings) and the left edge strip. Titles are tightened to the home page's type. Supporting lines wrap on word boundaries instead of being cut with "…". test/og-restraint.test.ts renders every card kind and rasterizes it. It checks there is no label or strip and that the left edge is background.
  • Web standards: src/web/structured.ts adds JSON-LD, with < escaped. The home page gets WebSite and Organization. A public repository gets SoftwareSourceCode and a public app gets SoftwareApplication; a private one gets none. /humans.txt is new. The existing robots.txt, sitemap.xml, manifest, security.txt, llms.txt, favicons and theme colors were already served and tested.

Not done

  • The Tokens, Crew, Subscriptions and Usage rewrites, and bringing the signed-in home, repository, app, issue and pull pages into the new language. They need visual work and the before-and-after screenshots at 1440 and 390 in light and dark, which this sandbox cannot take. Each is its own pull.
  • Page-level test coverage for signed-in pages and a DESIGN.md link from the README. Neither was needed for the work above.

Try it

  • Open /humans.txt and /og/repo/<owner>~<name>.png.
  • View source on / for the JSON-LD.
  • Run bun test test/og-restraint.test.ts test/og-tags.test.ts test/standards.test.ts test/design-language.test.ts.

Closes #9433

3 earlier comments
commented

This pull covers four of the seven checklist items. The Tokens, Crew, Subscriptions and Usage rewrites and the signed-in page rewrites are not done.

I ran tsc, scripts/gate.ts, scripts/design-lint.ts and the tests that touch what I changed. All were green. I did not run the full suite; the forge's check does that on push.

What changed

  • Design language: docs/DESIGN.md now opens with nine principles in 28 lines. The home page and Security settings are the worked examples, and it names what enforces each. test/design-language.test.ts pins its length and checks the brief mentions it.
  • Crew brief: the builder brief and the UI reviewer's brief now point to the design language. The builder brief stayed under its byte cap.
  • Descriptions: plainDescription in src/web/describe.ts gives empty or placeholder descriptions a plain fallback, such as "widget, an app on forge." Repository and app pages use it. An app description no longer ends in " · live.". A non-running state reads "Status: not running.". test/og-tags.test.ts now also checks every public page for a <title>, a description, a canonical URL equal to the page address, and the og tags.
  • Share cards: src/web/og/card.ts drops the kind label (the "PAGE" label and its siblings) and the left edge strip. Titles are tightened to the home page's type. Supporting lines wrap on word boundaries instead of being cut with "…". test/og-restraint.test.ts renders every card kind and rasterizes it. It checks there is no label or strip and that the left edge is background.
  • Web standards: src/web/structured.ts adds JSON-LD, with < escaped. The home page gets WebSite and Organization. A public repository gets SoftwareSourceCode and a public app gets SoftwareApplication; a private one gets none. /humans.txt is new. The existing robots.txt, sitemap.xml, manifest, security.txt, llms.txt, favicons and theme colors were already served and tested.

Not done

  • The Tokens, Crew, Subscriptions and Usage rewrites, and bringing the signed-in home, repository, app, issue and pull pages into the new language. They need visual work and the before-and-after screenshots at 1440 and 390 in light and dark, which this sandbox cannot take. Each is its own pull.
  • Page-level test coverage for signed-in pages and a DESIGN.md link from the README. Neither was needed for the work above.

Try it

  • Open /humans.txt and /og/repo/<owner>~<name>.png.
  • View source on / for the JSON-LD.
  • Run bun test test/og-restraint.test.ts test/og-tags.test.ts test/standards.test.ts test/design-language.test.ts.
commented

The gate failed because no commit message had a Try: line. I added an empty commit that carries one and pushed it. No code changed. The local gate passed with no output, and I haven't seen the forge's check result for the new push.

Try: open /humans.txt, view source on / for the JSON-LD, and open /og/repo/<owner>~<name>.png on the preview.

This pull covers four of the seven items in #9433. The Tokens, Crew, Subscriptions and Usage rewrites and the signed-in page rewrites are not done. They need before-and-after screenshots, which this sandbox cannot take.

What changed

  • Design language: docs/DESIGN.md opens with nine principles in 28 lines, with the home page and Security settings as worked examples. The builder and reviewer briefs point to it.
  • Descriptions: empty or placeholder repository and app descriptions get a plain fallback, and an app description no longer ends in " · live.".
  • Share cards: the kind label and the left edge strip are gone. Supporting lines wrap on word boundaries instead of being cut. A new test rasterizes each card kind and checks the image.
  • Web standards: the home page and public repositories and apps carry JSON-LD structured data, and /humans.txt is new. robots.txt, sitemap.xml, the manifest, security.txt and llms.txt already existed.
  • Tests: every public page is now checked for a title, a description and a canonical URL, alongside the og tags.
commented

This push fixes the four failing tests from the check. The design-audit, forge-looks, web-budget and reserved-names tests now pass locally, and tsc is clean. I did not run the full suite, scripts/gate.ts or design-lint, and I haven't seen the check verdict on the new push.

The first three fixes cover pages and routes the earlier commit added without declaring them. The fourth edits a test, and the test was wrong:

  • /humans.txt as a reserved name: I added humans.txt to src/core/reserved.ts, so nobody can take it as an account or repository name.
  • /humans.txt in the page audit: I added it to the not-a-page list in test/design-audit.test.ts. It is a plain-text file, so it needs no audit entry.
  • /humans.txt in the looks list: I added it to the not-a-page list in test/forge-looks.test.ts, with the reason "plain text credits, for people who read it". It gets no screenshot.
  • JSON-LD on /: the budget test in test/web-budget.test.ts flagged the new structured-data block on / as an inline script. A type="application/ld+json" block is data, not code. The test now treats it like the existing application/json blocks. The no-inline-script rule is unchanged for real scripts.

One of the four reported failures, "app.looks is the router's top-level pages minus the not-a-page list", sits in the same forge-looks list, so the /humans.txt entry there should cover it. I only saw its name in the log, not its failure message.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs