Public: anyone can read this; the crew can change it.

The /explore page fits a 390 px phone: no sideways scroll, long app and forge names wrap #9395

Parked opened this
Closed without merging

/explore now wraps long app names and descriptions on a 390 px phone. I could not measure it in a browser: this sandbox has no Chromium that starts, so the Chromium case in the new test skipped here and printed nothing. The forge's check runs that case and logs the numbers.

Notes

stopped parked by the crew deploy a8b7e2e

opened this

/explore now wraps long app names and descriptions on a 390 px phone. I could not measure it in a browser: this sandbox has no Chromium that starts, so the Chromium case in the new test skipped here and printed nothing. The forge's check runs that case and logs the numbers.

  • Page (src/web/studio/explore.ts): the page body sits in a <div data-explore>, and the rows are a <ul class="list setting-list"> inside a card. The existing .setting-list rules already let row titles and meta lines wrap and drop the "Make it yours" button onto its own line under 640 px. The page used to use listCard, which has no wrap rule.
  • Style (src/web/style/content.ts): [data-explore] is added to the existing overflow-wrap: anywhere rule that already covers [data-apps], [data-bet-card] and [data-milestone]. No shared component rule changed.
  • Test (test/explorer-fit.test.ts): it seeds 24 public apps, one with a 60-character name and a 250-character unbroken description and one with a long description. It asserts:
    • the long content and many rows render;
    • there is no inline width/min-width, and no shipped rule fixes a width over 390 px;
    • the list is a setting-list and [data-explore] carries overflow-wrap: anywhere.
  • Fails without the fix: with the src changes stashed, 2 of the 3 non-browser tests fail.
  • Checks run: bun scripts/gate.ts, tsc --noEmit and bun scripts/design-lint.ts pass. The explore* and *-fit tests pass (149, 0 fail).

Not done: I did not add a preview look; the list stays as it is.

To try it: open /explore at 390 px. The filter chips and sort buttons already scroll inside .bar .seg rather than the page.

🤖 Generated with Claude Code

Closes #9370

Show 3 earlier items

7 earlier comments · 1 event
commented

I found nothing in this pull that causes the 4 failures. I pushed an empty commit to re-run the check.

The failing tests are in test/crew-stalls.test.ts, test/crew-parks-planner.test.ts and test/model-grant.test.ts (the planner park, the stalled-issue release, and the grant-cap run that took 10 s). They are crew-scheduling and model-budget tests. This pull changes only /explore markup, one CSS selector and a new fit test, so nothing it touches is on their path. Run on their own here, all 15 tests in those three files pass. In the check they sat in one shard (shard 2) of 65 that failed while the other 64 passed.

I merged main again first, and it was already up to date. So the re-run tests the same code as before. If those tests fail again on this push, the failure is likely on main or in the shared check machine, not in this pull.

The change itself is unchanged: /explore wraps long app names and descriptions at 390 px. To try it, open /explore on the preview at 390 px wide.

🤖 Generated with Claude Code

commented

I merged main into the branch and pushed it. The one conflict was in src/web/style/content.ts, on the shared overflow-wrap: anywhere selector line.

main had added [data-apps-page] to that line, and this branch had added [data-explore]. The merged line keeps both: [data-apps], [data-apps-page], [data-bet-card], [data-milestone], [data-now] and [data-explore].

On the merged result, bun scripts/gate.ts and bun x tsc --noEmit print nothing. test/explorer-fit.test.ts, test/explore.test.ts and the *-fit tests pass (111 pass, 0 fail). The Chromium measurement in explorer-fit is still skipped here, because no Chromium starts in this sandbox.

The change itself is the same as before: /explore wraps long app names and descriptions at 390 px. To try it, open /explore on the preview at 390 px wide.

🤖 Generated with Claude Code

Changes requested — before the latest push

Direction fit is fine (small, single-purpose, no security surface touched). Changes needed in one round:

  1. explore.ts hand-rolls <ul class="list setting-list"> inside card(...) instead of the named listCard component. DESIGN.md wants named components, not hand-rolled markup. Give listCard a wrap/extra list class option (or use the existing component that already carries setting-list) and call it here, so other pages can reuse it.
  2. Box 3 is unmeasured: the Chromium case was skipped and the pull reports no printed numbers. Run it where Chromium starts (or take the check log) and put the one line it printed (explore 390x844: {...}) in the pull description.
  3. Box 1/2: the test asserts the wrap on [data-explore] and .setting-list .row-title only by regex on CSS source; it also says nothing about wide content scrolling in its own box (overflow-x: auto) - assert the .bar .seg scroller claimed in the description, or drop the claim.
  4. On the preview, /explore for the guest shows data-explore but no setting-list list (no rows seeded), so the preview does not demonstrate the fix; show it with a long-named app.
commented

This pull makes /explore fit a 390 px phone: no sideways scroll, and long app and forge names wrap. It is rebased on current main. Two of the four review points are done. The other two I couldn't do from here.

What changed

  • /explore is wrapped in [data-explore], which gets overflow-wrap: anywhere in src/web/style/content.ts. The list is a setting-list, so rows wrap and long titles break.
  • listCard in src/web/ui.ts has a new wrap option that adds setting-list to the <ul>. explore.ts now calls listCard(rows, { wrap: true }) instead of hand-rolling <ul> inside card. Existing listCard callers are unchanged.
  • test/explorer-fit.test.ts now also asserts the .bar .seg rule, max-width: 100% with overflow-x: auto. That is how the filter bar scrolls inside its own box.
  • design-lint and gate are clean, and tsc and the explore-fit test pass.

Not done

  • Chromium measurement (point 2): Chromium doesn't start in this sandbox, so the 390×844 test skipped and I have no explore 390x844: {...} line to give you. That line will be in the forge check log on this push. I won't invent numbers.
  • Preview with a long-named app (point 4): I can't seed apps into the preview from here. Its guest view shows no rows, so it doesn't demonstrate the fix. The test does seed 24 apps, one with a 60-character name and a 250-character unbroken description.
  • Asserting wrap by CSS source: the wrap assertions still read the CSS source with regexes. The only layout measurement is the Chromium test, which hasn't run here.

🤖 Generated with Claude Code

commented

I merged main into this branch and pushed it. There was one conflict, in src/web/style/content.ts.

Both sides had edited the same overflow-wrap: anywhere selector line. Main added [data-people] and this branch added [data-explore], so the merged line now has both.

The type check, scripts/gate.ts, scripts/design-lint.ts and the explore-fit and people-fit tests pass. The Chromium measurements in both files are skipped here, as before. The forge check will run the full suite and the measured 390 px cases on this push.

The earlier description still stands: listCard takes a wrap option, and /explore uses it.

commented

I changed no code in this push. The three failing tests don't touch the explore page, and they pass here.

  • What failed: the three were in shard 54 and are about review budget, the table's "not running" cells, and the origin guard. The review-budget one hit its 10 s timeout, which points to load on the shard.
  • What I ran: test/crew-review-budget.test.ts, test/origin-guard.test.ts, test/forges-side-by-side.test.ts and test/explorer-fit.test.ts. That's 35 tests, none failing.
  • Diff: the pull only touches src/web/studio/explore.ts, src/web/style/content.ts, src/web/ui.ts and test/explorer-fit.test.ts.
  • Push: I pushed an empty commit so the forge runs the check again. If shard 54 fails again on the same tests, it needs a person to look at it.

Pull description

The Explore page now fits a 390 px phone: no sideways scroll, and long content wraps. explore.ts uses listCard with a wrap option instead of hand-rolled markup, and ui.ts and content.ts carry the small style changes behind it. test/explorer-fit.test.ts asserts the fit, including the .bar .seg scroller.

I added no features and no dependencies.

To try it, open /explore in the preview at a 390 px width.

commented

I merged main into the branch and pushed it. There was one conflict, in src/web/style/content.ts, and it is resolved.

  • The conflict: main had added a [data-tell] block for the issue page (#9384) and dropped [data-explore] from the shared overflow-wrap: anywhere selector line. I kept main's whole block and put [data-explore] back into that selector line, so Explore still wraps.
  • Checks: tsc and design-lint are clean. test/explorer-fit.test.ts gives 0 fail, 1 skip and 43 expects. I ran no other tests, so the rest of the suite is left to the forge's check on this push.

Pull description: The Explore page now fits a 390 px phone, with no sideways scroll and long content wrapping. explore.ts uses listCard with a wrap option instead of hand-rolled markup, and ui.ts and content.ts carry the small style changes. test/explorer-fit.test.ts asserts the fit, including the .bar .seg scroller. The branch is merged with current main, and [data-explore] sits in the shared wrap selector next to main's new [data-tell] rules. I added no features and no dependencies. To try it, open /explore in the preview at 390 px width.

commented

I haven't fixed the failing tests. They look intermittent and unrelated to this pull, so I merged current main and pushed to run the check again.

  • Same shard, same tests: crew-review-budget, the table's "not running" cells and origin-guard failed in shard 54 on both runs. The review-budget one hits its 10 s timeout, which points to load.
  • New this run: build-cart failed in shard 62.
  • What I reran: the five related test files, alone and in combination. The one failure I saw was build-cart in a six-file run. It passed alone, in pairs, and when I repeated the six-file run. So this is order-dependent flakiness, not something this pull causes.
  • Why I think it's not this pull: the diff is src/web/studio/explore.ts, src/web/ui.ts, src/web/style/content.ts and test/explorer-fit.test.ts. None of the failing tests touch those files.
  • Merge: main had moved again (the machines work, #9462). It merged cleanly and tsc is clean.

If shard 54 fails again on the same three tests, I'd treat it as flaky on main and have a person look at it. I'd rather not change those tests from this pull.

Pull description

The Explore page now fits a 390 px phone: no sideways scroll, and long content wraps. explore.ts uses listCard with a wrap option instead of hand-rolled markup, and ui.ts and content.ts carry the small style changes. [data-explore] sits in the shared overflow-wrap selector next to main's [data-tell] rules. test/explorer-fit.test.ts asserts the fit, including the .bar .seg scroller. I added no features and no dependencies. To try it, open /explore in the preview at 390 px width.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs