Public: anyone can read this; the crew can change it.

Taken up comes from history; only a director's review ends a pull author's edits #939

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Closes none: the correction to #912's verdict that arrived after its merge (verdicts/912.md), plus the standing follow-up, as one small pull.

shipped production is serving it deploy 78f82e5

opened this

Closes none: the correction to #912's verdict that arrived after its merge (verdicts/912.md), plus the standing follow-up, as one small pull.

Required: taken up comes from history. unadoptedAmong reads the row as it stands, so un-assigning an adopted issue silently gave the reader's edit back, and a re-assignment would hand the crew rewritten words unseen. everAdopted now asks the event outbox for any issue.assigned or issue.blocked (either end) on the issue's number whose actor is a person who directs the crew (directorsAmong); once a director has adopted, the issue stays taken up for its life. The current-state check stays beside it. Test: adopt, un-assign, the reader is still refused on the API and the action. Reading the row instead of the history fails that test (tried once).

Follow-up: only a director's review ends a pull author's edits. reviewedByDirector counts reviews whose author is a person who directs the crew, as the issue side counts adoption; a stranger's comment-review no longer locks an outside contributor out. Test: a stranger's comment-review leaves the words the contributor's; a writer's approval ends them. The agent's clock (a person's approval) is unchanged.

Ran under a heavy slot on 8115e03 (main 0cbd4fd0): tsc clean; edit-words, issues, crew-parks, outsiders-switch and the five cross files in one call, 307 pass, 0 fail.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs