Public: anyone can read this; the crew can change it.

Settings › People fits a 390 px phone: no sideways scroll, long usernames and role controls wrap #9380

Parked opened this
Closed without merging

Settings › People no longer makes a 390 px phone scroll sideways. Its four-column table (account, role, allowance, role form) now scrolls inside its own box, and a long username wraps. What changed src/web/pages/people.ts: the #people table now sits in a .

Notes

stopped parked by the crew deploy 9abdcd9

opened this

Settings › People no longer makes a 390 px phone scroll sideways. Its four-column table (account, role, allowance, role form) now scrolls inside its own box, and a long username wraps.

What changed

  • src/web/pages/people.ts: the #people table now sits in a <div class="table-scroll" data-people>. .table-scroll already exists and sets overflow-x: auto. The page header comment explains why.
  • src/web/style/content.ts: [data-people] joins the existing wrap rule ([data-apps], [data-bet-card], [data-milestone] { overflow-wrap: anywhere; }). It is an attribute, not a new class, and scoped to this page, so no shared component rule changed. With anywhere, a long unbroken username makes its column narrower instead of making the table wider. The role form is already a .row-fields, which puts its input above its button when there is no room.
  • docs/design/areas/settings.md: a short section on the above.
  • test/people-fit.test.ts: new. It seeds 26 accounts and a member with an allowance, so every column shows its widest words. One account gets a 250-character username written straight into the database, because a new account can only take 100 characters. It asserts:
    • no inline width/min-width, and no rule the page ships fixes a width over 390 px;
    • the table is inside the .table-scroll box carrying data-people, and that box's rule sets overflow-wrap: anywhere;
    • .row-fields wraps.

Before the fix: the seed and width checks already passed, so the page fixed no width over 390 px. The wrap and scroll-box check failed until the fix went in.

Measured at 390x844: nothing was printed here, because Chromium is installed but does not start in this sandbox, so that test was skipped. It loads /settings/people and asserts scrollWidth <= innerWidth, that the table's box ends inside the screen, and that no username cell is as wide as the screen. The forge's check runs it and logs a line starting people 390x844:.

Checks: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts pass. I also ran all the *-fit tests, the people, design and settings-route tests, and admin-people-etag (17 files): 95 pass, 8 skipped (Chromium), 0 fail. scripts/fast.ts named 1154 test files because content.ts is shared, so I ran the covering files above rather than the whole suite.

Left alone: the table does not turn into stacked cards on a phone, and no preview look was added, as the issue asks.

To try it, open /settings/people as an admin at 390 px wide: the page stays put, a long username breaks onto several lines, and the role controls scroll inside the card.

🤖 Generated with Claude Code

Closes #9374

2 earlier comments
commented

Settings › People no longer makes a 390 px phone scroll sideways. Its four-column table (account, role, allowance, role form) now scrolls inside its own box, and a long username wraps.

What changed

  • src/web/pages/people.ts: the #people table now sits in a <div class="table-scroll" data-people>. .table-scroll already exists and sets overflow-x: auto. The page header comment explains why.
  • src/web/style/content.ts: [data-people] joins the existing wrap rule ([data-apps], [data-bet-card], [data-milestone] { overflow-wrap: anywhere; }). It is an attribute, not a new class, and scoped to this page, so no shared component rule changed. With anywhere, a long unbroken username makes its column narrower instead of making the table wider. The role form is already a .row-fields, which puts its input above its button when there is no room.
  • docs/design/areas/settings.md: a short section on the above.
  • test/people-fit.test.ts: new. It seeds 26 accounts and a member with an allowance, so every column shows its widest words. One account gets a 250-character username written straight into the database, because a new account can only take 100 characters. It asserts:
    • no inline width/min-width, and no rule the page ships fixes a width over 390 px;
    • the table is inside the .table-scroll box carrying data-people, and that box's rule sets overflow-wrap: anywhere;
    • .row-fields wraps.

Before the fix: the seed and width checks already passed, so the page fixed no width over 390 px. The wrap and scroll-box check failed until the fix went in.

Measured at 390x844: nothing was printed here, because Chromium is installed but does not start in this sandbox, so that test was skipped. It loads /settings/people and asserts scrollWidth <= innerWidth, that the table's box ends inside the screen, and that no username cell is as wide as the screen. The forge's check runs it and logs a line starting people 390x844:.

Checks: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts pass. I also ran all the *-fit tests, the people, design and settings-route tests, and admin-people-etag (17 files): 95 pass, 8 skipped (Chromium), 0 fail. scripts/fast.ts named 1154 test files because content.ts is shared, so I ran the covering files above rather than the whole suite.

Left alone: the table does not turn into stacked cards on a phone, and no preview look was added, as the issue asks.

To try it, open /settings/people as an admin at 390 px wide: the page stays put, a long username breaks onto several lines, and the role controls scroll inside the card.

🤖 Generated with Claude Code

commented

Settings › People now fits a 390 px phone. The people table sits in its own .table-scroll box, so a wide table scrolls inside that box and the page itself never scrolls sideways. Long usernames wrap, because the table's data-people attribute matches the existing overflow-wrap: anywhere rule in src/web/style/content.ts.

What to look at

  • src/web/pages/people.ts: the table is wrapped in the scroll box.
  • src/web/style/content.ts: data-people is added to the shared wrap rule.
  • docs/design/areas/settings.md: notes the pattern.
  • test/people-fit.test.ts: seeds a 250-character username and 26 rows. It checks that no fixed width goes over 390 px, that the username wraps and that the scroll box is there. A further case measures the layout in Chromium at 390×844; it was skipped in this sandbox because Chromium can't run here.

Not done: the column layout is unchanged. I did not turn the rows into cards on narrow screens, since scrolling inside the box is enough to stop the page scrolling sideways.

A second, empty commit adds the Try: line the gate requires; the first commit had none, and the branch can't be force-pushed. The gate, tsc --noEmit, design-lint and test/people-fit.test.ts all pass.

Try: open /settings/people on the preview at 390×844 as the owner. The page does not scroll sideways, the table scrolls inside its own box, and a long username wraps.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs