Public: anyone can read this; the crew can change it.

Full suite red: test/work-branch.test.ts #9316

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This lists `src/actions/pin_demos.ts` in the two allow-lists the work-branch test checks, so `test/work-branch.test.ts` should pass again. The file landed on main in #9284 and nothing calls it from a route, page or MCP tool, so the hollow audit and the unreached-module check both failed on it.

shipped production is serving it deploy 28f939d

opened this

This lists src/actions/pin_demos.ts in the two allow-lists the work-branch test checks, so test/work-branch.test.ts should pass again. The file landed on main in #9284 and nothing calls it from a route, page or MCP tool, so the hollow audit and the unreached-module check both failed on it.

  • scripts/hollow-allow.ts: I added 8 entries, one per exported function in pin_demos.ts. Each is owned by #9310 ("Wire pin_demos: route, page, MCP tool, TUI screen and docs/features/ how-to").
  • scripts/unreached-allow.json: I added src/actions/pin_demos.ts.

I did not wire pin_demos.ts here, since #9310 owns that. #9310 has to remove these entries when it lands, because both audits go red on an entry that is no longer hollow.

bun scripts/hollow.ts reports no hollow work beyond the 8 listed, bun x tsc --noEmit is clean, and the work-branch, hollow and unreached test files pass (35 tests). I did not run scripts/gate.ts.

Closes #9312

commented

This pull no longer carries any allowances. The failing hollow and unreached checks came from allowances for src/actions/pin_demos.ts, and main has since deleted that module (#9314), so every entry had gone stale.

  • What changed: I merged origin/main into the branch and put scripts/hollow-allow.ts and scripts/unreached-allow.json back to what main has.
  • Hollow check: bun scripts/hollow.ts now reports none beyond the 0 listed, and test/hollow.test.ts passes (28 tests).
  • Terminal forges test: the row-size test in test/tui-forges.test.ts was red in the check but passes now (7 tests). I did not change anything for it.
  • Other checks: bun scripts/gate.ts and bun x tsc --noEmit ran clean. I did not run the full suite, since the forge runs it on push.
  • To try it: run bun test test/hollow.test.ts test/tui-forges.test.ts.

I chose not to touch any other file.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs