Public: anyone can read this; the crew can change it.
Full suite red: test/unreached.test.ts #9315
scout/forge:scout/9306-full-suite-red-test-unreached-test-ts → main 2 commits fork
3 files
changed +38
−1
src/http/server.ts +2 −1
| @@ -184,7 +184,7 @@ import { | ||
| 184 | 184 | branchesPage, |
| 185 | 185 | } from "../web/pages/branches.ts"; |
| 186 | 186 | import { iterationsPage, noteSubmit } from "../web/pages/iterations.ts"; |
| 187 | import { buildsPage, deletePinSubmit, newBuildPage, pinBuildSubmit, previewBuildSubmit } from "../web/pages/builds.ts"; | |
| 187 | import { buildsPage, deletePinSubmit, newBuildPage, pinBuildSubmit, previewBuildSubmit, showcaseSubmit } from "../web/pages/builds.ts"; | |
| 188 | 188 | import { shotImage, shotsPage } from "../web/pages/build_shots.ts"; |
| 189 | 189 | import { cartArt, cartPage } from "../web/pages/build_cart.ts"; |
| 190 | 190 | import { wavePage, wavesAtom, wavesPage } from "../web/pages/waves.ts"; |
| @@ -1272,6 +1272,7 @@ export function buildRouter(): Router<Handler> { | ||
| 1272 | 1272 | router.add("POST", "/:owner/:name/builds", pinBuildSubmit); |
| 1273 | 1273 | router.add("POST", "/:owner/:name/builds/preview", previewBuildSubmit); |
| 1274 | 1274 | router.add("POST", "/:owner/:name/builds/:label/delete", deletePinSubmit); |
| 1275 | router.add("POST", "/:owner/:name/builds/:label/showcase", showcaseSubmit); | |
| 1275 | 1276 | router.add("POST", "/:owner/:name/builds/:label/note", noteSubmit); |
| 1276 | 1277 | router.add("GET", "/:owner/:name/waves.atom", wavesAtom); |
| 1277 | 1278 | router.add("GET", "/:owner/:name/waves", wavesPage); |
src/web/pages/builds.ts +26
| @@ -7,6 +7,7 @@ | ||
| 7 | 7 | */ |
| 8 | 8 | |
| 9 | 9 | import { deletePin, pinBuild } from "../../actions/builds.ts"; |
| 10 | import { setShowcase } from "../../actions/pin_demos.ts"; | |
| 10 | 11 | import { previewBuild } from "../../actions/build_preview.ts"; |
| 11 | 12 | import { getAppByRepo } from "../../core/apps.ts"; |
| 12 | 13 | import { openEnvUrl } from "../../actions/apps.ts"; |
| @@ -85,6 +86,24 @@ export async function deletePinSubmit(ctx: Ctx): Promise<Response> { | ||
| 85 | 86 | return flashTo(ctx, to, gone.ok ? { message: `Deleted pin ${gone.value.label}.` } : { tone: "danger", message: "Delete failed." }); |
| 86 | 87 | } |
| 87 | 88 | |
| 89 | // POST /:owner/:name/builds/:label/showcase — `on=1` puts the pin's demo on display pages, anything else takes it off. | |
| 90 | export async function showcaseSubmit(ctx: Ctx): Promise<Response> { | |
| 91 | const repo = loadRepo(ctx); | |
| 92 | if (!repo) return notFoundPage(ctx); | |
| 93 | if (!ctx.auth.user) return signInFirst(ctx); | |
| 94 | const form = await readForm(ctx, "rw"); | |
| 95 | if (form instanceof Response) return form; | |
| 96 | const on = formValue(form, "on") === "1"; | |
| 97 | const done = await setShowcase(ctx.app, ctx.auth.user, repo, ctx.params.label ?? "", on); | |
| 98 | if (!done.ok && hidden(done.error)) return notFoundPage(ctx); | |
| 99 | const to = backTo(form, `${repoBase(repo)}/builds`); | |
| 100 | return flashTo( | |
| 101 | ctx, | |
| 102 | to, | |
| 103 | done.ok ? { message: on ? `Showcased ${done.value.label}.` : `Took ${done.value.label} off the showcase.` } : { tone: "danger", message: "Showcase failed." }, | |
| 104 | ); | |
| 105 | } | |
| 106 | ||
| 88 | 107 | export function buildsCard( |
| 89 | 108 | base: string, |
| 90 | 109 | nodes: readonly BuildNode[], |
| @@ -124,6 +143,13 @@ export function buildsCard( | ||
| 124 | 143 | ${btn("Preview now", { size: "sm", variant: "ghost", icon: "eye" })} |
| 125 | 144 | </form>`, |
| 126 | 145 | )} |
| 146 | ${when( | |
| 147 | canDelete && n.from === undefined, | |
| 148 | () => html`<form method="post" action="${base}/builds/${encodeURIComponent(n.pin.label)}/showcase" class="build-showcase"> | |
| 149 | <input type="hidden" name="on" value="${n.pin.demo?.showcase === true ? "0" : "1"}" /> | |
| 150 | ${btn(n.pin.demo?.showcase === true ? "Unshowcase" : "Showcase", { size: "sm", variant: "ghost" })} | |
| 151 | </form>`, | |
| 152 | )} | |
| 127 | 153 | ${when( |
| 128 | 154 | canDelete && n.from === undefined, |
| 129 | 155 | () => btn("Delete", { |
test/build-pins.test.ts +10
| @@ -257,6 +257,16 @@ describe("build pins pages and notes", () => { | ||
| 257 | 257 | expect(doc).not.toMatch(/^\s*#(?! Intent)(?!# Iterator notes)/m); |
| 258 | 258 | }); |
| 259 | 259 | |
| 260 | test("the showcase form puts a pin's demo on display and takes it off; a stranger's form is refused", async () => { | |
| 261 | const pin = () => listBuildPins(repoDir(app.reposRoot, "alice", "game")).then((p) => p[0]!); | |
| 262 | expect((await post("/alice/game/builds/v1/showcase", { on: "1" }, "https://evil.test")).status).toBe(403); | |
| 263 | expect((await pin()).demo?.showcase ?? false).toBe(false); | |
| 264 | expect((await post("/alice/game/builds/v1/showcase", { on: "1" })).status).toBe(303); | |
| 265 | expect((await pin()).demo?.showcase).toBe(true); | |
| 266 | expect((await post("/alice/game/builds/v1/showcase", { on: "0" })).status).toBe(303); | |
| 267 | expect((await pin()).demo?.showcase).toBe(false); | |
| 268 | }); | |
| 269 | ||
| 260 | 270 | test("deleting a pin removes the ref and the list forgets it; a stranger's form is refused", async () => { |
| 261 | 271 | expect((await post("/alice/game/builds/v1/delete", {}, "https://evil.test")).status).toBe(403); |
| 262 | 272 | expect((await listBuildPins(repoDir(app.reposRoot, "alice", "game"))).length).toBe(1); |
new above
offline