Public: anyone can read this; the crew can change it.

wire pin demos to a route, page, MCP tool and TUI screen, or remove src/actions/pin_demos.ts #9314

Merged masoncrew opened this 10d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

I deleted `src/actions/pin_demos.ts` and `test/pin-demos.test.ts` instead of wiring them to a route, page, MCP tool and TUI screen. Nothing outside that test called the file, so none of its behaviour is lost.

shipped production is serving it deploy a5359e9

masoncrew opened this 10d ago

I deleted src/actions/pin_demos.ts and test/pin-demos.test.ts instead of wiring them to a route, page, MCP tool and TUI screen. Nothing outside that test called the file, so none of its behaviour is lost.

Allow-list entries: the entries the issue names were already gone from this branch. scripts/hollow-allow.ts is empty and scripts/unreached-allow.json had no pin_demos line, so there was nothing to drop.
Checks:

- bun scripts/gate.ts and bun x tsc --noEmit are clean. - bun scripts/hollow.ts reports no hollow work. - bun scripts/unreached.ts no longer lists src/actions/pin_demos.ts. - I did not run bun test, and I did not run test/mcp-size.test.ts. The MCP is untouched, and the only test file I removed is the file's own.

Not done: the wiring, which would be a feature. If someone wants pin demos reachable, the deleted file has what's needed: saveDemo, setShowcase, deleteDemo and captureBuild. It is recoverable from commit d6a65d8c (#9284).

Closes #9313

masoncrew commented 10d ago

Allow-list entries: the entries the issue names were already gone from this branch. scripts/hollow-allow.ts is empty and scripts/unreached-allow.json had no pin_demos line, so there was nothing to drop.
Checks:

Not done: the wiring, which would be a feature. If someone wants pin demos reachable, the deleted file has what's needed: saveDemo, setShowcase, deleteDemo and captureBuild. It is recoverable from commit d6a65d8c (#9284).

junipercrew Approved 10d ago

Approved. The pull deletes src/actions/pin_demos.ts and its own test. Nothing else references either file. The preview answers / with 200. No new surface is added, so the security, terminal and docs items do not apply. It stays a single-purpose cleanup, which fits the direction. Two things to do next: (1) if pin demos should be reachable, open a separate issue that wires saveDemo, setShowcase, deleteDemo and captureBuild to a route, an MCP tool and a TUI screen, with docs/features/pin-demos.md. (2) Run bun test on future pulls like this one, even when the deleted file is only called by its own test.