Full suite red: test/hollow-cli.test.ts #9308

bun scripts/hollow.ts now prints hollow: none beyond the 8 listed in scripts/hollow-allow.ts and exits 0. test/hollow-cli.test.ts and test/hollow.test.ts pass (29 tests), and tsc --noEmit is clean. I did not run scripts/gate.ts or the full suite.

Cause: #9284 put src/actions/pin_demos.ts on main with eight exported functions that no route, page or MCP tool calls. The hollow-work audit flags those, so bun scripts/hollow.ts exited 1 and the test failed. The functions are captureBuild, deleteDemo, demoDefaults, demoFactsAt, saveDemo, setShowcase, unshowcaseDemo and writerOf.

Change: I added the eight functions to ALLOWED in scripts/hollow-allow.ts, each with a reason and owned by #9284. I took #9284 as the owner from the commit message and did not look the issue up. The audit goes red on an entry once it becomes reachable, so each one has to leave the list in the pull that wires it.

Not done: I did not wire the pin demos to a route, page or MCP tool. That is a feature in its own right, not a fix for a red test. Someone needs to open or pick the issue that adds the surface and takes these entries off the list.

To try it: run bun scripts/hollow.ts, or bun test test/hollow-cli.test.ts.

Closes #9305

bun scripts/hollow.ts now prints hollow: none beyond the 8 listed in scripts/hollow-allow.ts and exits 0. test/hollow-cli.test.ts and test/hollow.test.ts pass (29 tests), and tsc --noEmit is clean. I did not run scripts/gate.ts or the full suite.

Cause: #9284 put src/actions/pin_demos.ts on main with eight exported functions that no route, page or MCP tool calls. The hollow-work audit flags those, so bun scripts/hollow.ts exited 1 and the test failed. The functions are captureBuild, deleteDemo, demoDefaults, demoFactsAt, saveDemo, setShowcase, unshowcaseDemo and writerOf.

Change: I added the eight functions to ALLOWED in scripts/hollow-allow.ts, each with a reason and owned by #9284. I took #9284 as the owner from the commit message and did not look the issue up. The audit goes red on an entry once it becomes reachable, so each one has to leave the list in the pull that wires it.

Not done: I did not wire the pin demos to a route, page or MCP tool. That is a feature in its own right, not a fix for a red test. Someone needs to open or pick the issue that adds the surface and takes these entries off the list.

To try it: run bun scripts/hollow.ts, or bun test test/hollow-cli.test.ts.

This pull fixes one of the two failing tests. I didn't change anything for the other one, and I haven't confirmed why it failed.

Fixed: "every module under src/ is imported by another, or allowed" failed because src/actions/pin_demos.ts is imported only by tests. I added it to scripts/unreached-allow.json, next to the matching hollow entries for #9284. It leaves the list when #9284 wires a route, page or MCP tool to it.

Not fixed: "a row says its size and use…" in test/tui-forges.test.ts passes when I run it alone. It failed only in shard 7 of the full check. This pull doesn't touch that code, so I think it's flaky, but I haven't confirmed it. If it fails again on this push, it needs its own look.

Before pushing I ran test/unreached.test.ts, test/tui-forges.test.ts and test/pin-demos.test.ts (all pass), plus bun scripts/gate.ts and bun x tsc --noEmit (both clean).

This pull turns the full suite green by listing src/actions/pin_demos.ts as hollow work until someone wires it up. It adds no feature.

• Issue: #9313, "wire pin demos to a route, page, MCP tool and TUI screen, or remove src/actions/pin_demos.ts", is now the open owner. All eight pin_demos.ts#… entries in scripts/hollow-allow.ts use issue: 9313. They previously named #9284, the merged pull that landed the file.
• scripts/unreached-allow.json: its src/actions/pin_demos.ts line is owned by #9313 too. It leaves the list in the same pull that wires or removes the file.
• Left out: wiring the demos, which is a feature.
• Checks: test/unreached.test.ts, test/hollow-cli.test.ts and bun scripts/gate.ts pass. In an earlier full check, test/tui-forges.test.ts ("a row says its size and use…") failed once in a shard, and it passes when run alone. I think it's flaky and nothing here touches it.
• To try: bun test test/unreached.test.ts test/hollow-cli.test.ts.

I merged main into the branch and pushed. After the merge, my branch matches main exactly, so the pull no longer changes anything on its own.

Why the check failed: my earlier commits added pin_demos entries to scripts/hollow-allow.ts and scripts/unreached-allow.json. In the meantime main removed src/actions/pin_demos.ts (#9314) and emptied both lists. The hollow and unreached audits then failed on entries pointing at a file that no longer exists.

What I did: I took main's version of those two files and dropped my stale entries.

What I ran:

• bun scripts/gate.ts and bun x tsc --noEmit are clean.
• test/tui-forges.test.ts, test/unreached.test.ts and test/hollow.test.ts all pass (39 tests).
• I did not run the full suite.
• The "forges you sent in the terminal" row test passed on my branch even before the merge, so I didn't change anything specific to it. I'm assuming it failed in the check for the same stale-entry reason.