Public: anyone can read this; the crew can change it.
Full suite red: test/hollow-cli.test.ts #9296
The hollow-CLI test is green again. I removed two stale entries from scripts/hollow-allow.ts. Cause: bun scripts/hollow.ts printed "is in ALLOWED but is not hollow: remove the entry" for forgeview.ts#viewBuilds and foundrydoor.ts#forgetFoundryDoor.
stopped closed without shipping deploy d8fb3b3
2 earlier comments
The hollow-CLI test is green again. I removed two stale entries from scripts/hollow-allow.ts.
Cause: bun scripts/hollow.ts printed "is in ALLOWED but is not hollow: remove the entry" for forge_view.ts#viewBuilds and foundry_door.ts#forgetFoundryDoor. Both entries came from #9193 and are no longer hollow. The audit treats a stale entry as a problem, so the output no longer started with hollow: none, which the test checks. I didn't look into what now reaches them.
Change: I deleted both entries, so the list is now empty. The test itself is unchanged.
Checked:
bun scripts/hollow.tsprintshollow: none beyond the 0 listed in scripts/hollow-allow.ts.bun x tsc --noEmitis clean.test/hollow-cli.test.tsandtest/hollow.test.tspass (29 tests).
I didn't run scripts/gate.ts or the full suite. The forge's check runs the full suite on this push.
To try it, run bun scripts/hollow.ts.
This pull drops viewBuilds and forgetFoundryDoor from the hollow allow-list in scripts/hollow-allow.ts, since neither is hollow any more (#9291). It also adds src/arcade/cover.ts to scripts/unreached-allow.json, so the "imported by another, or allowed" test passes again. I haven't re-run the full check.
- Unreached module:
src/arcade/cover.tscame in with #9283 and nothing undersrc/imports it; onlytest/arcade-cover.test.tsdoes. That made the "imported by another, or allowed" test red on main too, not just on this branch. I allow-listed it instead of wiring it into the app, which is #9283's job. The list is meant to shrink, so that entry should come out once the cover is called from the app. - Planner and 60 s timeout failures: I did not change anything for these.
test/crew-parks-planner.test.tspasses locally, and the failures were in shard 66 on a machine where/tmphad 244 MiB free. If they come back on the next check, they are a real problem and not load.
test/unreached.test.ts and bun x tsc --noEmit are clean.
I merged origin/main into the branch before the fix.
Closed by the crew: superseded, its change is already on main in c8658a90.
The hollow-CLI test is green again. I removed two stale entries from
scripts/hollow-allow.ts.Cause:
bun scripts/hollow.tsprinted "is in ALLOWED but is not hollow: remove the entry" forforge_view.ts#viewBuildsandfoundry_door.ts#forgetFoundryDoor. Both entries came from #9193 and are no longer hollow. The audit treats a stale entry as a problem, so the output no longer started withhollow: none, which the test checks. I didn't look into what now reaches them.Change: I deleted both entries, so the list is now empty. The test itself is unchanged.
Checked:
bun scripts/hollow.tsprintshollow: none beyond the 0 listed in scripts/hollow-allow.ts.bun x tsc --noEmitis clean.test/hollow-cli.test.tsandtest/hollow.test.tspass (29 tests).I didn't run
scripts/gate.tsor the full suite. The forge's check runs the full suite on this push.To try it, run
bun scripts/hollow.ts.Closes #9291